Skip to content

Conversation

@rzuckerm
Copy link
Collaborator

@rzuckerm rzuckerm commented May 3, 2025

Congrats on taking the first step to contributing to the Sample Programs repository maintained by The Renegade Coder!
For simplicity, please make sure that your pull request includes one and only one contribution.

Please fill one of the sections below as applicable.
Please also add any other relevant information to the Notes section at the bottom.
You may delete or just ignore any other sections.
For more information please refer to our contributing documentation

I Am Modifying an Existing Code Snippet or Existing Tests

Other Notes

The upgrade to Node 20 required some of the samples to change. For instance, when outputting an array, Node 20 would add an extra newline in the array, so to fix this, I used arr.join(", "). While I was in there, I also add semicolons to the end of each line. While this is not a requirement, it is highly recommended.

@rzuckerm rzuckerm added enhancement Any code that improves the repo tests Testing related labels May 3, 2025
@rzuckerm rzuckerm marked this pull request as ready for review May 3, 2025 14:32
@rzuckerm rzuckerm enabled auto-merge (squash) May 3, 2025 14:32
Copy link
Member

@jrg94 jrg94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done! Love the style cleanup too.

@rzuckerm rzuckerm merged commit 91e1bcd into TheRenegadeCoder:main May 4, 2025
7 checks passed
@rzuckerm rzuckerm deleted the update-js-node branch May 4, 2025 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Any code that improves the repo tests Testing related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Version of node is out-of-date for JavaScript

2 participants