Skip to content

refactor(controlbar): Simplify code for acquiring the currently viewed player #2841

refactor(controlbar): Simplify code for acquiring the currently viewed player

refactor(controlbar): Simplify code for acquiring the currently viewed player #2841

Triggered via pull request August 17, 2025 16:48
Status Success
Total duration 10m 42s
Artifacts 14

ci.yml

on: pull_request
Detect File Changes
9s
Detect File Changes
Matrix: build-generalsmd-vc6
Matrix: build-generals
Matrix: build-generalsmd-win32
Matrix: replaycheck-generalsmd
Fit to window
Zoom out
Zoom in

Annotations

130 warnings and 2 notices
Build GeneralsMD / vc6-debug+t+e: Core/Tools/Autorun/GameText.cpp#L1124
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-debug+t+e: Core/Tools/Autorun/GameText.cpp#L1048
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-debug+t+e: Core/Tools/Autorun/GameText.cpp#L824
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-debug+t+e: Core/Tools/Autorun/GameText.cpp#L1124
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-debug+t+e: Core/Tools/Autorun/GameText.cpp#L1048
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-debug+t+e: Core/Tools/Autorun/GameText.cpp#L824
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-debug+t+e: Core/Tools/Autorun/GameText.cpp#L1124
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-debug+t+e: Core/Tools/Autorun/GameText.cpp#L1048
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-debug+t+e: Core/Tools/Autorun/GameText.cpp#L824
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-debug+t+e: Core/Libraries/Source/WWVegas/WWDownload/registry.cpp#L25
'WIN32_LEAN_AND_MEAN' : macro redefinition
Build Generals / vc6-profile+t+e: Core/Tools/Autorun/GameText.cpp#L1124
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6-profile+t+e: Core/Tools/Autorun/GameText.cpp#L1048
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6-profile+t+e: Core/Tools/Autorun/GameText.cpp#L824
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6-profile+t+e: Core/Tools/Autorun/GameText.cpp#L1124
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6-profile+t+e: Core/Tools/Autorun/GameText.cpp#L1048
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6-profile+t+e: Core/Tools/Autorun/GameText.cpp#L824
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6-profile+t+e: Core/Tools/Autorun/GameText.cpp#L1124
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6-profile+t+e: Core/Tools/Autorun/GameText.cpp#L1048
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6-profile+t+e: Core/Tools/Autorun/GameText.cpp#L824
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6-profile+t+e: Core/Libraries/Source/WWVegas/WWDownload/registry.cpp#L25
'WIN32_LEAN_AND_MEAN' : macro redefinition
Build Generals / vc6+t+e: Core/Tools/Autorun/GameText.cpp#L1124
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6+t+e: Core/Tools/Autorun/GameText.cpp#L1048
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6+t+e: Core/Tools/Autorun/GameText.cpp#L824
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6+t+e: Core/Tools/Autorun/GameText.cpp#L1124
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6+t+e: Core/Tools/Autorun/GameText.cpp#L1048
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6+t+e: Core/Tools/Autorun/GameText.cpp#L824
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6+t+e: Core/Tools/Autorun/GameText.cpp#L1124
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6+t+e: Core/Tools/Autorun/GameText.cpp#L1048
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6+t+e: Core/Tools/Autorun/GameText.cpp#L824
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6+t+e: Core/Libraries/Source/WWVegas/WWDownload/registry.cpp#L25
'WIN32_LEAN_AND_MEAN' : macro redefinition
Build GeneralsMD / vc6+t+e: Core/Tools/Autorun/GameText.cpp#L1124
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6+t+e: Core/Tools/Autorun/GameText.cpp#L1048
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6+t+e: Core/Tools/Autorun/GameText.cpp#L824
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6+t+e: Core/Tools/Autorun/GameText.cpp#L1124
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6+t+e: Core/Tools/Autorun/GameText.cpp#L1048
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6+t+e: Core/Tools/Autorun/GameText.cpp#L824
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6+t+e: Core/Tools/Autorun/GameText.cpp#L1124
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6+t+e: Core/Tools/Autorun/GameText.cpp#L1048
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6+t+e: Core/Tools/Autorun/GameText.cpp#L824
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6+t+e: Core/Libraries/Source/WWVegas/WWDownload/registry.cpp#L25
'WIN32_LEAN_AND_MEAN' : macro redefinition
Build GeneralsMD / vc6-releaselog+t+e: Core/Tools/Autorun/GameText.cpp#L1124
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-releaselog+t+e: Core/Tools/Autorun/GameText.cpp#L1048
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-releaselog+t+e: Core/Tools/Autorun/GameText.cpp#L824
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-releaselog+t+e: Core/Tools/Autorun/GameText.cpp#L1124
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-releaselog+t+e: Core/Tools/Autorun/GameText.cpp#L1048
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-releaselog+t+e: Core/Tools/Autorun/GameText.cpp#L824
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-releaselog+t+e: Core/Tools/Autorun/GameText.cpp#L1124
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-releaselog+t+e: Core/Tools/Autorun/GameText.cpp#L1048
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-releaselog+t+e: Core/Tools/Autorun/GameText.cpp#L824
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-profile+t+e: Core/Tools/Autorun/GameText.cpp#L1124
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-profile+t+e: Core/Tools/Autorun/GameText.cpp#L1048
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-profile+t+e: Core/Tools/Autorun/GameText.cpp#L824
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-profile+t+e: Core/Tools/Autorun/GameText.cpp#L1124
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-profile+t+e: Core/Tools/Autorun/GameText.cpp#L1048
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-profile+t+e: Core/Tools/Autorun/GameText.cpp#L824
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-profile+t+e: Core/Tools/Autorun/GameText.cpp#L1124
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-profile+t+e: Core/Tools/Autorun/GameText.cpp#L1048
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-profile+t+e: Core/Tools/Autorun/GameText.cpp#L824
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6-debug+t+e: Core/Tools/Autorun/GameText.cpp#L1124
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6-debug+t+e: Core/Tools/Autorun/GameText.cpp#L1048
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6-debug+t+e: Core/Tools/Autorun/GameText.cpp#L824
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6-debug+t+e: Core/Tools/Autorun/GameText.cpp#L1124
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6-debug+t+e: Core/Tools/Autorun/GameText.cpp#L1048
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6-debug+t+e: Core/Tools/Autorun/GameText.cpp#L824
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6-debug+t+e: Core/Tools/Autorun/GameText.cpp#L1124
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6-debug+t+e: Core/Tools/Autorun/GameText.cpp#L1048
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6-debug+t+e: Core/Tools/Autorun/GameText.cpp#L824
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6-debug+t+e: Core/Libraries/Source/WWVegas/WWDownload/registry.cpp#L25
'WIN32_LEAN_AND_MEAN' : macro redefinition
Build Generals / win32-debug+t+e: Core/Libraries/Source/debug/debug_debug.cpp#L260
calling _set_se_translator() requires /EHa
Build Generals / win32-debug+t+e: Core/Libraries/Source/WWVegas/WWDownload/registry.cpp#L25
'WIN32_LEAN_AND_MEAN': macro redefinition
Build Generals / win32-debug+t+e: Core/Libraries/Source/WWVegas/WWDownload/FTP.CPP#L668
'=': conversion from 'time_t' to 'int', possible loss of data
Build Generals / win32-debug+t+e
operands are different enum types 'SBServerListState' and 'SBState'; use an explicit cast to silence this warning
Build Generals / win32-debug+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build Generals / win32-debug+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build GeneralsMD / win32-debug+t+e: Core/Libraries/Source/debug/debug_debug.cpp#L260
calling _set_se_translator() requires /EHa
Build GeneralsMD / win32-debug+t+e: Core/Libraries/Source/WWVegas/WWDownload/FTP.CPP#L668
'=': conversion from 'time_t' to 'int', possible loss of data
Build GeneralsMD / win32-debug+t+e
operands are different enum types 'SBServerListState' and 'SBState'; use an explicit cast to silence this warning
Build GeneralsMD / win32-debug+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build GeneralsMD / win32-debug+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build Generals / win32-profile+t+e: Core/Libraries/Source/debug/debug_debug.cpp#L260
calling _set_se_translator() requires /EHa
Build Generals / win32-profile+t+e: Core/Libraries/Source/WWVegas/WWDownload/FTP.CPP#L668
'=': conversion from 'time_t' to 'int', possible loss of data
Build Generals / win32-profile+t+e
operands are different enum types 'SBServerListState' and 'SBState'; use an explicit cast to silence this warning
Build Generals / win32-profile+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build Generals / win32-profile+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build Generals / win32+t+e: Core/Libraries/Source/debug/debug_debug.cpp#L260
calling _set_se_translator() requires /EHa
Build Generals / win32+t+e: Core/Libraries/Source/WWVegas/WWDownload/registry.cpp#L25
'WIN32_LEAN_AND_MEAN': macro redefinition
Build Generals / win32+t+e: Core/Libraries/Source/WWVegas/WWDownload/FTP.CPP#L668
'=': conversion from 'time_t' to 'int', possible loss of data
Build Generals / win32+t+e
operands are different enum types 'SBServerListState' and 'SBState'; use an explicit cast to silence this warning
Build Generals / win32+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build Generals / win32+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build GeneralsMD / win32+t+e: Core/Libraries/Source/debug/debug_debug.cpp#L260
calling _set_se_translator() requires /EHa
Build GeneralsMD / win32+t+e: Core/Libraries/Source/WWVegas/WWDownload/registry.cpp#L25
'WIN32_LEAN_AND_MEAN': macro redefinition
Build GeneralsMD / win32+t+e: Core/Libraries/Source/WWVegas/WWDownload/FTP.CPP#L668
'=': conversion from 'time_t' to 'int', possible loss of data
Build GeneralsMD / win32+t+e
operands are different enum types 'SBServerListState' and 'SBState'; use an explicit cast to silence this warning
Build GeneralsMD / win32+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build GeneralsMD / win32+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build GeneralsMD / win32-profile+t+e: Core/Libraries/Source/debug/debug_debug.cpp#L260
calling _set_se_translator() requires /EHa
Build GeneralsMD / win32-profile+t+e: Core/Libraries/Source/WWVegas/WWDownload/FTP.CPP#L668
'=': conversion from 'time_t' to 'int', possible loss of data
Build GeneralsMD / win32-profile+t+e
operands are different enum types 'SBServerListState' and 'SBState'; use an explicit cast to silence this warning
Build GeneralsMD / win32-profile+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build GeneralsMD / win32-profile+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Replay Check GeneralsMD / vc6+t+e
The windows-latest label will migrate from Windows Server 2022 to Windows Server 2025 beginning September 2, 2025. For more information see https://github.com/actions/runner-images/issues/12677
Replay Check GeneralsMD / vc6-releaselog+t+e
The windows-latest label will migrate from Windows Server 2022 to Windows Server 2025 beginning September 2, 2025. For more information see https://github.com/actions/runner-images/issues/12677

Artifacts

Produced during runtime
Name Size Digest
Generals-vc6+t+e Expired
15.9 MB
sha256:cfb066b80ed6331d240e0e541309905d80c2ab7f69f4091bf1ec01a512791845
Generals-vc6-debug+t+e Expired
51 MB
sha256:89246f10fb6cd4bbc6f3c17d8a1864f85a6e9461d6a5844316ee2a777a32433b
Generals-vc6-profile+t+e Expired
15.9 MB
sha256:a2032cea5c8ab31d4cdba4a4a646520b6b98dd1d69df155ceb29ecb1d230af71
Generals-win32+t+e Expired
89.3 MB
sha256:fe63628043ca0c1dbc1a323277c5e14b7eeb627e97f8058ddf8996e74a44ea32
Generals-win32-debug+t+e Expired
208 MB
sha256:ba992743009402ccba57fdc6f7f4e1bcbae35bea21d82f45d125d289ff7f04e8
Generals-win32-profile+t+e Expired
89.2 MB
sha256:1eb9074a2a58baf8b28851f6fadd4c31519af1ff25826e3789c29d40ba508db3
GeneralsMD-vc6+t+e Expired
17.2 MB
sha256:348835056a9e55e844c3e1999c55338768015732ef2b60da26238ad0171b87a7
GeneralsMD-vc6-debug+t+e Expired
54.3 MB
sha256:afe0d14c51d2e5aefdbefd8024803dbe945e98bbbe4e1bec920958a36f3dd1f5
GeneralsMD-vc6-profile+t+e Expired
17.3 MB
sha256:4dc25d2faf0989950e72d65b2a900c83ddca68eb3b573cc54b0056322ee05c0f
GeneralsMD-vc6-releaselog+t+e Expired
30.4 MB
sha256:9ed269a9f91a97c8db978843f70d2d59f2b949ce76f7269aa3736570eb88ee7c
GeneralsMD-win32+t+e Expired
95 MB
sha256:e1fe2850c914de714e062b097dcb8b947e1fff7c279e6c0dfde76e61829526a4
GeneralsMD-win32-debug+t+e Expired
220 MB
sha256:d3a0d6eb0c0a448c4327c8c92e4a23ce3873ae834c546e4f7e0e6a8f210dff72
GeneralsMD-win32-profile+t+e Expired
95.4 MB
sha256:a8d13e8c47484a029d64102036e0529089c594f013107c7386527156b6bd523f
Replay-Debug-Log-vc6-releaselog+t+e Expired
2.8 MB
sha256:a49fa6f2a1bfa6b01c6a283629f609aaf79fcf6a22530000f9098025445d721b