Skip to content

refactor: Remove superfluous null tests before calls to free() #3097

refactor: Remove superfluous null tests before calls to free()

refactor: Remove superfluous null tests before calls to free() #3097

Triggered via pull request September 12, 2025 07:18
Status Success
Total duration 14m 0s
Artifacts 14

ci.yml

on: pull_request
Detect File Changes
6s
Detect File Changes
Matrix: build-generalsmd-vc6
Matrix: build-generals
Matrix: build-generalsmd-win32
Matrix: replaycheck-generalsmd
Fit to window
Zoom out
Zoom in

Annotations

130 warnings and 2 notices
Build Generals / vc6+t+e: Core/Tools/Autorun/GameText.cpp#L1124
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6+t+e: Core/Tools/Autorun/GameText.cpp#L1048
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6+t+e: Core/Tools/Autorun/GameText.cpp#L824
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6+t+e: Core/Tools/Autorun/GameText.cpp#L1124
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6+t+e: Core/Tools/Autorun/GameText.cpp#L1048
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6+t+e: Core/Tools/Autorun/GameText.cpp#L824
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6+t+e: Core/Tools/Autorun/GameText.cpp#L1124
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6+t+e: Core/Tools/Autorun/GameText.cpp#L1048
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6+t+e: Core/Tools/Autorun/GameText.cpp#L824
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6+t+e: Core/Libraries/Source/WWVegas/WWDownload/registry.cpp#L25
'WIN32_LEAN_AND_MEAN' : macro redefinition
Build Generals / vc6-debug+t+e: Core/Tools/Autorun/GameText.cpp#L1124
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6-debug+t+e: Core/Tools/Autorun/GameText.cpp#L1048
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6-debug+t+e: Core/Tools/Autorun/GameText.cpp#L824
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6-debug+t+e: Core/Tools/Autorun/GameText.cpp#L1124
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6-debug+t+e: Core/Tools/Autorun/GameText.cpp#L1048
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6-debug+t+e: Core/Tools/Autorun/GameText.cpp#L824
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6-debug+t+e: Core/Tools/Autorun/GameText.cpp#L1124
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6-debug+t+e: Core/Tools/Autorun/GameText.cpp#L1048
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6-debug+t+e: Core/Tools/Autorun/GameText.cpp#L824
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6-debug+t+e: Core/Libraries/Source/WWVegas/WWDownload/registry.cpp#L25
'WIN32_LEAN_AND_MEAN' : macro redefinition
Build GeneralsMD / vc6-releaselog+t+e: Core/Tools/Autorun/GameText.cpp#L1124
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-releaselog+t+e: Core/Tools/Autorun/GameText.cpp#L1048
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-releaselog+t+e: Core/Tools/Autorun/GameText.cpp#L824
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-releaselog+t+e: Core/Tools/Autorun/GameText.cpp#L1124
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-releaselog+t+e: Core/Tools/Autorun/GameText.cpp#L1048
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-releaselog+t+e: Core/Tools/Autorun/GameText.cpp#L824
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-releaselog+t+e: Core/Tools/Autorun/GameText.cpp#L1124
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-releaselog+t+e: Core/Tools/Autorun/GameText.cpp#L1048
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-releaselog+t+e: Core/Tools/Autorun/GameText.cpp#L824
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-profile+t+e: Core/Tools/Autorun/GameText.cpp#L1124
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-profile+t+e: Core/Tools/Autorun/GameText.cpp#L1048
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-profile+t+e: Core/Tools/Autorun/GameText.cpp#L824
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-profile+t+e: Core/Tools/Autorun/GameText.cpp#L1124
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-profile+t+e: Core/Tools/Autorun/GameText.cpp#L1048
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-profile+t+e: Core/Tools/Autorun/GameText.cpp#L824
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-profile+t+e: Core/Tools/Autorun/GameText.cpp#L1124
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-profile+t+e: Core/Tools/Autorun/GameText.cpp#L1048
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-profile+t+e: Core/Tools/Autorun/GameText.cpp#L824
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6-profile+t+e: Core/Tools/Autorun/GameText.cpp#L1124
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6-profile+t+e: Core/Tools/Autorun/GameText.cpp#L1048
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6-profile+t+e: Core/Tools/Autorun/GameText.cpp#L824
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6-profile+t+e: Core/Tools/Autorun/GameText.cpp#L1124
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6-profile+t+e: Core/Tools/Autorun/GameText.cpp#L1048
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6-profile+t+e: Core/Tools/Autorun/GameText.cpp#L824
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6-profile+t+e: Core/Tools/Autorun/GameText.cpp#L1124
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6-profile+t+e: Core/Tools/Autorun/GameText.cpp#L1048
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6-profile+t+e: Core/Tools/Autorun/GameText.cpp#L824
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6-profile+t+e: Core/Libraries/Source/WWVegas/WWDownload/registry.cpp#L25
'WIN32_LEAN_AND_MEAN' : macro redefinition
Build GeneralsMD / vc6-debug+t+e: Core/Tools/Autorun/GameText.cpp#L1124
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-debug+t+e: Core/Tools/Autorun/GameText.cpp#L1048
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-debug+t+e: Core/Tools/Autorun/GameText.cpp#L824
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-debug+t+e: Core/Tools/Autorun/GameText.cpp#L1124
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-debug+t+e: Core/Tools/Autorun/GameText.cpp#L1048
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-debug+t+e: Core/Tools/Autorun/GameText.cpp#L824
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-debug+t+e: Core/Tools/Autorun/GameText.cpp#L1124
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-debug+t+e: Core/Tools/Autorun/GameText.cpp#L1048
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-debug+t+e: Core/Tools/Autorun/GameText.cpp#L824
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-debug+t+e: Core/Libraries/Source/WWVegas/WWDownload/registry.cpp#L25
'WIN32_LEAN_AND_MEAN' : macro redefinition
Build GeneralsMD / vc6+t+e: Core/Tools/Autorun/GameText.cpp#L1124
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6+t+e: Core/Tools/Autorun/GameText.cpp#L1048
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6+t+e: Core/Tools/Autorun/GameText.cpp#L824
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6+t+e: Core/Tools/Autorun/GameText.cpp#L1124
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6+t+e: Core/Tools/Autorun/GameText.cpp#L1048
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6+t+e: Core/Tools/Autorun/GameText.cpp#L824
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6+t+e: Core/Tools/Autorun/GameText.cpp#L1124
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6+t+e: Core/Tools/Autorun/GameText.cpp#L1048
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6+t+e: Core/Tools/Autorun/GameText.cpp#L824
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6+t+e: Core/Libraries/Source/WWVegas/WWDownload/registry.cpp#L25
'WIN32_LEAN_AND_MEAN' : macro redefinition
Build Generals / win32-debug+t+e: Core/Libraries/Source/debug/debug_debug.cpp#L260
calling _set_se_translator() requires /EHa
Build Generals / win32-debug+t+e: Core/Libraries/Source/WWVegas/WWDownload/registry.cpp#L25
'WIN32_LEAN_AND_MEAN': macro redefinition
Build Generals / win32-debug+t+e: Core/Libraries/Source/WWVegas/WWDownload/FTP.CPP#L668
'=': conversion from 'time_t' to 'int', possible loss of data
Build Generals / win32-debug+t+e
operands are different enum types 'SBServerListState' and 'SBState'; use an explicit cast to silence this warning
Build Generals / win32-debug+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build Generals / win32-debug+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build GeneralsMD / win32-debug+t+e: Core/Libraries/Source/debug/debug_debug.cpp#L260
calling _set_se_translator() requires /EHa
Build GeneralsMD / win32-debug+t+e: Core/Libraries/Source/WWVegas/WWDownload/FTP.CPP#L668
'=': conversion from 'time_t' to 'int', possible loss of data
Build GeneralsMD / win32-debug+t+e
operands are different enum types 'SBServerListState' and 'SBState'; use an explicit cast to silence this warning
Build GeneralsMD / win32-debug+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build GeneralsMD / win32-debug+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build Generals / win32+t+e: Core/Libraries/Source/debug/debug_debug.cpp#L260
calling _set_se_translator() requires /EHa
Build Generals / win32+t+e: Core/Libraries/Source/WWVegas/WWDownload/registry.cpp#L25
'WIN32_LEAN_AND_MEAN': macro redefinition
Build Generals / win32+t+e: Core/Libraries/Source/WWVegas/WWDownload/FTP.CPP#L668
'=': conversion from 'time_t' to 'int', possible loss of data
Build Generals / win32+t+e
operands are different enum types 'SBServerListState' and 'SBState'; use an explicit cast to silence this warning
Build Generals / win32+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build Generals / win32+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build GeneralsMD / win32+t+e: Core/Libraries/Source/debug/debug_debug.cpp#L260
calling _set_se_translator() requires /EHa
Build GeneralsMD / win32+t+e: Core/Libraries/Source/WWVegas/WWDownload/registry.cpp#L25
'WIN32_LEAN_AND_MEAN': macro redefinition
Build GeneralsMD / win32+t+e: Core/Libraries/Source/WWVegas/WWDownload/FTP.CPP#L668
'=': conversion from 'time_t' to 'int', possible loss of data
Build GeneralsMD / win32+t+e
operands are different enum types 'SBServerListState' and 'SBState'; use an explicit cast to silence this warning
Build GeneralsMD / win32+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build GeneralsMD / win32+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build GeneralsMD / win32-profile+t+e: Core/Libraries/Source/debug/debug_debug.cpp#L260
calling _set_se_translator() requires /EHa
Build GeneralsMD / win32-profile+t+e: Core/Libraries/Source/WWVegas/WWDownload/FTP.CPP#L668
'=': conversion from 'time_t' to 'int', possible loss of data
Build GeneralsMD / win32-profile+t+e
operands are different enum types 'SBServerListState' and 'SBState'; use an explicit cast to silence this warning
Build GeneralsMD / win32-profile+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build GeneralsMD / win32-profile+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build Generals / win32-profile+t+e: Core/Libraries/Source/debug/debug_debug.cpp#L260
calling _set_se_translator() requires /EHa
Build Generals / win32-profile+t+e: Core/Libraries/Source/WWVegas/WWDownload/FTP.CPP#L668
'=': conversion from 'time_t' to 'int', possible loss of data
Build Generals / win32-profile+t+e
operands are different enum types 'SBServerListState' and 'SBState'; use an explicit cast to silence this warning
Build Generals / win32-profile+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build Generals / win32-profile+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Replay Check GeneralsMD / vc6+t+e
The windows-latest label will migrate from Windows Server 2022 to Windows Server 2025 beginning September 2, 2025. For more information see https://github.com/actions/runner-images/issues/12677
Replay Check GeneralsMD / vc6-releaselog+t+e
The windows-latest label will migrate from Windows Server 2022 to Windows Server 2025 beginning September 2, 2025. For more information see https://github.com/actions/runner-images/issues/12677

Artifacts

Produced during runtime
Name Size Digest
Generals-vc6+t+e Expired
16 MB
sha256:54b43ae6fda86f7e8253430f2f85108646568616d93420e9b9e6cced27f467e0
Generals-vc6-debug+t+e Expired
51.1 MB
sha256:62d9ed7f44b6aca372daebe19204fcc40200e78e0960a10b87d7140f16f0543f
Generals-vc6-profile+t+e Expired
16 MB
sha256:3a65748847b38821fcd93c79b93ee605e80b72acaeb16a2186e512554797a509
Generals-win32+t+e Expired
89.7 MB
sha256:f3e54d41c7cb3882e45c40d7b389470bb7f046c099037e213c0ea86594ba4c82
Generals-win32-debug+t+e Expired
209 MB
sha256:7c7b638759f14a7050100177d29305d2b80cab7706bb22c48e4348665d249d8f
Generals-win32-profile+t+e Expired
89.9 MB
sha256:72284f91cb8b0d208c755cfadb4f50e3b9099f3e5be1df610f4752519ba2925e
GeneralsMD-vc6+t+e Expired
17.2 MB
sha256:de6edf5af9e551364fa58acfebe6c04976196885504665af6113f8051cce378c
GeneralsMD-vc6-debug+t+e Expired
54.4 MB
sha256:58e7dee0994ab6c759e4f7eeecb37bdc693a64c4c62cae08f793675fc02bc586
GeneralsMD-vc6-profile+t+e Expired
17.3 MB
sha256:7bf734363a539cf42d6f04763a4ca19a93b5ffe96aa8fc8d9af18d3e9152fcc0
GeneralsMD-vc6-releaselog+t+e Expired
30.5 MB
sha256:4a1ca7d8d6aaf3799450563eebaa764f35b5444d14398d41413311598206a60a
GeneralsMD-win32+t+e Expired
95.3 MB
sha256:201b7d7f8f9d7c87db41f536ac654a33f9f56c73d26f1f48038f6550b0146c7d
GeneralsMD-win32-debug+t+e Expired
220 MB
sha256:1f3edf8d99175e3267a1377d9cf961d4527955a63d2a724f52b44f798b6c5c86
GeneralsMD-win32-profile+t+e Expired
95.6 MB
sha256:8ad6e375e3db036a079a834b84f278b1a8fbc5108222f0dd05ed276af31074ab
Replay-Debug-Log-vc6-releaselog+t+e Expired
2.8 MB
sha256:6fea4f6d363f607385166b5ded16994490aab54be26f04f791c4c533c8a4b465