Skip to content

refactor(network): Convert some if-else chains to switch statements #3428

refactor(network): Convert some if-else chains to switch statements

refactor(network): Convert some if-else chains to switch statements #3428

Triggered via pull request October 10, 2025 17:56
Status Success
Total duration 12m 4s
Artifacts 14

ci.yml

on: pull_request
Detect File Changes
7s
Detect File Changes
Matrix: build-generalsmd-vc6
Matrix: build-generals
Matrix: build-generalsmd-win32
Matrix: replaycheck-generalsmd
Fit to window
Zoom out
Zoom in

Annotations

130 warnings
Build Generals / vc6-debug+t+e: Core/Tools/Autorun/GameText.cpp#L817
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6-debug+t+e: Core/Tools/Autorun/GameText.cpp#L1117
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6-debug+t+e: Core/Tools/Autorun/GameText.cpp#L1041
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6-debug+t+e: Core/Tools/Autorun/GameText.cpp#L817
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6-debug+t+e: Core/Tools/Autorun/GameText.cpp#L1117
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6-debug+t+e: Core/Tools/Autorun/GameText.cpp#L1041
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6-debug+t+e: Core/Tools/Autorun/GameText.cpp#L817
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6-debug+t+e: Core/Tools/W3DView/GraphicView.cpp#L458
'unsigned int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6-debug+t+e: Core/Tools/W3DView/GraphicView.cpp#L456
'float' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6-debug+t+e: Core/Libraries/Source/WWVegas/WWDownload/registry.cpp#L25
'WIN32_LEAN_AND_MEAN' : macro redefinition
Build GeneralsMD / vc6-debug+t+e: Core/Tools/Autorun/GameText.cpp#L817
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-debug+t+e: Core/Tools/Autorun/GameText.cpp#L1117
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-debug+t+e: Core/Tools/Autorun/GameText.cpp#L1041
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-debug+t+e: Core/Tools/Autorun/GameText.cpp#L817
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-debug+t+e: Core/Tools/Autorun/GameText.cpp#L1117
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-debug+t+e: Core/Tools/Autorun/GameText.cpp#L1041
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-debug+t+e: Core/Tools/Autorun/GameText.cpp#L817
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-debug+t+e: Core/Tools/W3DView/GraphicView.cpp#L458
'unsigned int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-debug+t+e: Core/Tools/W3DView/GraphicView.cpp#L456
'float' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-debug+t+e: Core/Libraries/Source/WWVegas/WWDownload/registry.cpp#L25
'WIN32_LEAN_AND_MEAN' : macro redefinition
Build Generals / vc6+t+e: Core/Tools/Autorun/GameText.cpp#L817
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6+t+e: Core/Tools/Autorun/GameText.cpp#L1117
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6+t+e: Core/Tools/Autorun/GameText.cpp#L1041
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6+t+e: Core/Tools/Autorun/GameText.cpp#L817
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6+t+e: Core/Tools/Autorun/GameText.cpp#L1117
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6+t+e: Core/Tools/Autorun/GameText.cpp#L1041
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6+t+e: Core/Tools/Autorun/GameText.cpp#L817
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6+t+e: Core/Tools/W3DView/GraphicView.cpp#L458
'unsigned int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6+t+e: Core/Tools/W3DView/GraphicView.cpp#L456
'float' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6+t+e: Core/Libraries/Source/WWVegas/WWDownload/registry.cpp#L25
'WIN32_LEAN_AND_MEAN' : macro redefinition
Build GeneralsMD / vc6+t+e: Core/Tools/Autorun/GameText.cpp#L817
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6+t+e: Core/Tools/Autorun/GameText.cpp#L1117
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6+t+e: Core/Tools/Autorun/GameText.cpp#L1041
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6+t+e: Core/Tools/Autorun/GameText.cpp#L817
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6+t+e: Core/Tools/Autorun/GameText.cpp#L1117
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6+t+e: Core/Tools/Autorun/GameText.cpp#L1041
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6+t+e: Core/Tools/Autorun/GameText.cpp#L817
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6+t+e: Core/Tools/W3DView/GraphicView.cpp#L458
'unsigned int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6+t+e: Core/Tools/W3DView/GraphicView.cpp#L456
'float' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6+t+e: Core/Libraries/Source/WWVegas/WWDownload/registry.cpp#L25
'WIN32_LEAN_AND_MEAN' : macro redefinition
Build Generals / vc6-profile+t+e: Core/Tools/Autorun/GameText.cpp#L817
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6-profile+t+e: Core/Tools/Autorun/GameText.cpp#L1117
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6-profile+t+e: Core/Tools/Autorun/GameText.cpp#L1041
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6-profile+t+e: Core/Tools/Autorun/GameText.cpp#L817
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6-profile+t+e: Core/Tools/Autorun/GameText.cpp#L1117
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6-profile+t+e: Core/Tools/Autorun/GameText.cpp#L1041
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6-profile+t+e: Core/Tools/Autorun/GameText.cpp#L817
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6-profile+t+e: Core/Tools/W3DView/GraphicView.cpp#L458
'unsigned int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6-profile+t+e: Core/Tools/W3DView/GraphicView.cpp#L456
'float' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6-profile+t+e: Core/Libraries/Source/WWVegas/WWDownload/registry.cpp#L25
'WIN32_LEAN_AND_MEAN' : macro redefinition
Build GeneralsMD / vc6-profile+t+e: Core/Tools/Autorun/GameText.cpp#L817
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-profile+t+e: Core/Tools/Autorun/GameText.cpp#L1117
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-profile+t+e: Core/Tools/Autorun/GameText.cpp#L1041
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-profile+t+e: Core/Tools/Autorun/GameText.cpp#L817
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-profile+t+e: Core/Tools/Autorun/GameText.cpp#L1117
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-profile+t+e: Core/Tools/Autorun/GameText.cpp#L1041
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-profile+t+e: Core/Tools/Autorun/GameText.cpp#L817
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-profile+t+e: Core/Tools/W3DView/GraphicView.cpp#L458
'unsigned int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-profile+t+e: Core/Tools/W3DView/GraphicView.cpp#L456
'float' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-releaselog+t+e: Core/Tools/Autorun/GameText.cpp#L817
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-releaselog+t+e: Core/Tools/Autorun/GameText.cpp#L1117
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-releaselog+t+e: Core/Tools/Autorun/GameText.cpp#L1041
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-releaselog+t+e: Core/Tools/Autorun/GameText.cpp#L817
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-releaselog+t+e: Core/Tools/Autorun/GameText.cpp#L1117
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-releaselog+t+e: Core/Tools/Autorun/GameText.cpp#L1041
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-releaselog+t+e: Core/Tools/Autorun/GameText.cpp#L817
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-releaselog+t+e: Core/Tools/W3DView/GraphicView.cpp#L458
'unsigned int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-releaselog+t+e: Core/Tools/W3DView/GraphicView.cpp#L456
'float' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / win32-debug+t+e: Core/Libraries/Source/WWVegas/WWDownload/registry.cpp#L25
'WIN32_LEAN_AND_MEAN': macro redefinition
Build Generals / win32-debug+t+e: Core/Libraries/Source/WWVegas/WWDownload/FTP.CPP#L668
'=': conversion from 'time_t' to 'int', possible loss of data
Build Generals / win32-debug+t+e: Generals/Code/Libraries/Source/WWVegas/WW3D2/ww3d.cpp#L168
operator '/': deprecated between enumerations and floating-point types
Build Generals / win32-debug+t+e
operands are different enum types 'SBServerListState' and 'SBState'; use an explicit cast to silence this warning
Build Generals / win32-debug+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build Generals / win32-debug+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build GeneralsMD / win32-debug+t+e: Core/Libraries/Source/WWVegas/WWDownload/FTP.CPP#L668
'=': conversion from 'time_t' to 'int', possible loss of data
Build GeneralsMD / win32-debug+t+e: GeneralsMD/Code/Libraries/Source/WWVegas/WW3D2/ww3d.cpp#L169
operator '/': deprecated between enumerations and floating-point types
Build GeneralsMD / win32-debug+t+e
operands are different enum types 'SBServerListState' and 'SBState'; use an explicit cast to silence this warning
Build GeneralsMD / win32-debug+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build GeneralsMD / win32-debug+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build Generals / win32-profile+t+e: Core/Libraries/Source/WWVegas/WWDownload/FTP.CPP#L668
'=': conversion from 'time_t' to 'int', possible loss of data
Build Generals / win32-profile+t+e: Generals/Code/Libraries/Source/WWVegas/WW3D2/ww3d.cpp#L168
operator '/': deprecated between enumerations and floating-point types
Build Generals / win32-profile+t+e
operands are different enum types 'SBServerListState' and 'SBState'; use an explicit cast to silence this warning
Build Generals / win32-profile+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build Generals / win32-profile+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build GeneralsMD / win32-profile+t+e: Core/Libraries/Source/WWVegas/WWDownload/FTP.CPP#L668
'=': conversion from 'time_t' to 'int', possible loss of data
Build GeneralsMD / win32-profile+t+e: GeneralsMD/Code/Libraries/Source/WWVegas/WW3D2/ww3d.cpp#L169
operator '/': deprecated between enumerations and floating-point types
Build GeneralsMD / win32-profile+t+e
operands are different enum types 'SBServerListState' and 'SBState'; use an explicit cast to silence this warning
Build GeneralsMD / win32-profile+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build GeneralsMD / win32-profile+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build Generals / win32+t+e: Core/Libraries/Source/WWVegas/WWDownload/registry.cpp#L25
'WIN32_LEAN_AND_MEAN': macro redefinition
Build Generals / win32+t+e: Core/Libraries/Source/WWVegas/WWDownload/FTP.CPP#L668
'=': conversion from 'time_t' to 'int', possible loss of data
Build Generals / win32+t+e: Generals/Code/Libraries/Source/WWVegas/WW3D2/ww3d.cpp#L168
operator '/': deprecated between enumerations and floating-point types
Build Generals / win32+t+e
operands are different enum types 'SBServerListState' and 'SBState'; use an explicit cast to silence this warning
Build Generals / win32+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build Generals / win32+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build GeneralsMD / win32+t+e: Core/Libraries/Source/WWVegas/WWDownload/registry.cpp#L25
'WIN32_LEAN_AND_MEAN': macro redefinition
Build GeneralsMD / win32+t+e: Core/Libraries/Source/WWVegas/WWDownload/FTP.CPP#L668
'=': conversion from 'time_t' to 'int', possible loss of data
Build GeneralsMD / win32+t+e: GeneralsMD/Code/Libraries/Source/WWVegas/WW3D2/ww3d.cpp#L169
operator '/': deprecated between enumerations and floating-point types
Build GeneralsMD / win32+t+e
operands are different enum types 'SBServerListState' and 'SBState'; use an explicit cast to silence this warning
Build GeneralsMD / win32+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build GeneralsMD / win32+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning

Artifacts

Produced during runtime
Name Size Digest
Generals-vc6+t+e Expired
15.9 MB
sha256:0e10e0c40f3b18b023a2d3a3f596adad6a3bc07c60eff36be7f2a4e4635ca5ab
Generals-vc6-debug+t+e Expired
51.1 MB
sha256:664f6307d331279e8aa9707212d1911a49306d589df619804211b26b3a9a0dbe
Generals-vc6-profile+t+e Expired
15.9 MB
sha256:49d6834e086193a3fe3bc51c8bf6cf46e246d2a1727ac09bbb36067b1dab89e3
Generals-win32+t+e Expired
90.3 MB
sha256:8c1f8d4035ed54ec666540eaa8acba91dcc0fed9b98cf652e0eb6437be52f4d0
Generals-win32-debug+t+e Expired
210 MB
sha256:531ecd9e17fbb2ecf3bab16afd063e265b971241dfa886c39a15eecc2b21fa85
Generals-win32-profile+t+e Expired
90.2 MB
sha256:d4455f55dd69b1e8115a2c77aa9683241e2c1c4b9f887cb5d63d82d75c831d0d
GeneralsMD-vc6+t+e Expired
17.2 MB
sha256:18ca6f3fa4458cd5d187e188b9ac54aed849ceb11de73961ecbade4680d7a9bc
GeneralsMD-vc6-debug+t+e Expired
54.3 MB
sha256:50ec042e5a88b9b64635ae9400082824f58b570a16eef777227557e231f18be6
GeneralsMD-vc6-profile+t+e Expired
17.3 MB
sha256:f7d040b8a2ee99726e6f3456c2d7b4ff5195d6fa0920395a775d2c42cb1da309
GeneralsMD-vc6-releaselog+t+e Expired
30.5 MB
sha256:9b52de956a8f7bbaea7b0768d2dc411bd2f761f828cee4c123feb6e6983fbbdf
GeneralsMD-win32+t+e Expired
95.6 MB
sha256:12715c6e101c5562c618931d4fcfafe798f5865f67b4fa22cdb62f2301d6d5ed
GeneralsMD-win32-debug+t+e Expired
222 MB
sha256:d6bedc77ad34825474a0d4374a4e9b39f2cdc353cea859c2a1e35ff975356bbf
GeneralsMD-win32-profile+t+e Expired
96.5 MB
sha256:84202d68e84bc08549aa92d4100cd72a725f5f36f60380c638a4447228015acf
Replay-Debug-Log-vc6-releaselog+t+e Expired
2.8 MB
sha256:df395f670ea9671fc7743124e3bf86fb89e903168f341da91de102f335bb49bb