Skip to content

refactor: Simplify some if-else condition chains #3431

refactor: Simplify some if-else condition chains

refactor: Simplify some if-else condition chains #3431

Triggered via pull request October 10, 2025 18:05
Status Success
Total duration 15m 20s
Artifacts 14

ci.yml

on: pull_request
Detect File Changes
8s
Detect File Changes
Matrix: build-generalsmd-vc6
Matrix: build-generals
Matrix: build-generalsmd-win32
Matrix: replaycheck-generalsmd
Fit to window
Zoom out
Zoom in

Annotations

130 warnings
Build Generals / vc6+t+e: Core/Tools/Autorun/GameText.cpp#L817
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6+t+e: Core/Tools/Autorun/GameText.cpp#L1117
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6+t+e: Core/Tools/Autorun/GameText.cpp#L1041
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6+t+e: Core/Tools/Autorun/GameText.cpp#L817
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6+t+e: Core/Tools/Autorun/GameText.cpp#L1117
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6+t+e: Core/Tools/Autorun/GameText.cpp#L1041
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6+t+e: Core/Tools/Autorun/GameText.cpp#L817
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6+t+e: Core/Tools/W3DView/GraphicView.cpp#L458
'unsigned int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6+t+e: Core/Tools/W3DView/GraphicView.cpp#L456
'float' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6+t+e: Core/Libraries/Source/WWVegas/WWDownload/registry.cpp#L25
'WIN32_LEAN_AND_MEAN' : macro redefinition
Build GeneralsMD / vc6-debug+t+e: Core/Tools/Autorun/GameText.cpp#L817
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-debug+t+e: Core/Tools/Autorun/GameText.cpp#L1117
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-debug+t+e: Core/Tools/Autorun/GameText.cpp#L1041
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-debug+t+e: Core/Tools/Autorun/GameText.cpp#L817
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-debug+t+e: Core/Tools/Autorun/GameText.cpp#L1117
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-debug+t+e: Core/Tools/Autorun/GameText.cpp#L1041
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-debug+t+e: Core/Tools/Autorun/GameText.cpp#L817
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-debug+t+e: Core/Tools/W3DView/GraphicView.cpp#L458
'unsigned int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-debug+t+e: Core/Tools/W3DView/GraphicView.cpp#L456
'float' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-debug+t+e: Core/Libraries/Source/WWVegas/WWDownload/registry.cpp#L25
'WIN32_LEAN_AND_MEAN' : macro redefinition
Build GeneralsMD / vc6-releaselog+t+e: Core/Tools/Autorun/GameText.cpp#L817
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-releaselog+t+e: Core/Tools/Autorun/GameText.cpp#L1117
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-releaselog+t+e: Core/Tools/Autorun/GameText.cpp#L1041
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-releaselog+t+e: Core/Tools/Autorun/GameText.cpp#L817
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-releaselog+t+e: Core/Tools/Autorun/GameText.cpp#L1117
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-releaselog+t+e: Core/Tools/Autorun/GameText.cpp#L1041
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-releaselog+t+e: Core/Tools/Autorun/GameText.cpp#L817
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-releaselog+t+e: Core/Tools/W3DView/GraphicView.cpp#L458
'unsigned int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-releaselog+t+e: Core/Tools/W3DView/GraphicView.cpp#L456
'float' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6+t+e: Core/Tools/Autorun/GameText.cpp#L817
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6+t+e: Core/Tools/Autorun/GameText.cpp#L1117
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6+t+e: Core/Tools/Autorun/GameText.cpp#L1041
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6+t+e: Core/Tools/Autorun/GameText.cpp#L817
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6+t+e: Core/Tools/Autorun/GameText.cpp#L1117
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6+t+e: Core/Tools/Autorun/GameText.cpp#L1041
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6+t+e: Core/Tools/Autorun/GameText.cpp#L817
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6+t+e: Core/Tools/W3DView/GraphicView.cpp#L458
'unsigned int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6+t+e: Core/Tools/W3DView/GraphicView.cpp#L456
'float' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6+t+e: Core/Libraries/Source/WWVegas/WWDownload/registry.cpp#L25
'WIN32_LEAN_AND_MEAN' : macro redefinition
Build GeneralsMD / vc6-profile+t+e: Core/Tools/Autorun/GameText.cpp#L817
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-profile+t+e: Core/Tools/Autorun/GameText.cpp#L1117
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-profile+t+e: Core/Tools/Autorun/GameText.cpp#L1041
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-profile+t+e: Core/Tools/Autorun/GameText.cpp#L817
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-profile+t+e: Core/Tools/Autorun/GameText.cpp#L1117
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-profile+t+e: Core/Tools/Autorun/GameText.cpp#L1041
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-profile+t+e: Core/Tools/Autorun/GameText.cpp#L817
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-profile+t+e: Core/Tools/W3DView/GraphicView.cpp#L458
'unsigned int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-profile+t+e: Core/Tools/W3DView/GraphicView.cpp#L456
'float' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6-debug+t+e: Core/Tools/Autorun/GameText.cpp#L817
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6-debug+t+e: Core/Tools/Autorun/GameText.cpp#L1117
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6-debug+t+e: Core/Tools/Autorun/GameText.cpp#L1041
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6-debug+t+e: Core/Tools/Autorun/GameText.cpp#L817
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6-debug+t+e: Core/Tools/Autorun/GameText.cpp#L1117
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6-debug+t+e: Core/Tools/Autorun/GameText.cpp#L1041
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6-debug+t+e: Core/Tools/Autorun/GameText.cpp#L817
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6-debug+t+e: Core/Tools/W3DView/GraphicView.cpp#L458
'unsigned int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6-debug+t+e: Core/Tools/W3DView/GraphicView.cpp#L456
'float' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6-debug+t+e: Core/Libraries/Source/WWVegas/WWDownload/registry.cpp#L25
'WIN32_LEAN_AND_MEAN' : macro redefinition
Build Generals / vc6-profile+t+e: Core/Tools/Autorun/GameText.cpp#L817
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6-profile+t+e: Core/Tools/Autorun/GameText.cpp#L1117
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6-profile+t+e: Core/Tools/Autorun/GameText.cpp#L1041
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6-profile+t+e: Core/Tools/Autorun/GameText.cpp#L817
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6-profile+t+e: Core/Tools/Autorun/GameText.cpp#L1117
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6-profile+t+e: Core/Tools/Autorun/GameText.cpp#L1041
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6-profile+t+e: Core/Tools/Autorun/GameText.cpp#L817
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6-profile+t+e: Core/Tools/W3DView/GraphicView.cpp#L458
'unsigned int' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6-profile+t+e: Core/Tools/W3DView/GraphicView.cpp#L456
'float' : forcing value to bool 'true' or 'false' (performance warning)
Build Generals / vc6-profile+t+e: Core/Libraries/Source/WWVegas/WWDownload/registry.cpp#L25
'WIN32_LEAN_AND_MEAN' : macro redefinition
Build GeneralsMD / win32-debug+t+e: Core/Libraries/Source/WWVegas/WWDownload/FTP.CPP#L668
'=': conversion from 'time_t' to 'int', possible loss of data
Build GeneralsMD / win32-debug+t+e: GeneralsMD/Code/Libraries/Source/WWVegas/WW3D2/ww3d.cpp#L169
operator '/': deprecated between enumerations and floating-point types
Build GeneralsMD / win32-debug+t+e
operands are different enum types 'SBServerListState' and 'SBState'; use an explicit cast to silence this warning
Build GeneralsMD / win32-debug+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build GeneralsMD / win32-debug+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build Generals / win32+t+e: Core/Libraries/Source/WWVegas/WWDownload/registry.cpp#L25
'WIN32_LEAN_AND_MEAN': macro redefinition
Build Generals / win32+t+e: Core/Libraries/Source/WWVegas/WWDownload/FTP.CPP#L668
'=': conversion from 'time_t' to 'int', possible loss of data
Build Generals / win32+t+e: Generals/Code/Libraries/Source/WWVegas/WW3D2/ww3d.cpp#L168
operator '/': deprecated between enumerations and floating-point types
Build Generals / win32+t+e
operands are different enum types 'SBServerListState' and 'SBState'; use an explicit cast to silence this warning
Build Generals / win32+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build Generals / win32+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build GeneralsMD / win32-profile+t+e: Core/Libraries/Source/WWVegas/WWDownload/FTP.CPP#L668
'=': conversion from 'time_t' to 'int', possible loss of data
Build GeneralsMD / win32-profile+t+e: GeneralsMD/Code/Libraries/Source/WWVegas/WW3D2/ww3d.cpp#L169
operator '/': deprecated between enumerations and floating-point types
Build GeneralsMD / win32-profile+t+e
operands are different enum types 'SBServerListState' and 'SBState'; use an explicit cast to silence this warning
Build GeneralsMD / win32-profile+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build GeneralsMD / win32-profile+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build GeneralsMD / win32+t+e: Core/Libraries/Source/WWVegas/WWDownload/registry.cpp#L25
'WIN32_LEAN_AND_MEAN': macro redefinition
Build GeneralsMD / win32+t+e: Core/Libraries/Source/WWVegas/WWDownload/FTP.CPP#L668
'=': conversion from 'time_t' to 'int', possible loss of data
Build GeneralsMD / win32+t+e: GeneralsMD/Code/Libraries/Source/WWVegas/WW3D2/ww3d.cpp#L169
operator '/': deprecated between enumerations and floating-point types
Build GeneralsMD / win32+t+e
operands are different enum types 'SBServerListState' and 'SBState'; use an explicit cast to silence this warning
Build GeneralsMD / win32+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build GeneralsMD / win32+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build Generals / win32-debug+t+e: Core/Libraries/Source/WWVegas/WWDownload/registry.cpp#L25
'WIN32_LEAN_AND_MEAN': macro redefinition
Build Generals / win32-debug+t+e: Core/Libraries/Source/WWVegas/WWDownload/FTP.CPP#L668
'=': conversion from 'time_t' to 'int', possible loss of data
Build Generals / win32-debug+t+e: Generals/Code/Libraries/Source/WWVegas/WW3D2/ww3d.cpp#L168
operator '/': deprecated between enumerations and floating-point types
Build Generals / win32-debug+t+e
operands are different enum types 'SBServerListState' and 'SBState'; use an explicit cast to silence this warning
Build Generals / win32-debug+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build Generals / win32-debug+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build Generals / win32-profile+t+e: Core/Libraries/Source/WWVegas/WWDownload/FTP.CPP#L668
'=': conversion from 'time_t' to 'int', possible loss of data
Build Generals / win32-profile+t+e: Generals/Code/Libraries/Source/WWVegas/WW3D2/ww3d.cpp#L168
operator '/': deprecated between enumerations and floating-point types
Build Generals / win32-profile+t+e
operands are different enum types 'SBServerListState' and 'SBState'; use an explicit cast to silence this warning
Build Generals / win32-profile+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build Generals / win32-profile+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning

Artifacts

Produced during runtime
Name Size Digest
Generals-vc6+t+e Expired
15.9 MB
sha256:c8a57be8ad07c69b594feeeaeff3312393551e206f38c336bd4b987c149a503c
Generals-vc6-debug+t+e Expired
51.1 MB
sha256:ed8d118429a26037fc34b6e5ab7a89c755e12ef816cc5cc29e165f8da37e6ebd
Generals-vc6-profile+t+e Expired
15.9 MB
sha256:dfcd17379b99a8d7f1dc12a5d51d6e1a595031a2fe1ff43840250f70510d98f5
Generals-win32+t+e Expired
90.5 MB
sha256:63491dafcdc6eff82a79436ed7691e630d60b43d23c9fe67636dd97cd082b08c
Generals-win32-debug+t+e Expired
210 MB
sha256:5d9a3cfdf6e4ccb3cb2c6d09f8bd509b82982927ee2e9926a40d473ce8d6a6b9
Generals-win32-profile+t+e Expired
90.3 MB
sha256:a25159cb484933bf48e3bbc18d30633b1391f00cd0aa0f411d0531637461e15b
GeneralsMD-vc6+t+e Expired
17.2 MB
sha256:f08dcf9ed753ce6e20d284483017e9a4bb5e5ad5ed3fa7ee6c969a54ae79f153
GeneralsMD-vc6-debug+t+e Expired
54.3 MB
sha256:69d885a787bd6dad6898471717a3cd7bb4608a65c063ba23194c3bf1fc05e017
GeneralsMD-vc6-profile+t+e Expired
17.3 MB
sha256:09fe4bbfccc32b6ed0a6a74ce56a86e8e40811138ea46f8663af385e3bfedcfe
GeneralsMD-vc6-releaselog+t+e Expired
30.5 MB
sha256:11bceb01b6ed13c055f5a5c2a7075f691bee7431983835afceb87a4140df3d1b
GeneralsMD-win32+t+e Expired
95.9 MB
sha256:ac5e606c873e1115fca8bb74b4cd8888d55b78494ec4e3dccbed7e8d1563e686
GeneralsMD-win32-debug+t+e Expired
222 MB
sha256:0c1561b603bc97eb83530a040c8f66ff6d8b1ed4ddc90b0c9427a886459ed8cf
GeneralsMD-win32-profile+t+e Expired
96.2 MB
sha256:c4d192691b29eaed51c405c6f1af0ae323bb57cdfb3f219a2b6b46ce02183a79
Replay-Debug-Log-vc6-releaselog+t+e Expired
2.8 MB
sha256:b0adb685e02d1a52b1a10b92a7c3fed4fd88d1dc7f38868945df28baaa22e40e