bugfix(controlbar): Show the experience bar for the selected player when observing (#1432)

Author: Stubbjax

Generals/Code/GameEngineDevice/Source/W3DDevice/GameClient/GUI/GUICallbacks/W3DControlBar.cpp

@@ -486,9 +486,17 @@ void W3DCommandBarGridDraw( GameWindow *window, WinInstanceData *instData )
 
 void W3DCommandBarGenExpDraw( GameWindow *window, WinInstanceData *instData )
 {
-	Player *player = ThePlayerList->getLocalPlayer();
-	if(!player->isPlayerActive())
+	Player* player = NULL;
+
+	// TheSuperHackers @bugfix Stubbjax 08/08/2025 Show the experience bar for observers
+	if (TheControlBar->isObserverControlBarOn())
+		player = TheControlBar->getObserverLookAtPlayer();
+	else
+		player = ThePlayerList->getLocalPlayer();
+
+	if (!player)
 		return;
+
 	static const Image *endBar = TheMappedImageCollection->findImageByName("GenExpBarTop1");
 	static const Image *beginBar = TheMappedImageCollection->findImageByName("GenExpBarBottom1");
 	static const Image *centerBar = TheMappedImageCollection->findImageByName("GenExpBar1");

GeneralsMD/Code/GameEngineDevice/Source/W3DDevice/GameClient/GUI/GUICallbacks/W3DControlBar.cpp

@@ -486,9 +486,17 @@ void W3DCommandBarGridDraw( GameWindow *window, WinInstanceData *instData )
 
 void W3DCommandBarGenExpDraw( GameWindow *window, WinInstanceData *instData )
 {
-	Player *player = ThePlayerList->getLocalPlayer();
-	if(!player->isPlayerActive())
+	Player* player = NULL;
+
+	// TheSuperHackers @bugfix Stubbjax 08/08/2025 Show the experience bar for observers
+	if (TheControlBar->isObserverControlBarOn())
+		player = TheControlBar->getObserverLookAtPlayer();
+	else
+		player = ThePlayerList->getLocalPlayer();
+
+	if (!player)
 		return;
+
 	static const Image *endBar = TheMappedImageCollection->findImageByName("GenExpBarTop1");
 	static const Image *beginBar = TheMappedImageCollection->findImageByName("GenExpBarBottom1");
 	static const Image *centerBar = TheMappedImageCollection->findImageByName("GenExpBar1");