Skip to content

Commit 280ce2b

Browse files
committed
Update comments
1 parent 7d18382 commit 280ce2b

File tree

3 files changed

+9
-5
lines changed

3 files changed

+9
-5
lines changed

Core/Libraries/Source/WWVegas/WWLib/DbgHelpGuard.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
// This class temporarily loads and unloads dbghelp.dll from the desired location to prevent
2525
// other code from potentially loading it from an undesired location.
2626
// This helps avoid crashing on boot using recent AMD/ATI drivers, which attempt to load and use
27-
// dbghelp.dll from the game install directory but are unable to do so correctly because
27+
// dbghelp.dll from the game install directory but are unable to do so without crashing because
2828
// the dbghelp.dll that ships with the game is very old and the AMD/ATI code does not handle
2929
// that correctly.
3030

Generals/Code/Libraries/Source/WWVegas/WW3D2/dx8wrapper.cpp

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -314,7 +314,8 @@ bool DX8Wrapper::Init(void * hwnd, bool lite)
314314
*/
315315
WWDEBUG_SAY(("Create Direct3D8"));
316316
{
317-
// TheSuperHackers @bugfix xezon 13/06/2025 Temporarily unload dbghelp.dll and prevent it from loading.
317+
// TheSuperHackers @bugfix xezon 13/06/2025 Front load the system dbghelp.dll
318+
// to prevent the graphics driver from potentially loading the old game dbghelp.dll.
318319
DbgHelpGuard dbgHelpGuard;
319320

320321
D3DInterface = Direct3DCreate8Ptr(D3D_SDK_VERSION); // TODO: handle failure cases...
@@ -566,7 +567,8 @@ bool DX8Wrapper::Create_Device(void)
566567

567568
HRESULT hr;
568569
{
569-
// TheSuperHackers @bugfix xezon 13/06/2025 Temporarily unload dbghelp.dll and prevent it from loading.
570+
// TheSuperHackers @bugfix xezon 13/06/2025 Front load the system dbghelp.dll
571+
// to prevent the graphics driver from potentially loading the old game dbghelp.dll.
570572
DbgHelpGuard dbgHelpGuard;
571573

572574
hr=D3DInterface->CreateDevice

GeneralsMD/Code/Libraries/Source/WWVegas/WW3D2/dx8wrapper.cpp

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -333,7 +333,8 @@ bool DX8Wrapper::Init(void * hwnd, bool lite)
333333
*/
334334
WWDEBUG_SAY(("Create Direct3D8"));
335335
{
336-
// TheSuperHackers @bugfix xezon 13/06/2025 Temporarily unload dbghelp.dll and prevent it from loading.
336+
// TheSuperHackers @bugfix xezon 13/06/2025 Front load the system dbghelp.dll
337+
// to prevent the graphics driver from potentially loading the old game dbghelp.dll.
337338
DbgHelpGuard dbgHelpGuard;
338339

339340
D3DInterface = Direct3DCreate8Ptr(D3D_SDK_VERSION); // TODO: handle failure cases...
@@ -598,7 +599,8 @@ bool DX8Wrapper::Create_Device(void)
598599

599600
HRESULT hr;
600601
{
601-
// TheSuperHackers @bugfix xezon 13/06/2025 Temporarily unload dbghelp.dll and prevent it from loading.
602+
// TheSuperHackers @bugfix xezon 13/06/2025 Front load the system dbghelp.dll
603+
// to prevent the graphics driver from potentially loading the old game dbghelp.dll.
602604
DbgHelpGuard dbgHelpGuard;
603605

604606
hr=D3DInterface->CreateDevice

0 commit comments

Comments
 (0)