Fix lobby game sorting to properly sort CRC mismatches to bottom

bobtista · bobtista · commit 29406c85c408 · 2025-11-12T23:43:12.000-05:00
diff --git a/Core/GameEngine/Source/GameNetwork/GameSpy/LobbyUtils.cpp b/Core/GameEngine/Source/GameNetwork/GameSpy/LobbyUtils.cpp
@@ -474,11 +474,11 @@ struct GameSortStruct
 	bool operator()(GameSpyStagingRoom *g1, GameSpyStagingRoom *g2) const
 	{
 		// sort CRC mismatches to the bottom
-		Bool g1Good = (g1->getExeCRC() != TheGlobalData->m_exeCRC || g1->getIniCRC() != TheGlobalData->m_iniCRC);
-		Bool g2Good = (g1->getExeCRC() != TheGlobalData->m_exeCRC || g1->getIniCRC() != TheGlobalData->m_iniCRC);
-		if ( g1Good ^ g2Good )
+		Bool g1Mismatch = (g1->getExeCRC() != TheGlobalData->m_exeCRC || g1->getIniCRC() != TheGlobalData->m_iniCRC);
+		Bool g2Mismatch = (g2->getExeCRC() != TheGlobalData->m_exeCRC || g2->getIniCRC() != TheGlobalData->m_iniCRC);
+		if ( g1Mismatch ^ g2Mismatch )
 		{
-			return g1Good;
+			return g2Mismatch;
 		}
 
 		// sort games with private ladders to the bottom

Original file line number	Diff line number	Diff line change
`@@ -474,11 +474,11 @@ struct GameSortStruct`
`474`	`474`	`bool operator()(GameSpyStagingRoom g1, GameSpyStagingRoom g2) const`
`475`	`475`	`{`
`476`	`476`	`// sort CRC mismatches to the bottom`
`477`		`- Bool g1Good = (g1->getExeCRC() != TheGlobalData->m_exeCRC \|\| g1->getIniCRC() != TheGlobalData->m_iniCRC);`
`478`		`- Bool g2Good = (g1->getExeCRC() != TheGlobalData->m_exeCRC \|\| g1->getIniCRC() != TheGlobalData->m_iniCRC);`
`479`		`- if ( g1Good ^ g2Good )`
	`477`	`+ Bool g1Mismatch = (g1->getExeCRC() != TheGlobalData->m_exeCRC \|\| g1->getIniCRC() != TheGlobalData->m_iniCRC);`
	`478`	`+ Bool g2Mismatch = (g2->getExeCRC() != TheGlobalData->m_exeCRC \|\| g2->getIniCRC() != TheGlobalData->m_iniCRC);`
	`479`	`+ if ( g1Mismatch ^ g2Mismatch )`
`480`	`480`	`{`
`481`		`- return g1Good;`
	`481`	`+ return g2Mismatch;`
`482`	`482`	`}`
`483`	`483`
`484`	`484`	`// sort games with private ladders to the bottom`