Add conditional compilation for move vs swap and clear source vector

Author: bobtista

Generals/Code/GameEngine/Include/GameLogic/AI.h

@@ -539,15 +539,27 @@ class AICommandInterface
 	inline void aiFollowExitProductionPath( std::vector<Coord3D>* path, Object *ignoreObject, CommandSourceType cmdSource )
 	{
 		AICommandParms parms(AICMD_FOLLOW_EXITPRODUCTION_PATH, cmdSource);
+#if __cplusplus >= 201103L
+		parms.m_coords = std::move(*path);
+#else
+		// TheSuperHackers @performance bobtista 23/11/2025 Use swap to emulate move semantics for VC6 compatibility
 		parms.m_coords.swap(*path);
+		path->clear();
+#endif
 		parms.m_obj = ignoreObject;
 		aiDoCommand(&parms);
 	}
 
 	inline void aiFollowPath( std::vector<Coord3D>* path, Object *ignoreObject, CommandSourceType cmdSource )
 	{
 		AICommandParms parms(AICMD_FOLLOW_PATH, cmdSource);
+#if __cplusplus >= 201103L
+		parms.m_coords = std::move(*path);
+#else
+		// TheSuperHackers @performance bobtista 23/11/2025 Use swap to emulate move semantics for VC6 compatibility
 		parms.m_coords.swap(*path);
+		path->clear();
+#endif
 		parms.m_obj = ignoreObject;
 		aiDoCommand(&parms);
 	}

Generals/Code/GameEngine/Source/GameLogic/AI/AIStates.cpp

@@ -818,7 +818,14 @@ void AIStateMachine::loadPostProcess( void )
  */
 void AIStateMachine::setGoalPath( std::vector<Coord3D>* path )
 {
+#if __cplusplus >= 201103L
+	m_goalPath = std::move(*path);
+#else
+	// TheSuperHackers @performance bobtista 23/11/2025 Use swap to emulate move semantics for VC6 compatibility
+	// Swap transfers ownership without copying. Clear source to make intent explicit.
 	m_goalPath.swap(*path);
+	path->clear();
+#endif
 }
 
 #ifdef STATE_MACHINE_DEBUG

GeneralsMD/Code/GameEngine/Include/GameLogic/AI.h

@@ -553,15 +553,27 @@ class AICommandInterface
 	inline void aiFollowExitProductionPath( std::vector<Coord3D>* path, Object *ignoreObject, CommandSourceType cmdSource )
 	{
 		AICommandParms parms(AICMD_FOLLOW_EXITPRODUCTION_PATH, cmdSource);
+#if __cplusplus >= 201103L
+		parms.m_coords = std::move(*path);
+#else
+		// TheSuperHackers @performance bobtista 23/11/2025 Use swap to emulate move semantics for VC6 compatibility
 		parms.m_coords.swap(*path);
+		path->clear();
+#endif
 		parms.m_obj = ignoreObject;
 		aiDoCommand(&parms);
 	}
 
 	inline void aiFollowPath( std::vector<Coord3D>* path, Object *ignoreObject, CommandSourceType cmdSource )
 	{
 		AICommandParms parms(AICMD_FOLLOW_PATH, cmdSource);
+#if __cplusplus >= 201103L
+		parms.m_coords = std::move(*path);
+#else
+		// TheSuperHackers @performance bobtista 23/11/2025 Use swap to emulate move semantics for VC6 compatibility
 		parms.m_coords.swap(*path);
+		path->clear();
+#endif
 		parms.m_obj = ignoreObject;
 		aiDoCommand(&parms);
 	}

GeneralsMD/Code/GameEngine/Source/GameLogic/AI/AIStates.cpp

@@ -823,7 +823,14 @@ void AIStateMachine::loadPostProcess( void )
  */
 void AIStateMachine::setGoalPath( std::vector<Coord3D>* path )
 {
+#if __cplusplus >= 201103L
+	m_goalPath = std::move(*path);
+#else
+	// TheSuperHackers @performance bobtista 23/11/2025 Use swap to emulate move semantics for VC6 compatibility
+	// Swap transfers ownership without copying. Clear source to make intent explicit.
 	m_goalPath.swap(*path);
+	path->clear();
+#endif
 }
 
 #ifdef STATE_MACHINE_DEBUG