refactor: convert return NULL to return nullptr

fix: change nullptr to 0 for unsigned return type in GetLine

fix: change nullptr to appropriate values for non-pointer return types

fix: change false to nullptr for Path* return types in AIPathfind

fix: change nullptr to false for Bool return type in pathDestination

fix: correct nullptr to FALSE in Bool isPatchShadowed function

Author: bobtista

Core/GameEngine/Include/Common/AudioEventInfo.h

@@ -123,8 +123,8 @@ struct AudioEventInfo : public MemoryPoolObject
 
   // DynamicAudioEventInfo interfacing functions
   virtual Bool isLevelSpecific() const { return false; } ///< If true, this sound is only defined on the current level and can be deleted when that level ends
-  virtual DynamicAudioEventInfo * getDynamicAudioEventInfo() { return NULL; }  ///< If this object is REALLY a DynamicAudioEventInfo, return a pointer to the derived class
-  virtual const DynamicAudioEventInfo * getDynamicAudioEventInfo() const { return NULL; } ///< If this object is REALLY a DynamicAudioEventInfo, return a pointer to the derived class
+  virtual DynamicAudioEventInfo * getDynamicAudioEventInfo() { return nullptr; }  ///< If this object is REALLY a DynamicAudioEventInfo, return a pointer to the derived class
+  virtual const DynamicAudioEventInfo * getDynamicAudioEventInfo() const { return nullptr; } ///< If this object is REALLY a DynamicAudioEventInfo, return a pointer to the derived class
 
   /// Is this a permenant sound? That is, if I start this sound up, will it ever end
   /// "on its own" or only if I explicitly kill it?

Core/GameEngine/Include/Common/GameAudio.h

@@ -395,7 +395,7 @@ class AudioManagerDummy : public AudioManager
 	virtual AsciiString getMusicTrackName() const { return ""; }
 	virtual void openDevice() {}
 	virtual void closeDevice() {}
-	virtual void* getDevice() { return NULL; }
+	virtual void* getDevice() { return nullptr; }
 	virtual void notifyOfAudioCompletion(UnsignedInt audioCompleted, UnsignedInt flags) {}
 	virtual UnsignedInt getProviderCount(void) const { return 0; };
 	virtual AsciiString getProviderName(UnsignedInt providerNum) const { return ""; }
@@ -416,7 +416,7 @@ class AudioManagerDummy : public AudioManager
 	virtual void removePlayingAudio(AsciiString eventName) {}
 	virtual void removeAllDisabledAudio() {}
 	virtual Bool has3DSensitiveStreamsPlaying(void) const { return false; }
-	virtual void* getHandleForBink(void) { return NULL; }
+	virtual void* getHandleForBink(void) { return nullptr; }
 	virtual void releaseHandleForBink(void) {}
 	virtual void friend_forcePlayAudioEventRTS(const AudioEventRTS* eventToPlay) {}
 	virtual void setPreferredProvider(AsciiString providerNdx) {}

Core/GameEngine/Include/Common/StreamingArchiveFile.h

@@ -99,7 +99,7 @@ class StreamingArchiveFile : public RAMFile
 		virtual Bool	openFromArchive(File *archiveFile, const AsciiString& filename, Int offset, Int size); ///< copy file data from the given file at the given offset for the given size.
 		virtual Bool	copyDataToFile(File *localFile) { DEBUG_CRASH(("Are you sure you meant to copyDataToFile on a streaming file?")); return FALSE; }
 
-		virtual char* readEntireAndClose() { DEBUG_CRASH(("Are you sure you meant to readEntireAndClose on a streaming file?")); return NULL; }
+		virtual char* readEntireAndClose() { DEBUG_CRASH(("Are you sure you meant to readEntireAndClose on a streaming file?")); return nullptr; }
 		virtual File* convertToRAMFile() { DEBUG_CRASH(("Are you sure you meant to readEntireAndClose on a streaming file?")); return this; }
 };
 

Core/GameEngine/Include/GameClient/TerrainVisual.h

@@ -285,8 +285,8 @@ class TerrainVisual : public Snapshot,
   virtual void updateSeismicSimulations( void ) = 0; /// walk the SeismicSimulationList and, well, do it.
   virtual void addSeismicSimulation( const SeismicSimulationNode& sim ) = 0;
 #endif
-  virtual WorldHeightMap* getLogicHeightMap( void ) {return NULL;};
-  virtual WorldHeightMap* getClientHeightMap( void ) {return NULL;};
+  virtual WorldHeightMap* getLogicHeightMap( void ) {return nullptr;};
+  virtual WorldHeightMap* getClientHeightMap( void ) {return nullptr;};
   ////////////////////////////////////////////////////
   ////////////////////////////////////////////////////
   ////////////////////////////////////////////////////

Core/GameEngine/Source/Common/System/RAMFile.cpp

@@ -164,7 +164,7 @@ Bool RAMFile::open( File *file )
 	//USE_PERF_TIMER(RAMFile)
 	if ( file == nullptr )
 	{
-		return NULL;
+		return FALSE;
 	}
 
 	const Int access = file->getAccess();

Core/GameEngine/Source/GameClient/MapUtil.cpp

@@ -1222,7 +1222,7 @@ Image *getMapPreviewImage( AsciiString mapName )
 /*
 	// sanity
 	if( mapName.isEmpty() )
-		return NULL;
+		return nullptr;
 	Region2D uv;
 	mapPreviewImage = TheMappedImageCollection->findImageByName("MapPreview");
 	if(mapPreviewImage)
@@ -1258,15 +1258,15 @@ Image *getMapPreviewImage( AsciiString mapName )
 			if (!file.parse(nullptr)) {
 				DEBUG_ASSERTCRASH(false,("Unable to read MapPreview info."));
 				deleteInstance(mapPreviewImage);
-				return NULL;
+				return nullptr;
 			}
 		}
 		theInputStream.close();
 	}
 	else
 	{
 		deleteInstance(mapPreviewImage);
-		return NULL;
+		return nullptr;
 	}
 
 

Core/GameEngine/Source/GameNetwork/NetMessageStream.cpp

@@ -109,16 +109,16 @@ Bool AddToNetCommandList(Int playerNum, GameMessage *msg, UnsignedInt timestamp)
 static GameMessage * GetCommandMsg(UnsignedInt timestamp, CommandMsg *& CommandHead, CommandMsg *& CommandTail)
 {
 	if (!CommandHead)
-		return NULL;
+		return nullptr;
 
 	if (CommandHead->GetTimestamp() < timestamp)
 	{
 		DEBUG_LOG(("Time is %d, yet message timestamp is %d!", timestamp, CommandHead->GetTimestamp()));
-		return NULL;
+		return nullptr;
 	}
 
 	if (CommandHead->GetTimestamp() != timestamp)
-		return NULL;
+		return nullptr;
 
 	CommandMsg *theMsg = CommandHead;
 
@@ -143,7 +143,7 @@ static GameMessage * GetCommandMsg(UnsignedInt timestamp, CommandMsg *& CommandH
 GameMessage * GetCommandMsg(UnsignedInt timestamp, Int playerNum)
 {
 	if (playerNum < 0 || playerNum >= MAX_SLOTS)
-		return NULL;
+		return nullptr;
 
 	//DEBUG_LOG(("Adding msg to NetCommandList %d", playerNum));
 	return GetCommandMsg(timestamp, CommandHead[playerNum], CommandTail[playerNum]);

Core/GameEngineDevice/Source/W3DDevice/GameClient/W3DTerrainTracks.cpp

@@ -455,7 +455,7 @@ static Real computeTrackSpacing(RenderObjClass *renderObj)
 //=============================================================================
 //TerrainTracksRenderObjClassSystem::bindTrack
 //=============================================================================
-/** Grab a track from the free store. If no free tracks exist, return NULL.
+/** Grab a track from the free store. If no free tracks exist, return nullptr.
 	As long as a track is bound to an object (like a tank) it is ready to accept
 	updates with additional edges.  Once it is unbound, it will expire and return
 	to the free store once all tracks have faded out.

Core/GameEngineDevice/Source/W3DDevice/GameClient/W3DVideoBuffer.cpp

@@ -129,7 +129,7 @@ Bool W3DVideoBuffer::allocate( UnsignedInt width, UnsignedInt height )
 
 	if ( w3dFormat == WW3D_FORMAT_UNKNOWN )
 	{
-		return NULL;
+		return FALSE;
 	}
 
 	m_texture  = MSGNEW("TextureClass") TextureClass ( m_textureWidth, m_textureHeight, w3dFormat, MIP_LEVELS_1 );

Core/GameEngineDevice/Source/W3DDevice/GameClient/Water/W3DWaterTracks.cpp

@@ -482,7 +482,7 @@ Int WaterTracksObj::render(DX8VertexBufferClass	*vertexBuffer, Int batchStart)
 //=============================================================================
 //WaterTracksRenderSystem::bindTrack
 //=============================================================================
-/** Grab a track from the free store. If no free tracks exist, return NULL.
+/** Grab a track from the free store. If no free tracks exist, return nullptr.
 	As long as a track is bound to an object (like a tank) it is ready to accept
 	updates with additional edges.  Once it is unbound, it will expire and return
 	to the free store once all tracks have faded out.