docs(logic): Add info about state of TheGameInfo. Add a todo for a bounds check

Author: stephanmeesters

Generals/Code/GameEngine/Source/GameLogic/System/GameLogic.cpp

@@ -846,7 +846,7 @@ static void populateRandomStartPosition( GameInfo *game )
 			continue;
 
 		Int posIdx = slot->getStartPos();
-		if (posIdx >= 0 || posIdx >= numPlayers)
+		if (posIdx >= 0 || posIdx >= numPlayers) // TheSuperHackers @todo stm 19/12/2025 this is not a proper bounds check
 		{
 			hasStartSpotBeenPicked = TRUE;
 			taken[posIdx] = TRUE;
@@ -1105,6 +1105,7 @@ void GameLogic::startNewGame( Bool saveGame )
 		{
 		  TheGameInfo = TheSkirmishGameInfo;
 		}
+		// TheSuperHackers @info stm 18/12/2025 TheGameInfo is nullptr when you load a savegame of a regular campaign mission
 	}
 
 	checkForDuplicateColors( TheGameInfo );

GeneralsMD/Code/GameEngine/Source/GameLogic/System/GameLogic.cpp

@@ -891,7 +891,7 @@ static void populateRandomStartPosition( GameInfo *game )
 			continue;
 
 		Int posIdx = slot->getStartPos();
-		if (posIdx >= 0 || posIdx >= numPlayers)
+		if (posIdx >= 0 || posIdx >= numPlayers) // TheSuperHackers @todo stm 19/12/2025 this is not a proper bounds check
 		{
 			hasStartSpotBeenPicked = TRUE;
 			taken[posIdx] = TRUE;
@@ -1251,6 +1251,7 @@ void GameLogic::startNewGame( Bool loadingSaveGame )
 		{
 			TheGameInfo = TheChallengeGameInfo;
 		}
+		// TheSuperHackers @info stm 18/12/2025 TheGameInfo is nullptr when you load a savegame of a regular campaign mission
 	}
 
   // On a NEW game, we need to copy the superweapon restrictions from the game info to here