perf(input): Reduce timeGetTime() calls in keyboard input processing

bobtista · bobtista · commit 54e20f57b434 · 2025-12-10T17:11:32.000-05:00
diff --git a/Generals/Code/GameEngine/Source/GameClient/Input/Keyboard.cpp b/Generals/Code/GameEngine/Source/GameClient/Input/Keyboard.cpp
@@ -130,6 +130,9 @@ void Keyboard::updateKeys( void )
 	}
 	while( m_keys[ index++ ].key != KEY_NONE );
 
+	// Get current time once for all key updates
+	UnsignedInt now = 0;
+
 	// update keyboard status array
 	index = 0;
 	while( m_keys[ index ].key != KEY_NONE )
@@ -145,7 +148,9 @@ void Keyboard::updateKeys( void )
 		// Update key down time for new key presses
 		if( BitIsSet( m_keys[ index ].state, KEY_STATE_DOWN ) )
 		{
-			m_keyStatus[ m_keys[ index ].key ].keyDownTimeMsec = timeGetTime();
+			if( !now )
+				now = timeGetTime();
+			m_keyStatus[ m_keys[ index ].key ].keyDownTimeMsec = now;
 		}
 
 		// prevent ALT-TAB from causing a TAB event

Original file line number	Diff line number	Diff line change
`@@ -130,6 +130,9 @@ void Keyboard::updateKeys( void )`
`130`	`130`	`}`
`131`	`131`	`while( m_keys[ index++ ].key != KEY_NONE );`
`132`	`132`
	`133`	`+ // Get current time once for all key updates`
	`134`	`+ UnsignedInt now = 0;`
	`135`	`+`
`133`	`136`	`// update keyboard status array`
`134`	`137`	`index = 0;`
`135`	`138`	`while( m_keys[ index ].key != KEY_NONE )`
`@@ -145,7 +148,9 @@ void Keyboard::updateKeys( void )`
`145`	`148`	`// Update key down time for new key presses`
`146`	`149`	`if( BitIsSet( m_keys[ index ].state, KEY_STATE_DOWN ) )`
`147`	`150`	`{`
`148`		`- m_keyStatus[ m_keys[ index ].key ].keyDownTimeMsec = timeGetTime();`
	`151`	`+ if( !now )`
	`152`	`+ now = timeGetTime();`
	`153`	`+ m_keyStatus[ m_keys[ index ].key ].keyDownTimeMsec = now;`
`149`	`154`	`}`
`150`	`155`
`151`	`156`	`// prevent ALT-TAB from causing a TAB event`