refactor(clang-tidy): re-run readability-container-size-empty fixes

bobtista · bobtista · commit 5a4b4a4f9435 · 2025-12-10T11:15:16.000-05:00
diff --git a/Generals/Code/GameEngineDevice/Source/W3DDevice/GameLogic/W3DTerrainLogic.cpp b/Generals/Code/GameEngineDevice/Source/W3DDevice/GameLogic/W3DTerrainLogic.cpp
@@ -183,7 +183,7 @@ void W3DTerrainLogic::getExtent( Region3D *extent ) const
 
 	// Note - m_boundaries are stored in height map grids wide, so we have to
 	// multiply by the grid width.
-	if (m_boundaries.size() > 0) {
+	if (!m_boundaries.empty()) {
 		extent->hi.x = m_boundaries[m_activeBoundary].x*MAP_XY_FACTOR;
 		extent->hi.y = m_boundaries[m_activeBoundary].y*MAP_XY_FACTOR;
 	} else {
diff --git a/Generals/Code/Tools/WorldBuilder/src/LayersList.cpp b/Generals/Code/Tools/WorldBuilder/src/LayersList.cpp
@@ -826,7 +826,7 @@ void LayersList::OnMergeViewSelection(UINT commandID)
 		mapObject = mapObject->getNext();
 	}
 
-	while (allSelectedObjects.size() > 0) {
+	while (!allSelectedObjects.empty()) {
 		changeMapObjectLayer(allSelectedObjects.top(), layerIt->layerName);
 		allSelectedObjects.pop();
 	}
diff --git a/Generals/Code/Tools/WorldBuilder/src/MeshMoldOptions.cpp b/Generals/Code/Tools/WorldBuilder/src/MeshMoldOptions.cpp
@@ -86,7 +86,7 @@ BOOL MeshMoldOptions::OnInitDialog()
 		FilenameList filenameList;
 		TheFileSystem->getFileListInDirectory(".\\data\\Editor\\Molds\\", "*.w3d", filenameList, FALSE);
 
-		if (filenameList.size() > 0) {
+		if (!filenameList.empty()) {
 			HTREEITEM child = NULL;
 			FilenameList::iterator it = filenameList.begin();
 			do {
diff --git a/Generals/Code/Tools/WorldBuilder/src/SelectMacrotexture.cpp b/Generals/Code/Tools/WorldBuilder/src/SelectMacrotexture.cpp
@@ -78,7 +78,7 @@ BOOL SelectMacrotexture::OnInitDialog()
 		FilenameList filenameList;
 		TheFileSystem->getFileListInDirectory("..\\TestArt\\", "*.tga", filenameList, FALSE);
 
-		if (filenameList.size() > 0) {
+		if (!filenameList.empty()) {
 			TVINSERTSTRUCT ins;
 			HTREEITEM child = NULL;
 			FilenameList::iterator it = filenameList.begin();
diff --git a/Generals/Code/Tools/WorldBuilder/src/WHeightMapEdit.cpp b/Generals/Code/Tools/WorldBuilder/src/WHeightMapEdit.cpp
@@ -427,7 +427,7 @@ void WorldHeightMapEdit::loadDirectoryOfImages(const char *pFilePath)
 	FilenameList filenameList;
 	TheFileSystem->getFileListInDirectory(AsciiString(dirBuf), "*.*", filenameList, TRUE);
 
-	if (filenameList.size() == 0) {
+	if (filenameList.empty()) {
 		return;
 	}
 	FilenameList::iterator it = filenameList.begin();
@@ -3378,7 +3378,7 @@ void WorldHeightMapEdit::changeBoundary(Int ndx, ICoord2D *border)
 
 void WorldHeightMapEdit::removeLastBoundary(void)
 {
-	if (m_boundaries.size() == 0) {
+	if (m_boundaries.empty()) {
 		DEBUG_CRASH(("Invalid border remove request. jkmcd"));
 		return;
 	}
diff --git a/Generals/Code/Tools/WorldBuilder/src/mapobjectprops.cpp b/Generals/Code/Tools/WorldBuilder/src/mapobjectprops.cpp
@@ -749,7 +749,7 @@ void MapObjectProps::_DictToPrebuiltUpgrades(void)
 				if (!gmbmd) {
 					continue;
 				}
-				if (gmbmd->m_upgradeMuxData.m_activationUpgradeNames.size() > 0) {
+				if (!gmbmd->m_upgradeMuxData.m_activationUpgradeNames.empty()) {
 					cstr = gmbmd->m_upgradeMuxData.m_activationUpgradeNames[0].str();
 					if (pBox->FindString(-1, cstr) == LB_ERR) {
 						pBox->AddString(cstr);
diff --git a/GeneralsMD/Code/GameEngineDevice/Source/W3DDevice/GameLogic/W3DTerrainLogic.cpp b/GeneralsMD/Code/GameEngineDevice/Source/W3DDevice/GameLogic/W3DTerrainLogic.cpp
@@ -183,7 +183,7 @@ void W3DTerrainLogic::getExtent( Region3D *extent ) const
 
 	// Note - m_boundaries are stored in height map grids wide, so we have to
 	// multiply by the grid width.
-	if (m_boundaries.size() > 0) {
+	if (!m_boundaries.empty()) {
 		extent->hi.x = m_boundaries[m_activeBoundary].x*MAP_XY_FACTOR;
 		extent->hi.y = m_boundaries[m_activeBoundary].y*MAP_XY_FACTOR;
 	} else {
diff --git a/GeneralsMD/Code/Tools/WorldBuilder/src/LayersList.cpp b/GeneralsMD/Code/Tools/WorldBuilder/src/LayersList.cpp
@@ -1160,7 +1160,7 @@ void LayersList::OnMergeViewSelection(UINT commandID)
 		mapObject = mapObject->getNext();
 	}
 
-	while (allSelectedObjects.size() > 0) {
+	while (!allSelectedObjects.empty()) {
 		changeMapObjectLayer(allSelectedObjects.top(), layerIt->layerName);
 		allSelectedObjects.pop();
 	}
@@ -1177,7 +1177,7 @@ void LayersList::OnMergeViewSelection(UINT commandID)
 		polygonTrigger = polygonTrigger->getNext();
 	}
 
-	while (allSelectedTriggers.size() > 0) {
+	while (!allSelectedTriggers.empty()) {
 		changePolygonTriggerLayer(allSelectedTriggers.top(), layerIt->layerName);
 		allSelectedTriggers.pop();
 	}
diff --git a/GeneralsMD/Code/Tools/WorldBuilder/src/MeshMoldOptions.cpp b/GeneralsMD/Code/Tools/WorldBuilder/src/MeshMoldOptions.cpp
@@ -86,7 +86,7 @@ BOOL MeshMoldOptions::OnInitDialog()
 		FilenameList filenameList;
 		TheFileSystem->getFileListInDirectory(".\\data\\Editor\\Molds\\", "*.w3d", filenameList, FALSE);
 
-		if (filenameList.size() > 0) {
+		if (!filenameList.empty()) {
 			HTREEITEM child = NULL;
 			FilenameList::iterator it = filenameList.begin();
 			do {
diff --git a/GeneralsMD/Code/Tools/WorldBuilder/src/SelectMacrotexture.cpp b/GeneralsMD/Code/Tools/WorldBuilder/src/SelectMacrotexture.cpp
@@ -78,7 +78,7 @@ BOOL SelectMacrotexture::OnInitDialog()
 		FilenameList filenameList;
 		TheFileSystem->getFileListInDirectory("..\\TestArt\\", "*.tga", filenameList, FALSE);
 
-		if (filenameList.size() > 0) {
+		if (!filenameList.empty()) {
 			TVINSERTSTRUCT ins;
 			HTREEITEM child = NULL;
 			FilenameList::iterator it = filenameList.begin();
diff --git a/GeneralsMD/Code/Tools/WorldBuilder/src/WHeightMapEdit.cpp b/GeneralsMD/Code/Tools/WorldBuilder/src/WHeightMapEdit.cpp
@@ -428,7 +428,7 @@ void WorldHeightMapEdit::loadDirectoryOfImages(const char *pFilePath)
 	FilenameList filenameList;
 	TheFileSystem->getFileListInDirectory(AsciiString(dirBuf), "*.*", filenameList, TRUE);
 
-	if (filenameList.size() == 0) {
+	if (filenameList.empty()) {
 		return;
 	}
 	FilenameList::iterator it = filenameList.begin();
@@ -3350,7 +3350,7 @@ void WorldHeightMapEdit::changeBoundary(Int ndx, ICoord2D *border)
 
 void WorldHeightMapEdit::removeLastBoundary(void)
 {
-	if (m_boundaries.size() == 0) {
+	if (m_boundaries.empty()) {
 		DEBUG_CRASH(("Invalid border remove request. jkmcd"));
 		return;
 	}
diff --git a/GeneralsMD/Code/Tools/WorldBuilder/src/mapobjectprops.cpp b/GeneralsMD/Code/Tools/WorldBuilder/src/mapobjectprops.cpp
@@ -802,7 +802,7 @@ void MapObjectProps::_DictToPrebuiltUpgrades(void)
         if (!gmbmd) {
           continue;
         }
-        if (gmbmd->m_upgradeMuxData.m_activationUpgradeNames.size() > 0) {
+        if (!gmbmd->m_upgradeMuxData.m_activationUpgradeNames.empty()) {
           cstr = gmbmd->m_upgradeMuxData.m_activationUpgradeNames[0].str();
           if (pBox->FindString(-1, cstr) == LB_ERR) {
             pBox->AddString(cstr);

Original file line number	Diff line number	Diff line change
`@@ -826,7 +826,7 @@ void LayersList::OnMergeViewSelection(UINT commandID)`
`826`	`826`	`mapObject = mapObject->getNext();`
`827`	`827`	`}`
`828`	`828`
`829`		`- while (allSelectedObjects.size() > 0) {`
	`829`	`+ while (!allSelectedObjects.empty()) {`
`830`	`830`	`changeMapObjectLayer(allSelectedObjects.top(), layerIt->layerName);`
`831`	`831`	`allSelectedObjects.pop();`
`832`	`832`	`}`
Original file line number	Diff line number	Diff line change
`@@ -427,7 +427,7 @@ void WorldHeightMapEdit::loadDirectoryOfImages(const char *pFilePath)`
`427`	`427`	`FilenameList filenameList;`
`428`	`428`	`TheFileSystem->getFileListInDirectory(AsciiString(dirBuf), ".", filenameList, TRUE);`
`429`	`429`
`430`		`- if (filenameList.size() == 0) {`
	`430`	`+ if (filenameList.empty()) {`
`431`	`431`	`return;`
`432`	`432`	`}`
`433`	`433`	`FilenameList::iterator it = filenameList.begin();`
`@@ -3378,7 +3378,7 @@ void WorldHeightMapEdit::changeBoundary(Int ndx, ICoord2D *border)`
`3378`	`3378`
`3379`	`3379`	`void WorldHeightMapEdit::removeLastBoundary(void)`
`3380`	`3380`	`{`
`3381`		`- if (m_boundaries.size() == 0) {`
	`3381`	`+ if (m_boundaries.empty()) {`
`3382`	`3382`	`DEBUG_CRASH(("Invalid border remove request. jkmcd"));`
`3383`	`3383`	`return;`
`3384`	`3384`	`}`
Original file line number	Diff line number	Diff line change
`@@ -749,7 +749,7 @@ void MapObjectProps::_DictToPrebuiltUpgrades(void)`
`749`	`749`	`if (!gmbmd) {`
`750`	`750`	`continue;`
`751`	`751`	`}`
`752`		`- if (gmbmd->m_upgradeMuxData.m_activationUpgradeNames.size() > 0) {`
	`752`	`+ if (!gmbmd->m_upgradeMuxData.m_activationUpgradeNames.empty()) {`
`753`	`753`	`cstr = gmbmd->m_upgradeMuxData.m_activationUpgradeNames[0].str();`
`754`	`754`	`if (pBox->FindString(-1, cstr) == LB_ERR) {`
`755`	`755`	`pBox->AddString(cstr);`
Original file line number	Diff line number	Diff line change
`@@ -1160,7 +1160,7 @@ void LayersList::OnMergeViewSelection(UINT commandID)`
`1160`	`1160`	`mapObject = mapObject->getNext();`
`1161`	`1161`	`}`
`1162`	`1162`
`1163`		`- while (allSelectedObjects.size() > 0) {`
	`1163`	`+ while (!allSelectedObjects.empty()) {`
`1164`	`1164`	`changeMapObjectLayer(allSelectedObjects.top(), layerIt->layerName);`
`1165`	`1165`	`allSelectedObjects.pop();`
`1166`	`1166`	`}`
`@@ -1177,7 +1177,7 @@ void LayersList::OnMergeViewSelection(UINT commandID)`
`1177`	`1177`	`polygonTrigger = polygonTrigger->getNext();`
`1178`	`1178`	`}`
`1179`	`1179`
`1180`		`- while (allSelectedTriggers.size() > 0) {`
	`1180`	`+ while (!allSelectedTriggers.empty()) {`
`1181`	`1181`	`changePolygonTriggerLayer(allSelectedTriggers.top(), layerIt->layerName);`
`1182`	`1182`	`allSelectedTriggers.pop();`
`1183`	`1183`	`}`