perf(input): Gate timeGetTime call behind key down check in repeat logic

bobtista · bobtista · commit 5b9176e01782 · 2025-12-10T17:11:32.000-05:00
diff --git a/Generals/Code/GameEngine/Source/GameClient/Input/Keyboard.cpp b/Generals/Code/GameEngine/Source/GameClient/Input/Keyboard.cpp
@@ -220,13 +220,14 @@ Bool Keyboard::checkKeyRepeat( void )
 	// Scan Keyboard status array for first key down
 	// long enough to repeat
 	const UnsignedInt KEY_REPEAT_INTERVAL_MSEC = 67; // ~2 frames at 30 FPS
-	UnsignedInt now = timeGetTime();
 	for( key = 0; key < ARRAY_SIZE(m_keyStatus); key++ )
 	{
 
 		if( BitIsSet( m_keyStatus[ key ].state, KEY_STATE_DOWN ) )
 		{
 
+			UnsignedInt now = timeGetTime();
+
 			if( now - m_keyStatus[ key ].keyDownTimeMsec > Keyboard::KEY_REPEAT_DELAY_MSEC )
 			{
 				// Add key to this frame
diff --git a/GeneralsMD/Code/GameEngine/Source/GameClient/Input/Keyboard.cpp b/GeneralsMD/Code/GameEngine/Source/GameClient/Input/Keyboard.cpp
@@ -220,13 +220,14 @@ Bool Keyboard::checkKeyRepeat( void )
 	// Scan Keyboard status array for first key down
 	// long enough to repeat
 	const UnsignedInt KEY_REPEAT_INTERVAL_MSEC = 67; // ~2 frames at 30 FPS
-	UnsignedInt now = timeGetTime();
 	for( key = 0; key < ARRAY_SIZE(m_keyStatus); key++ )
 	{
 
 		if( BitIsSet( m_keyStatus[ key ].state, KEY_STATE_DOWN ) )
 		{
 
+			UnsignedInt now = timeGetTime();
+
 			if( now - m_keyStatus[ key ].keyDownTimeMsec > Keyboard::KEY_REPEAT_DELAY_MSEC )
 			{
 				// Add key to this frame

Original file line number	Diff line number	Diff line change
`@@ -220,13 +220,14 @@ Bool Keyboard::checkKeyRepeat( void )`
`220`	`220`	`// Scan Keyboard status array for first key down`
`221`	`221`	`// long enough to repeat`
`222`	`222`	`const UnsignedInt KEY_REPEAT_INTERVAL_MSEC = 67; // ~2 frames at 30 FPS`
`223`		`- UnsignedInt now = timeGetTime();`
`224`	`223`	`for( key = 0; key < ARRAY_SIZE(m_keyStatus); key++ )`
`225`	`224`	`{`
`226`	`225`
`227`	`226`	`if( BitIsSet( m_keyStatus[ key ].state, KEY_STATE_DOWN ) )`
`228`	`227`	`{`
`229`	`228`
	`229`	`+ UnsignedInt now = timeGetTime();`
	`230`	`+`
`230`	`231`	`if( now - m_keyStatus[ key ].keyDownTimeMsec > Keyboard::KEY_REPEAT_DELAY_MSEC )`
`231`	`232`	`{`
`232`	`233`	`// Add key to this frame`