Delay playback mode assignment until after replay file opens successfully

Author: bobtista

Generals/Code/GameEngine/Source/Common/Recorder.cpp

@@ -1196,7 +1196,8 @@ Bool RecorderClass::playbackFile(AsciiString filename)
 		}
 	}
 
-	m_mode = RECORDERMODETYPE_PLAYBACK;
+	// TheSuperHackers @bugfix bobtista Don't set playback mode until after file opens successfully
+	// to prevent crash if playback is updated while m_file is NULL
 
 	ReplayHeader header;
 	header.forPlayback = TRUE;
@@ -1207,6 +1208,8 @@ Bool RecorderClass::playbackFile(AsciiString filename)
 		return FALSE;
 	}
 
+	m_mode = RECORDERMODETYPE_PLAYBACK;
+
 #ifdef DEBUG_CRASHING
 	Bool versionStringDiff = header.versionString != TheVersion->getUnicodeVersion();
 	Bool versionTimeStringDiff = header.versionTimeString != TheVersion->getUnicodeBuildTime();

GeneralsMD/Code/GameEngine/Source/Common/Recorder.cpp

@@ -1199,7 +1199,8 @@ Bool RecorderClass::playbackFile(AsciiString filename)
 		}
 	}
 
-	m_mode = RECORDERMODETYPE_PLAYBACK;
+	// TheSuperHackers @bugfix bobtista Don't set playback mode until after file opens successfully
+	// to prevent crash if playback is updated while m_file is NULL
 
 	ReplayHeader header;
 	header.forPlayback = TRUE;
@@ -1210,6 +1211,8 @@ Bool RecorderClass::playbackFile(AsciiString filename)
 		return FALSE;
 	}
 
+	m_mode = RECORDERMODETYPE_PLAYBACK;
+
 #ifdef DEBUG_CRASHING
 	Bool versionStringDiff = header.versionString != TheVersion->getUnicodeVersion();
 	Bool versionTimeStringDiff = header.versionTimeString != TheVersion->getUnicodeBuildTime();