refactor: Standardise shroud condition logic

Author: Stubbjax

GeneralsMD/Code/GameEngine/Source/Common/System/BuildAssistant.cpp

@@ -875,10 +875,11 @@ LegalBuildCode BuildAssistant::isLocationClearOfObjects( const Coord3D *worldPos
 
 		// an immobile object will obstruct our building no matter what team it's on
 		if ( them->isKindOf( KINDOF_IMMOBILE ) )	{
+			Bool shrouded = them->getDrawable() && them->getDrawable()->getFullyObscuredByShroud();
 			/* Check for overlap of my exit rectangle to his geom info. */
 			if (checkMyExit && ThePartitionManager->geomCollidesWithGeom(them->getPosition(), hisBounds, them->getOrientation(),
 				&myExitPos, myGeom, angle)) {
-				if (them->getDrawable() && them->getDrawable()->getFullyObscuredByShroud())
+				if (shrouded)
 					return LBC_SHROUD;
 
 				TheTerrainVisual->addFactionBib(them, true);
@@ -887,7 +888,7 @@ LegalBuildCode BuildAssistant::isLocationClearOfObjects( const Coord3D *worldPos
 			// Check for overlap of his exit rectangle with my geom info
 			if (checkHisExit && ThePartitionManager->geomCollidesWithGeom(&hisExitPos, hisGeom, them->getOrientation(),
 					worldPos, myBounds, angle)) {
-				if (them->getDrawable() && them->getDrawable()->getFullyObscuredByShroud())
+				if (shrouded)
 					return LBC_SHROUD;
 
 				TheTerrainVisual->addFactionBib(them, true);
@@ -896,7 +897,7 @@ LegalBuildCode BuildAssistant::isLocationClearOfObjects( const Coord3D *worldPos
 			// Check both exit rectangles together.
 			if (checkMyExit&&checkHisExit&&ThePartitionManager->geomCollidesWithGeom(&hisExitPos, hisGeom, them->getOrientation(),
 					&myExitPos, myGeom, angle)) {
-				if (them->getDrawable() && them->getDrawable()->getFullyObscuredByShroud())
+				if (shrouded)
 					return LBC_SHROUD;
 
 				TheTerrainVisual->addFactionBib(them, true);