fix: change nullptr to appropriate values for non-pointer return types

Author: bobtista

Core/GameEngine/Source/Common/System/RAMFile.cpp

@@ -164,7 +164,7 @@ Bool RAMFile::open( File *file )
 	//USE_PERF_TIMER(RAMFile)
 	if ( file == nullptr )
 	{
-		return nullptr;
+		return FALSE;
 	}
 
 	const Int access = file->getAccess();

Core/GameEngineDevice/Source/W3DDevice/GameClient/W3DVideoBuffer.cpp

@@ -129,7 +129,7 @@ Bool W3DVideoBuffer::allocate( UnsignedInt width, UnsignedInt height )
 
 	if ( w3dFormat == WW3D_FORMAT_UNKNOWN )
 	{
-		return nullptr;
+		return FALSE;
 	}
 
 	m_texture  = MSGNEW("TextureClass") TextureClass ( m_textureWidth, m_textureHeight, w3dFormat, MIP_LEVELS_1 );

Core/Tools/Autorun/WSYS_RAMFile.cpp

@@ -155,7 +155,7 @@ Bool RAMFile::open( File *file )
 {
 	if ( file == nullptr )
 	{
-		return nullptr;
+		return FALSE;
 	}
 
 	Int access = file->getAccess();

Generals/Code/GameEngine/Source/GameLogic/AI/AIPathfind.cpp

@@ -7518,7 +7518,7 @@ Bool Pathfinder::pathDestination( 	Object *obj, const LocomotorSet& locomotorSet
 		PathfindLayerEnum layer, const Coord3D *groupDest)
 {
 	//CRCDEBUG_LOG(("Pathfinder::pathDestination()"));
-	if (m_isMapReady == false) return nullptr;
+	if (m_isMapReady == false) return false;
 
 	if (!obj) return false;
 
@@ -7812,7 +7812,7 @@ Int Pathfinder::checkPathCost(Object *obj, const LocomotorSet& locomotorSet, con
 		const Coord3D *rawTo)
 {
 	//CRCDEBUG_LOG(("Pathfinder::checkPathCost()"));
-	if (m_isMapReady == false) return nullptr;
+	if (m_isMapReady == false) return 0;
 	enum {MAX_COST = 0x7fff0000};
 	if (!obj) return MAX_COST;
 

Generals/Code/GameEngine/Source/GameLogic/Map/TerrainLogic.cpp

@@ -1814,7 +1814,7 @@ Bool TerrainLogic::objectInteractsWithBridgeLayer(Object *obj, Int layer, Bool c
 //-------------------------------------------------------------------------------------------------
 Bool TerrainLogic::objectInteractsWithBridgeEnd(Object *obj, Int layer) const
 {
-	if (layer == LAYER_GROUND) return nullptr;
+	if (layer == LAYER_GROUND) return false;
 	Bridge *pBridge = getFirstBridge();
 
 	while (pBridge ) {

GeneralsMD/Code/GameEngine/Source/GameLogic/AI/AIPathfind.cpp

@@ -7916,7 +7916,7 @@ Bool Pathfinder::pathDestination( 	Object *obj, const LocomotorSet& locomotorSet
 		PathfindLayerEnum layer, const Coord3D *groupDest)
 {
 	//CRCDEBUG_LOG(("Pathfinder::pathDestination()"));
-	if (m_isMapReady == false) return nullptr;
+	if (m_isMapReady == false) return false;
 
 	if (!obj) return false;
 
@@ -8210,7 +8210,7 @@ Int Pathfinder::checkPathCost(Object *obj, const LocomotorSet& locomotorSet, con
 		const Coord3D *rawTo)
 {
 	//CRCDEBUG_LOG(("Pathfinder::checkPathCost()"));
-	if (m_isMapReady == false) return nullptr;
+	if (m_isMapReady == false) return 0;
 	enum {MAX_COST = 0x7fff0000};
 	if (!obj) return MAX_COST;
 
@@ -8467,7 +8467,7 @@ Path *Pathfinder::findClosestPath( Object *obj, const LocomotorSet& locomotorSet
 		return nullptr;
 	}
 
-	if (m_isMapReady == false) return nullptr;
+	if (m_isMapReady == false) return false;
 
 	m_isTunneling = false;
 
@@ -10809,7 +10809,7 @@ Path *Pathfinder::findSafePath( const Object *obj, const LocomotorSet& locomotor
 		const Coord3D *from, const Coord3D* repulsorPos1, const Coord3D* repulsorPos2, Real repulsorRadius)
 {
 	//CRCDEBUG_LOG(("Pathfinder::findSafePath()"));
-	if (m_isMapReady == false) return nullptr; // Should always be ok.
+	if (m_isMapReady == false) return false; // Should always be ok.
 #if defined(RTS_DEBUG)
 //	Int startTimeMS = ::GetTickCount();
 #endif

GeneralsMD/Code/GameEngine/Source/GameLogic/Map/TerrainLogic.cpp

@@ -1814,7 +1814,7 @@ Bool TerrainLogic::objectInteractsWithBridgeLayer(Object *obj, Int layer, Bool c
 //-------------------------------------------------------------------------------------------------
 Bool TerrainLogic::objectInteractsWithBridgeEnd(Object *obj, Int layer) const
 {
-	if (layer == LAYER_GROUND) return nullptr;
+	if (layer == LAYER_GROUND) return false;
 	Bridge *pBridge = getFirstBridge();
 
 	while (pBridge ) {