refactor: Use static cast instead of dynamic cast

Author: Stubbjax

Generals/Code/GameEngine/Include/GameLogic/Module/ContainModule.h

@@ -86,6 +86,7 @@ class ContainModuleInterface
 	virtual Bool isGarrisonable() const = 0;
 	virtual Bool isSpecialZeroSlotContainer() const = 0;
 	virtual Bool isHealContain() const = 0;
+	virtual Bool isTunnelContain() const = 0;
 	virtual Bool isImmuneToClearBuildingAttacks() const = 0;
 
 

Generals/Code/GameEngine/Include/GameLogic/Module/HealContain.h

@@ -66,6 +66,7 @@ class HealContain : public OpenContain
 
 	virtual UpdateSleepTime update();												///< called once per frame
 	virtual Bool isHealContain() const { return true; } ///< true when container only contains units while healing (not a transport!)
+	virtual Bool isTunnelContain() const { return FALSE; }
 
 protected:
 

Generals/Code/GameEngine/Include/GameLogic/Module/OpenContain.h

@@ -191,6 +191,7 @@ class OpenContain : public UpdateModule,
 
 	virtual Bool isGarrisonable() const { return false; }		///< can this unit be Garrisoned? (ick)
 	virtual Bool isHealContain() const { return false; } ///< true when container only contains units while healing (not a transport!)
+	virtual Bool isTunnelContain() const { return FALSE; }
 	virtual Bool isSpecialZeroSlotContainer() const { return false; }
 	virtual Bool isImmuneToClearBuildingAttacks() const { return true; }
 

Generals/Code/GameEngine/Source/Common/RTS/TunnelTracker.cpp

@@ -332,7 +332,10 @@ void TunnelTracker::updateFullHealTime()
 			continue;
 
 		const ContainModuleInterface* contain = tunnelObj->getContain();
-		const TunnelContain* tunnelContain = dynamic_cast<const TunnelContain*>(contain); // Downcast is not ideal
+		if (!contain->isTunnelContain())
+			continue;
+
+		const TunnelContain* tunnelContain = static_cast<const TunnelContain*>(contain); // Downcast is not ideal
 		if (!tunnelContain)
 			continue;
 

GeneralsMD/Code/GameEngine/Source/Common/RTS/TunnelTracker.cpp

@@ -333,7 +333,10 @@ void TunnelTracker::updateFullHealTime()
 			continue;
 
 		const ContainModuleInterface* contain = tunnelObj->getContain();
-		const TunnelContain* tunnelContain = dynamic_cast<const TunnelContain*>(contain); // Downcast is not ideal
+		if (!contain->isTunnelContain())
+			continue;
+
+		const TunnelContain* tunnelContain = static_cast<const TunnelContain*>(contain); // Downcast is not ideal
 		if (!tunnelContain)
 			continue;