[ZH] Fix RenderObjClass memory leaks in W3DPropBuffer (#1319)

Author: xezon

GeneralsMD/Code/GameEngineDevice/Source/W3DDevice/GameClient/W3DPropBuffer.cpp

@@ -101,10 +101,7 @@ void W3DPropBuffer::cull(CameraClass * camera)
 //=============================================================================
 W3DPropBuffer::~W3DPropBuffer(void)
 {
-	Int i;
-	for (i=0; i<MAX_TYPES; i++) {
-		REF_PTR_RELEASE(m_propTypes[i].m_robj);
-	}
+	clearAllProps();
 	REF_PTR_RELEASE(m_light);
 	REF_PTR_RELEASE(m_propShroudMaterialPass);
 }
@@ -119,7 +116,8 @@ W3DPropBuffer::W3DPropBuffer(void)
 {
 	memset(this, sizeof(W3DPropBuffer), 0);
 	m_initialized = false;
-	clearAllProps();
+	m_numProps = 0;
+	m_numPropTypes = 0;
 	m_light = NEW_REF( LightClass, (LightClass::DIRECTIONAL) );
 	m_propShroudMaterialPass = NEW_REF(W3DShroudMaterialPassClass,());
 	m_initialized = true;
@@ -136,13 +134,16 @@ W3DPropBuffer::W3DPropBuffer(void)
 //=============================================================================
 void W3DPropBuffer::clearAllProps(void)
 {
-	m_numProps=0;
 	Int i;
-	for (i=0; i<MAX_TYPES; i++) {
+	for (i=0; i<m_numPropTypes; i++) {
 		REF_PTR_RELEASE(m_propTypes[i].m_robj);
 		m_propTypes[i].m_robjName.clear();
 	}
+	for (i=0; i<m_numProps; i++) {
+		REF_PTR_RELEASE(m_props[i].m_robj);
+	}
 	m_numPropTypes = 0;
+	m_numProps = 0;
 }
 
 //=============================================================================