[GEN][ZH] Fix Memory Manager initialization issues (#1275)

xezon · web-flow · commit 9c8b539d647c · 2025-07-14T23:00:05.000+02:00
diff --git a/Generals/Code/GameEngine/Source/Common/System/Debug.cpp b/Generals/Code/GameEngine/Source/Common/System/Debug.cpp
@@ -166,9 +166,6 @@ inline HWND getThreadHWND()
 int MessageBoxWrapper( LPCSTR lpText, LPCSTR lpCaption, UINT uType )
 {
 	HWND threadHWND = getThreadHWND();
-	if (!threadHWND)
-		return (uType & MB_ABORTRETRYIGNORE)?IDIGNORE:IDYES;
-
 	return ::MessageBox(threadHWND, lpText, lpCaption, uType);
 }
 
@@ -365,8 +362,9 @@ void DebugInit(int flags)
 	#ifdef DEBUG_LOGGING
 
 		// TheSuperHackers @info Debug initialization can happen very early.
-		// Therefore, parse initial commandline and initialize the client instance now.
+		// Determine the client instance id before creating the log file with an instance specific name.
 		CommandLine::parseCommandLineForStartup();
+
 		if (!rts::ClientInstance::initialize())
 			return;
 
@@ -482,9 +480,11 @@ const char* DebugGetLogFileNamePrev()
 // ----------------------------------------------------------------------------
 #ifdef DEBUG_CRASHING
 /**
-	Print a character string to the logfile and/or console, then halt execution
+	Print a character string to the log file and/or console, then halt execution
 	while presenting the user with an exit/debug/ignore dialog containing the same
 	text message.
+
+	TheSuperHackers @tweak Now shows a message box without any logging when debug was not yet initialized.
 */
 void DebugCrash(const char *format, ...)
 {
@@ -493,53 +493,40 @@ void DebugCrash(const char *format, ...)
 
 	// make it not static so that it'll be thread-safe.
 	// make it big to avoid weird overflow bugs in debug mode
-	char theCrashBuffer[ LARGE_BUFFER ];	
-	if (theDebugFlags == 0)
-	{
-		if (!DX8Wrapper_IsWindowed) {
-			if (ApplicationHWnd) {
-				ShowWindow(ApplicationHWnd, SW_HIDE);
-			}
-		}
-		MessageBoxWrapper("DebugCrash - Debug not inited properly", "", MB_OK|MB_TASKMODAL);
-	}
+	char theCrashBuffer[ LARGE_BUFFER ];
 
 	prepBuffer(theCrashBuffer);
 	strcat(theCrashBuffer, "ASSERTION FAILURE: ");
 
 	va_list arg;
   va_start(arg, format);
-  vsprintf(theCrashBuffer + strlen(theCrashBuffer), format, arg);
+  vsnprintf(theCrashBuffer + strlen(theCrashBuffer), LARGE_BUFFER, format, arg);
   va_end(arg);
 
-	if (strlen(theCrashBuffer) >= sizeof(theCrashBuffer))
-	{
-		if (!DX8Wrapper_IsWindowed) {
-			if (ApplicationHWnd) {
-				ShowWindow(ApplicationHWnd, SW_HIDE);
-			}
-		}
-		MessageBoxWrapper("String too long for debug buffers", "", MB_OK|MB_TASKMODAL);
-	}
+	whackFunnyCharacters(theCrashBuffer);
 
-#ifdef DEBUG_LOGGING
-	if (ignoringAsserts()) 
+	const bool useLogging = theDebugFlags != 0;
+
+	if (useLogging)
 	{
-		doLogOutput("**** CRASH IN FULL SCREEN - Auto-ignored, CHECK THIS LOG!");
-	}
-	whackFunnyCharacters(theCrashBuffer);
-	doLogOutput(theCrashBuffer);
+#ifdef DEBUG_LOGGING
+		if (ignoringAsserts())
+		{
+			doLogOutput("**** CRASH IN FULL SCREEN - Auto-ignored, CHECK THIS LOG!");
+		}
+		doLogOutput(theCrashBuffer);
 #endif
 #ifdef DEBUG_STACKTRACE
-	if (!(TheGlobalData && TheGlobalData->m_debugIgnoreStackTrace))
-	{
-		doStackDump();
-	}
+		if (!(TheGlobalData && TheGlobalData->m_debugIgnoreStackTrace))
+		{
+			doStackDump();
+		}
 #endif
+	}
 
 	strcat(theCrashBuffer, "\n\nAbort->exception; Retry->debugger; Ignore->continue");
 
-	int result = doCrashBox(theCrashBuffer, true);
+	const int result = doCrashBox(theCrashBuffer, useLogging);
 
 	if (result == IDIGNORE && TheCurrentIgnoreCrashPtr != NULL) 
 	{
diff --git a/Generals/Code/GameEngine/Source/Common/System/GameMemory.cpp b/Generals/Code/GameEngine/Source/Common/System/GameMemory.cpp
@@ -124,7 +124,7 @@ DECLARE_PERF_TIMER(MemoryPoolInitFilling)
 			s_initFillerValue |= (~(s_initFillerValue << 4)) & 0xf0;
 			s_initFillerValue |= (s_initFillerValue << 8);
 			s_initFillerValue |= (s_initFillerValue << 16);
-			DEBUG_LOG(("Setting MemoryPool initFillerValue to %08x (index %d)",s_initFillerValue,index));
+			//DEBUG_LOG(("Setting MemoryPool initFillerValue to %08x (index %d)",s_initFillerValue,index));
 		}
 	#endif
 
@@ -3424,6 +3424,9 @@ void initMemoryManager()
 		TheDynamicMemoryAllocator = TheMemoryPoolFactory->createDynamicMemoryAllocator(numSubPools, pParms);	// will throw on failure
 		userMemoryManagerInitPools();
 		thePreMainInitFlag = false;
+
+		DEBUG_INIT(DEBUG_FLAGS_DEFAULT);
+		DEBUG_LOG(("*** Initialized the Memory Manager"));
 	}
 	else
 	{
@@ -3433,7 +3436,7 @@ void initMemoryManager()
 		}
 		else 
 		{
-			DEBUG_CRASH(("memory manager is already inited"));
+			DEBUG_CRASH(("Memory Manager is already initialized"));
 		}
 	}
 
@@ -3487,8 +3490,6 @@ static void preMainInitMemoryManager()
 {
 	if (TheMemoryPoolFactory == NULL)
 	{
-		DEBUG_INIT(DEBUG_FLAGS_DEFAULT);
-		DEBUG_LOG(("*** Initing Memory Manager prior to main!"));
 
 		Int numSubPools;
 		const PoolInitRec *pParms;
@@ -3499,6 +3500,9 @@ static void preMainInitMemoryManager()
 		TheDynamicMemoryAllocator = TheMemoryPoolFactory->createDynamicMemoryAllocator(numSubPools, pParms);	// will throw on failure
 		userMemoryManagerInitPools();
 		thePreMainInitFlag = true;
+
+		DEBUG_INIT(DEBUG_FLAGS_DEFAULT);
+		DEBUG_LOG(("*** Initialized the Memory Manager prior to main!"));
 	}
 }
 
@@ -3543,6 +3547,8 @@ void shutdownMemoryManager()
 	}
 
 	theMainInitFlag = false;
+
+	DEBUG_SHUTDOWN();
 }
 
 //-----------------------------------------------------------------------------
diff --git a/Generals/Code/Main/WinMain.cpp b/Generals/Code/Main/WinMain.cpp
@@ -768,7 +768,6 @@ Int APIENTRY WinMain( HINSTANCE hInstance, HINSTANCE hPrevInstance,
 		}
 		::SetCurrentDirectory(buffer);
 
-		CommandLine::parseCommandLineForStartup();
 
 		#ifdef RTS_DEBUG
 			// Turn on Memory heap tracking
@@ -788,6 +787,11 @@ Int APIENTRY WinMain( HINSTANCE hInstance, HINSTANCE hPrevInstance,
 		// Force to be loaded from a file, not a resource so same exe can be used in germany and retail.
  		gLoadScreenBitmap = (HBITMAP)LoadImage(hInstance, "Install_Final.bmp",	IMAGE_BITMAP, 0, 0, LR_SHARED|LR_LOADFROMFILE);
 
+		// initialize the memory manager early
+		initMemoryManager();
+
+		CommandLine::parseCommandLineForStartup();
+
 		// register windows class and create application window
 		if(!TheGlobalData->m_headless && initializeAppWindows(hInstance, nCmdShow, TheGlobalData->m_windowed) == false)
 			return exitcode;
@@ -804,9 +808,6 @@ Int APIENTRY WinMain( HINSTANCE hInstance, HINSTANCE hPrevInstance,
 		// BGC - initialize COM
 	//	OleInitialize(NULL);
 
-		// start the log
-		DEBUG_INIT(DEBUG_FLAGS_DEFAULT);
-		initMemoryManager();
 
  
 		// Set up version info
@@ -830,7 +831,6 @@ Int APIENTRY WinMain( HINSTANCE hInstance, HINSTANCE hPrevInstance,
 			delete TheVersion;
 			TheVersion = NULL;
 			shutdownMemoryManager();
-			DEBUG_SHUTDOWN();
 			return exitcode;
 		}
 		DEBUG_LOG(("Create Generals Mutex okay."));
@@ -849,9 +849,7 @@ Int APIENTRY WinMain( HINSTANCE hInstance, HINSTANCE hPrevInstance,
 		TheMemoryPoolFactory->memoryPoolUsageReport("AAAMemStats");
 	#endif
 
-		// close the log
 		shutdownMemoryManager();
-		DEBUG_SHUTDOWN();
 
 		// BGC - shut down COM
 	//	OleUninitialize();
diff --git a/GeneralsMD/Code/GameEngine/Source/Common/System/Debug.cpp b/GeneralsMD/Code/GameEngine/Source/Common/System/Debug.cpp
@@ -167,9 +167,6 @@ inline HWND getThreadHWND()
 int MessageBoxWrapper( LPCSTR lpText, LPCSTR lpCaption, UINT uType )
 {
 	HWND threadHWND = getThreadHWND();
-	if (!threadHWND)
-		return (uType & MB_ABORTRETRYIGNORE)?IDIGNORE:IDYES;
-
 	return ::MessageBox(threadHWND, lpText, lpCaption, uType);
 }
 
@@ -366,8 +363,9 @@ void DebugInit(int flags)
 	#ifdef DEBUG_LOGGING
 
 		// TheSuperHackers @info Debug initialization can happen very early.
-		// Therefore, parse initial commandline and initialize the client instance now.
+		// Determine the client instance id before creating the log file with an instance specific name.
 		CommandLine::parseCommandLineForStartup();
+
 		if (!rts::ClientInstance::initialize())
 			return;
 
@@ -483,9 +481,11 @@ const char* DebugGetLogFileNamePrev()
 // ----------------------------------------------------------------------------
 #ifdef DEBUG_CRASHING
 /**
-	Print a character string to the logfile and/or console, then halt execution
+	Print a character string to the log file and/or console, then halt execution
 	while presenting the user with an exit/debug/ignore dialog containing the same
 	text message.
+
+	TheSuperHackers @tweak Now shows a message box without any logging when debug was not yet initialized.
 */
 void DebugCrash(const char *format, ...)
 {
@@ -494,53 +494,40 @@ void DebugCrash(const char *format, ...)
 
 	// make it not static so that it'll be thread-safe.
 	// make it big to avoid weird overflow bugs in debug mode
-	char theCrashBuffer[ LARGE_BUFFER ];	
-	if (theDebugFlags == 0)
-	{
-		if (!DX8Wrapper_IsWindowed) {
-			if (ApplicationHWnd) {
-				ShowWindow(ApplicationHWnd, SW_HIDE);
-			}
-		}
-		MessageBoxWrapper("DebugCrash - Debug not inited properly", "", MB_OK|MB_TASKMODAL);
-	}
+	char theCrashBuffer[ LARGE_BUFFER ];
 
 	prepBuffer(theCrashBuffer);
 	strcat(theCrashBuffer, "ASSERTION FAILURE: ");
 
 	va_list arg;
   va_start(arg, format);
-  vsprintf(theCrashBuffer + strlen(theCrashBuffer), format, arg);
+  vsnprintf(theCrashBuffer + strlen(theCrashBuffer), LARGE_BUFFER, format, arg);
   va_end(arg);
 
-	if (strlen(theCrashBuffer) >= sizeof(theCrashBuffer))
-	{
-		if (!DX8Wrapper_IsWindowed) {
-			if (ApplicationHWnd) {
-				ShowWindow(ApplicationHWnd, SW_HIDE);
-			}
-		}
-		MessageBoxWrapper("String too long for debug buffers", "", MB_OK|MB_TASKMODAL);
-	}
+	whackFunnyCharacters(theCrashBuffer);
 
-#ifdef DEBUG_LOGGING
-	if (ignoringAsserts()) 
+	const bool useLogging = theDebugFlags != 0;
+
+	if (useLogging)
 	{
-		doLogOutput("**** CRASH IN FULL SCREEN - Auto-ignored, CHECK THIS LOG!");
-	}
-	whackFunnyCharacters(theCrashBuffer);
-	doLogOutput(theCrashBuffer);
+#ifdef DEBUG_LOGGING
+		if (ignoringAsserts()) 
+		{
+			doLogOutput("**** CRASH IN FULL SCREEN - Auto-ignored, CHECK THIS LOG!");
+		}
+		doLogOutput(theCrashBuffer);
 #endif
 #ifdef DEBUG_STACKTRACE
-	if (!(TheGlobalData && TheGlobalData->m_debugIgnoreStackTrace))
-	{
-		doStackDump();
-	}
+		if (!(TheGlobalData && TheGlobalData->m_debugIgnoreStackTrace))
+		{
+			doStackDump();
+		}
 #endif
+	}
 
 	strcat(theCrashBuffer, "\n\nAbort->exception; Retry->debugger; Ignore->continue");
 
-	int result = doCrashBox(theCrashBuffer, true);
+	const int result = doCrashBox(theCrashBuffer, useLogging);
 
 	if (result == IDIGNORE && TheCurrentIgnoreCrashPtr != NULL) 
 	{
diff --git a/GeneralsMD/Code/GameEngine/Source/Common/System/GameMemory.cpp b/GeneralsMD/Code/GameEngine/Source/Common/System/GameMemory.cpp
@@ -126,7 +126,7 @@ DECLARE_PERF_TIMER(MemoryPoolInitFilling)
 			s_initFillerValue |= (~(s_initFillerValue << 4)) & 0xf0;
 			s_initFillerValue |= (s_initFillerValue << 8);
 			s_initFillerValue |= (s_initFillerValue << 16);
-			DEBUG_LOG(("Setting MemoryPool initFillerValue to %08x (index %d)",s_initFillerValue,index));
+			//DEBUG_LOG(("Setting MemoryPool initFillerValue to %08x (index %d)",s_initFillerValue,index));
 		}
 	#endif
 
@@ -3414,6 +3414,9 @@ void initMemoryManager()
 		TheDynamicMemoryAllocator = TheMemoryPoolFactory->createDynamicMemoryAllocator(numSubPools, pParms);	// will throw on failure
 		userMemoryManagerInitPools();
 		thePreMainInitFlag = false;
+
+		DEBUG_INIT(DEBUG_FLAGS_DEFAULT);
+		DEBUG_LOG(("*** Initialized the Memory Manager"));
 	}
 	else
 	{
@@ -3423,7 +3426,7 @@ void initMemoryManager()
 		}
 		else 
 		{
-			DEBUG_CRASH(("memory manager is already inited"));
+			DEBUG_CRASH(("Memory Manager is already initialized"));
 		}
 	}
 
@@ -3477,8 +3480,6 @@ static void preMainInitMemoryManager()
 {
 	if (TheMemoryPoolFactory == NULL)
 	{
-		DEBUG_INIT(DEBUG_FLAGS_DEFAULT);
-		DEBUG_LOG(("*** Initing Memory Manager prior to main!"));
 
 		Int numSubPools;
 		const PoolInitRec *pParms;
@@ -3489,6 +3490,9 @@ static void preMainInitMemoryManager()
 		TheDynamicMemoryAllocator = TheMemoryPoolFactory->createDynamicMemoryAllocator(numSubPools, pParms);	// will throw on failure
 		userMemoryManagerInitPools();
 		thePreMainInitFlag = true;
+
+		DEBUG_INIT(DEBUG_FLAGS_DEFAULT);
+		DEBUG_LOG(("*** Initialized the Memory Manager prior to main!"));
 	}
 }
 
@@ -3533,6 +3537,8 @@ void shutdownMemoryManager()
 	}
 
 	theMainInitFlag = false;
+
+	DEBUG_SHUTDOWN();
 }
 
 //-----------------------------------------------------------------------------
diff --git a/GeneralsMD/Code/Main/WinMain.cpp b/GeneralsMD/Code/Main/WinMain.cpp

Original file line number	Diff line number	Diff line change
`@@ -124,7 +124,7 @@ DECLARE_PERF_TIMER(MemoryPoolInitFilling)`
`124`	`124`	`s_initFillerValue \|= (~(s_initFillerValue << 4)) & 0xf0;`
`125`	`125`	`s_initFillerValue \|= (s_initFillerValue << 8);`
`126`	`126`	`s_initFillerValue \|= (s_initFillerValue << 16);`
`127`		`- DEBUG_LOG(("Setting MemoryPool initFillerValue to %08x (index %d)",s_initFillerValue,index));`
	`127`	`+ //DEBUG_LOG(("Setting MemoryPool initFillerValue to %08x (index %d)",s_initFillerValue,index));`
`128`	`128`	`}`
`129`	`129`	`#endif`
`130`	`130`
`@@ -3424,6 +3424,9 @@ void initMemoryManager()`
`3424`	`3424`	`TheDynamicMemoryAllocator = TheMemoryPoolFactory->createDynamicMemoryAllocator(numSubPools, pParms); // will throw on failure`
`3425`	`3425`	`userMemoryManagerInitPools();`
`3426`	`3426`	`thePreMainInitFlag = false;`
	`3427`	`+`
	`3428`	`+ DEBUG_INIT(DEBUG_FLAGS_DEFAULT);`
	`3429`	`+ DEBUG_LOG(("*** Initialized the Memory Manager"));`
`3427`	`3430`	`}`
`3428`	`3431`	`else`
`3429`	`3432`	`{`
`@@ -3433,7 +3436,7 @@ void initMemoryManager()`
`3433`	`3436`	`}`
`3434`	`3437`	`else`
`3435`	`3438`	`{`
`3436`		`- DEBUG_CRASH(("memory manager is already inited"));`
	`3439`	`+ DEBUG_CRASH(("Memory Manager is already initialized"));`
`3437`	`3440`	`}`
`3438`	`3441`	`}`
`3439`	`3442`
`@@ -3487,8 +3490,6 @@ static void preMainInitMemoryManager()`
`3487`	`3490`	`{`
`3488`	`3491`	`if (TheMemoryPoolFactory == NULL)`
`3489`	`3492`	`{`
`3490`		`- DEBUG_INIT(DEBUG_FLAGS_DEFAULT);`
`3491`		`- DEBUG_LOG(("*** Initing Memory Manager prior to main!"));`
`3492`	`3493`
`3493`	`3494`	`Int numSubPools;`
`3494`	`3495`	`const PoolInitRec *pParms;`
`@@ -3499,6 +3500,9 @@ static void preMainInitMemoryManager()`
`3499`	`3500`	`TheDynamicMemoryAllocator = TheMemoryPoolFactory->createDynamicMemoryAllocator(numSubPools, pParms); // will throw on failure`
`3500`	`3501`	`userMemoryManagerInitPools();`
`3501`	`3502`	`thePreMainInitFlag = true;`
	`3503`	`+`
	`3504`	`+ DEBUG_INIT(DEBUG_FLAGS_DEFAULT);`
	`3505`	`+ DEBUG_LOG(("*** Initialized the Memory Manager prior to main!"));`
`3502`	`3506`	`}`
`3503`	`3507`	`}`
`3504`	`3508`
`@@ -3543,6 +3547,8 @@ void shutdownMemoryManager()`
`3543`	`3547`	`}`
`3544`	`3548`
`3545`	`3549`	`theMainInitFlag = false;`
	`3550`	`+`
	`3551`	`+ DEBUG_SHUTDOWN();`
`3546`	`3552`	`}`
`3547`	`3553`
`3548`	`3554`	`//-----------------------------------------------------------------------------`
Original file line number	Diff line number	Diff line change
`@@ -126,7 +126,7 @@ DECLARE_PERF_TIMER(MemoryPoolInitFilling)`
`126`	`126`	`s_initFillerValue \|= (~(s_initFillerValue << 4)) & 0xf0;`
`127`	`127`	`s_initFillerValue \|= (s_initFillerValue << 8);`
`128`	`128`	`s_initFillerValue \|= (s_initFillerValue << 16);`
`129`		`- DEBUG_LOG(("Setting MemoryPool initFillerValue to %08x (index %d)",s_initFillerValue,index));`
	`129`	`+ //DEBUG_LOG(("Setting MemoryPool initFillerValue to %08x (index %d)",s_initFillerValue,index));`
`130`	`130`	`}`
`131`	`131`	`#endif`
`132`	`132`
`@@ -3414,6 +3414,9 @@ void initMemoryManager()`
`3414`	`3414`	`TheDynamicMemoryAllocator = TheMemoryPoolFactory->createDynamicMemoryAllocator(numSubPools, pParms); // will throw on failure`
`3415`	`3415`	`userMemoryManagerInitPools();`
`3416`	`3416`	`thePreMainInitFlag = false;`
	`3417`	`+`
	`3418`	`+ DEBUG_INIT(DEBUG_FLAGS_DEFAULT);`
	`3419`	`+ DEBUG_LOG(("*** Initialized the Memory Manager"));`
`3417`	`3420`	`}`
`3418`	`3421`	`else`
`3419`	`3422`	`{`
`@@ -3423,7 +3426,7 @@ void initMemoryManager()`
`3423`	`3426`	`}`
`3424`	`3427`	`else`
`3425`	`3428`	`{`
`3426`		`- DEBUG_CRASH(("memory manager is already inited"));`
	`3429`	`+ DEBUG_CRASH(("Memory Manager is already initialized"));`
`3427`	`3430`	`}`
`3428`	`3431`	`}`
`3429`	`3432`
`@@ -3477,8 +3480,6 @@ static void preMainInitMemoryManager()`
`3477`	`3480`	`{`
`3478`	`3481`	`if (TheMemoryPoolFactory == NULL)`
`3479`	`3482`	`{`
`3480`		`- DEBUG_INIT(DEBUG_FLAGS_DEFAULT);`
`3481`		`- DEBUG_LOG(("*** Initing Memory Manager prior to main!"));`
`3482`	`3483`
`3483`	`3484`	`Int numSubPools;`
`3484`	`3485`	`const PoolInitRec *pParms;`
`@@ -3489,6 +3490,9 @@ static void preMainInitMemoryManager()`
`3489`	`3490`	`TheDynamicMemoryAllocator = TheMemoryPoolFactory->createDynamicMemoryAllocator(numSubPools, pParms); // will throw on failure`
`3490`	`3491`	`userMemoryManagerInitPools();`
`3491`	`3492`	`thePreMainInitFlag = true;`
	`3493`	`+`
	`3494`	`+ DEBUG_INIT(DEBUG_FLAGS_DEFAULT);`
	`3495`	`+ DEBUG_LOG(("*** Initialized the Memory Manager prior to main!"));`
`3492`	`3496`	`}`
`3493`	`3497`	`}`
`3494`	`3498`
`@@ -3533,6 +3537,8 @@ void shutdownMemoryManager()`
`3533`	`3537`	`}`
`3534`	`3538`
`3535`	`3539`	`theMainInitFlag = false;`
	`3540`	`+`
	`3541`	`+ DEBUG_SHUTDOWN();`
`3536`	`3542`	`}`
`3537`	`3543`
`3538`	`3544`	`//-----------------------------------------------------------------------------`