fix(replay): prevent crash when replay deleted during version mismatch prompt

Author: bobtista

Generals/Code/GameEngine/Source/Common/Recorder.cpp

@@ -1192,7 +1192,8 @@ Bool RecorderClass::playbackFile(AsciiString filename)
 		}
 	}
 
-	m_mode = RECORDERMODETYPE_PLAYBACK;
+	// TheSuperHackers @bugfix bobtista Don't set playback mode until after file opens successfully
+	// to prevent crash if playback is updated while m_file is NULL
 
 	ReplayHeader header;
 	header.forPlayback = TRUE;
@@ -1203,6 +1204,8 @@ Bool RecorderClass::playbackFile(AsciiString filename)
 		return FALSE;
 	}
 
+	m_mode = RECORDERMODETYPE_PLAYBACK;
+
 #ifdef DEBUG_CRASHING
 	Bool versionStringDiff = header.versionString != TheVersion->getUnicodeVersion();
 	Bool versionTimeStringDiff = header.versionTimeString != TheVersion->getUnicodeBuildTime();

Generals/Code/GameEngine/Source/GameClient/GUI/GUICallbacks/Menus/ReplayMenu.cpp

@@ -82,10 +82,13 @@ static GameWindow *buttonAnalyzeReplay = NULL;
 
 void deleteReplay( void );
 void copyReplay( void );
+void showReplayNotFoundError( void );
 static Bool callCopy = FALSE;
 static Bool callDelete = FALSE;
+static Bool callShowReplayNotFound = FALSE;
 void deleteReplayFlag( void ) { callDelete = TRUE;}
 void copyReplayFlag( void ) { callCopy = TRUE;}
+void showReplayNotFoundFlag( void ) { callShowReplayNotFound = TRUE;}
 
 UnicodeString GetReplayFilenameFromListbox(GameWindow *listbox, Int index)
 {
@@ -462,6 +465,8 @@ void ReplayMenuUpdate( WindowLayout *layout, void *userData )
 		copyReplay();
 	if(callDelete)
 		deleteReplay();
+	if(callShowReplayNotFound)
+		showReplayNotFoundError();
 		// We'll only be successful if we've requested to
 	if(isShuttingDown && TheShell->isAnimFinished()&& TheTransitionHandler->isFinished())
 		TheShell->shutdownComplete( layout );
@@ -534,7 +539,22 @@ void reallyLoadReplay(void)
 	AsciiString asciiFilename;
 	asciiFilename.translate(filename);
 
-	TheRecorder->playbackFile(asciiFilename);
+	// TheSuperHackers @bugfix bobtista Validate file exists before playback to prevent crash when deleted during version mismatch prompt
+	AsciiString filepath = TheRecorder->getReplayDir();
+	filepath.concat(asciiFilename.str());
+	
+	File *testFile = TheFileSystem->openFile(filepath.str(), File::READ | File::BINARY);
+	if (testFile == NULL)
+	{
+		showReplayNotFoundFlag();
+		return;
+	}
+	testFile->close();
+
+	if(!TheRecorder->playbackFile(asciiFilename))
+	{
+		return;
+	}
 
 	if(parentReplayMenu != NULL)
 	{
@@ -797,3 +817,11 @@ void copyReplay( void )
 
 }
 
+void showReplayNotFoundError( void )
+{
+	callShowReplayNotFound = FALSE;
+	UnicodeString title = TheGameText->FETCH_OR_SUBSTITUTE("GUI:ReplayFileNotFoundTitle", L"REPLAY NOT FOUND");
+	UnicodeString body = TheGameText->FETCH_OR_SUBSTITUTE("GUI:ReplayFileNotFound", L"This replay cannot be loaded because the file no longer exists on this device.");
+	MessageBoxOk(title, body, NULL);
+}
+

GeneralsMD/Code/GameEngine/Source/Common/Recorder.cpp

@@ -1195,7 +1195,8 @@ Bool RecorderClass::playbackFile(AsciiString filename)
 		}
 	}
 
-	m_mode = RECORDERMODETYPE_PLAYBACK;
+	// TheSuperHackers @bugfix bobtista Don't set playback mode until after file opens successfully
+	// to prevent crash if playback is updated while m_file is NULL
 
 	ReplayHeader header;
 	header.forPlayback = TRUE;
@@ -1206,6 +1207,8 @@ Bool RecorderClass::playbackFile(AsciiString filename)
 		return FALSE;
 	}
 
+	m_mode = RECORDERMODETYPE_PLAYBACK;
+
 #ifdef DEBUG_CRASHING
 	Bool versionStringDiff = header.versionString != TheVersion->getUnicodeVersion();
 	Bool versionTimeStringDiff = header.versionTimeString != TheVersion->getUnicodeBuildTime();

GeneralsMD/Code/GameEngine/Source/GameClient/GUI/GUICallbacks/Menus/ReplayMenu.cpp

@@ -82,10 +82,13 @@ static GameWindow *buttonAnalyzeReplay = NULL;
 
 void deleteReplay( void );
 void copyReplay( void );
+void showReplayNotFoundError( void );
 static Bool callCopy = FALSE;
 static Bool callDelete = FALSE;
+static Bool callShowReplayNotFound = FALSE;
 void deleteReplayFlag( void ) { callDelete = TRUE;}
 void copyReplayFlag( void ) { callCopy = TRUE;}
+void showReplayNotFoundFlag( void ) { callShowReplayNotFound = TRUE;}
 
 UnicodeString GetReplayFilenameFromListbox(GameWindow *listbox, Int index)
 {
@@ -462,6 +465,8 @@ void ReplayMenuUpdate( WindowLayout *layout, void *userData )
 		copyReplay();
 	if(callDelete)
 		deleteReplay();
+	if(callShowReplayNotFound)
+		showReplayNotFoundError();
 		// We'll only be successful if we've requested to
 	if(isShuttingDown && TheShell->isAnimFinished()&& TheTransitionHandler->isFinished())
 		TheShell->shutdownComplete( layout );
@@ -534,7 +539,22 @@ void reallyLoadReplay(void)
 	AsciiString asciiFilename;
 	asciiFilename.translate(filename);
 
-	TheRecorder->playbackFile(asciiFilename);
+	// TheSuperHackers @bugfix bobtista Validate file exists before playback to prevent crash when deleted during version mismatch prompt
+	AsciiString filepath = TheRecorder->getReplayDir();
+	filepath.concat(asciiFilename.str());
+	
+	File *testFile = TheFileSystem->openFile(filepath.str(), File::READ | File::BINARY);
+	if (testFile == NULL)
+	{
+		showReplayNotFoundFlag();
+		return;
+	}
+	testFile->close();
+
+	if(!TheRecorder->playbackFile(asciiFilename))
+	{
+		return;
+	}
 
 	if(parentReplayMenu != NULL)
 	{
@@ -797,3 +817,11 @@ void copyReplay( void )
 
 }
 
+void showReplayNotFoundError( void )
+{
+	callShowReplayNotFound = FALSE;
+	UnicodeString title = TheGameText->FETCH_OR_SUBSTITUTE("GUI:ReplayFileNotFoundTitle", L"REPLAY NOT FOUND");
+	UnicodeString body = TheGameText->FETCH_OR_SUBSTITUTE("GUI:ReplayFileNotFound", L"This replay cannot be loaded because the file no longer exists on this device.");
+	MessageBoxOk(title, body, NULL);
+}
+