Skip to content

Commit 9eabced

Browse files
refactor: Dedup by calling reset in the init of GameLogic
1 parent 813284b commit 9eabced

File tree

2 files changed

+2
-63
lines changed

2 files changed

+2
-63
lines changed

Generals/Code/GameEngine/Source/GameLogic/System/GameLogic.cpp

Lines changed: 1 addition & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -370,9 +370,6 @@ void GameLogic::init( void )
370370

371371
setFPMode();
372372

373-
/// @todo Clear object and destroy lists
374-
setDefaults( FALSE );
375-
376373
// create the partition manager
377374
ThePartitionManager = NEW PartitionManager;
378375
ThePartitionManager->init();
@@ -400,32 +397,8 @@ void GameLogic::init( void )
400397
//DEBUG_ASSERTCRASH(ThePlayerList, ("null ThePlayerList"));
401398
//ThePlayerList->setLocalPlayer(0);
402399

403-
m_CRC = 0;
404-
m_pauseFrame = 0;
405-
m_gamePaused = FALSE;
406-
m_pauseSound = FALSE;
407-
m_pauseMusic = FALSE;
408-
m_pauseInput = FALSE;
409-
m_inputEnabledMemory = TRUE;
410-
m_mouseVisibleMemory = TRUE;
411-
m_logicTimeScaleEnabledMemory = FALSE;
412-
413-
for(Int i = 0; i < MAX_SLOTS; ++i)
414-
{
415-
m_progressComplete[i] = FALSE;
416-
m_progressCompleteTimeout[i] = 0;
417-
}
418-
m_forceGameStartByTimeOut = FALSE;
419-
420-
m_isScoringEnabled = TRUE;
421-
m_showBehindBuildingMarkers = TRUE;
422-
m_drawIconUI = TRUE;
423-
m_showDynamicLOD = TRUE;
424-
m_scriptHulkMaxLifetimeOverride = -1;
425-
400+
reset();
426401
m_isInUpdate = FALSE;
427-
428-
m_rankPointsToAddAtGameStart = 0;
429402
}
430403

431404
//-------------------------------------------------------------------------------------------------

GeneralsMD/Code/GameEngine/Source/GameLogic/System/GameLogic.cpp

Lines changed: 1 addition & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -338,7 +338,6 @@ void GameLogic::destroyAllObjectsImmediate()
338338
// ------------------------------------------------------------------------------------------------
339339
GameLogic::~GameLogic()
340340
{
341-
342341
// clear any object TOC we might have
343342
m_objectTOC.clear();
344343

@@ -382,18 +381,13 @@ GameLogic::~GameLogic()
382381
// ------------------------------------------------------------------------------------------------
383382
void GameLogic::init( void )
384383
{
385-
386384
setFPMode();
387385

388-
/// @todo Clear object and destroy lists
389-
setDefaults( FALSE );
390-
391386
// create the partition manager
392387
ThePartitionManager = NEW PartitionManager;
393388
ThePartitionManager->init();
394389
ThePartitionManager->setName("ThePartitionManager");
395390

396-
397391
// Create system for holding deleted objects that are
398392
// still in the partition manager because player has a fogged
399393
// view of them.
@@ -411,36 +405,8 @@ void GameLogic::init( void )
411405
TheScriptEngine->init();
412406
TheScriptEngine->setName("TheScriptEngine");
413407

414-
// create a team for the player
415-
//DEBUG_ASSERTCRASH(ThePlayerList, ("null ThePlayerList"));
416-
//ThePlayerList->setLocalPlayer(0);
417-
418-
m_CRC = 0;
419-
m_pauseFrame = 0;
420-
m_gamePaused = FALSE;
421-
m_pauseSound = FALSE;
422-
m_pauseMusic = FALSE;
423-
m_pauseInput = FALSE;
424-
m_inputEnabledMemory = TRUE;
425-
m_mouseVisibleMemory = TRUE;
426-
m_logicTimeScaleEnabledMemory = FALSE;
427-
428-
for(Int i = 0; i < MAX_SLOTS; ++i)
429-
{
430-
m_progressComplete[i] = FALSE;
431-
m_progressCompleteTimeout[i] = 0;
432-
}
433-
m_forceGameStartByTimeOut = FALSE;
434-
435-
m_isScoringEnabled = TRUE;
436-
m_showBehindBuildingMarkers = TRUE;
437-
m_drawIconUI = TRUE;
438-
m_showDynamicLOD = TRUE;
439-
m_scriptHulkMaxLifetimeOverride = -1;
440-
408+
reset();
441409
m_isInUpdate = FALSE;
442-
443-
m_rankPointsToAddAtGameStart = 0;
444410
}
445411

446412
//-------------------------------------------------------------------------------------------------

0 commit comments

Comments
 (0)