refactor(pathfinder): Extract functionality Pathfinder::checkCellOutsideExtents (#1619)

Author: Mauller

Generals/Code/GameEngine/Include/GameLogic/AIPathfind.h

@@ -825,6 +825,8 @@ class Pathfinder : PathfindServicesInterface, public Snapshot
 
 	void checkChangeLayers(PathfindCell *parentCell);
 
+	bool checkCellOutsideExtents(ICoord2D& cell);
+
 #if defined(RTS_DEBUG)
 	void doDebugIcons(void) ;
 #endif

Generals/Code/GameEngine/Source/GameLogic/AI/AIPathfind.cpp

@@ -5362,6 +5362,13 @@ void Pathfinder::checkChangeLayers(PathfindCell *parentCell)
 	m_openList = newCell->putOnSortedOpenList( m_openList );
 }
 
+bool Pathfinder::checkCellOutsideExtents(ICoord2D& cell) {
+	return 	cell.x < m_logicalExtent.lo.x ||
+					cell.x > m_logicalExtent.hi.x ||
+					cell.y < m_logicalExtent.lo.y ||
+					cell.y > m_logicalExtent.hi.y;
+}
+
 
 struct ExamineCellsStruct
 {

GeneralsMD/Code/GameEngine/Include/GameLogic/AIPathfind.h

@@ -833,6 +833,8 @@ class Pathfinder : PathfindServicesInterface, public Snapshot
 
 	void checkChangeLayers(PathfindCell *parentCell);
 
+	bool checkCellOutsideExtents(ICoord2D& cell);
+
 #if defined(RTS_DEBUG)
 	void doDebugIcons(void) ;
 #endif

GeneralsMD/Code/GameEngine/Source/GameLogic/AI/AIPathfind.cpp

@@ -5662,6 +5662,13 @@ void Pathfinder::checkChangeLayers(PathfindCell *parentCell)
 	m_openList = newCell->putOnSortedOpenList( m_openList );
 }
 
+bool Pathfinder::checkCellOutsideExtents(ICoord2D& cell) {
+	return 	cell.x < m_logicalExtent.lo.x ||
+					cell.x > m_logicalExtent.hi.x ||
+					cell.y < m_logicalExtent.lo.y ||
+					cell.y > m_logicalExtent.hi.y;
+}
+
 
 struct ExamineCellsStruct
 {