Skip to content

Commit aec4b84

Browse files
committed
refactor(network): split argument type/count size calculation into separate lines
1 parent 04bab57 commit aec4b84

File tree

3 files changed

+8
-4
lines changed

3 files changed

+8
-4
lines changed

Generals/Code/GameEngine/Source/GameNetwork/NetPacket.cpp

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -370,7 +370,8 @@ UnsignedInt NetPacket::GetGameCommandSize(NetCommandMsg *msg) {
370370
// Int numTypes = parser->getNumTypes();
371371
GameMessageParserArgumentType *arg = parser->getFirstArgumentType();
372372
while (arg != NULL) {
373-
msglen += 2 * sizeof(UnsignedByte); // for the type and number of args of that type declaration.
373+
msglen += sizeof(UnsignedByte); // argument type
374+
msglen += sizeof(UnsignedByte); // argument count
374375
GameMessageArgumentDataType type = arg->getType();
375376

376377
switch (type) {
@@ -4938,7 +4939,8 @@ Bool NetPacket::isRoomForGameMessage(NetCommandRef *msg, GameMessage *gmsg) {
49384939
// Int numTypes = parser->getNumTypes();
49394940
GameMessageParserArgumentType *arg = parser->getFirstArgumentType();
49404941
while (arg != NULL) {
4941-
msglen += 2 * sizeof(UnsignedByte); // for the type and number of args of that type declaration.
4942+
msglen += sizeof(UnsignedByte); // argument type
4943+
msglen += sizeof(UnsignedByte); // argument count
49424944
GameMessageArgumentDataType type = arg->getType();
49434945

49444946
switch (type) {

GeneralsMD/Code/GameEngine/Source/GameNetwork/NetCommandMsg.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -248,7 +248,8 @@ size_t NetGameCommandMsg::getByteCount() const {
248248

249249
GameMessageParserArgumentType *arg = parser->getFirstArgumentType();
250250
while (arg != NULL) {
251-
msglen += 2 * sizeof(UnsignedByte); // for the type and number of args of that type declaration.
251+
msglen += sizeof(UnsignedByte); // argument type
252+
msglen += sizeof(UnsignedByte); // argument count
252253
GameMessageArgumentDataType type = arg->getType();
253254

254255
switch (type) {

GeneralsMD/Code/GameEngine/Source/GameNetwork/NetPacket.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4582,7 +4582,8 @@ Bool NetPacket::isRoomForGameMessage(NetCommandRef *msg, GameMessage *gmsg) {
45824582
// Int numTypes = parser->getNumTypes();
45834583
GameMessageParserArgumentType *arg = parser->getFirstArgumentType();
45844584
while (arg != NULL) {
4585-
msglen += 2 * sizeof(UnsignedByte); // for the type and number of args of that type declaration.
4585+
msglen += sizeof(UnsignedByte); // argument type
4586+
msglen += sizeof(UnsignedByte); // argument count
45864587
GameMessageArgumentDataType type = arg->getType();
45874588

45884589
switch (type) {

0 commit comments

Comments
 (0)