bugfix(ai): Undetected mines can now be approached when using a disarm weapon (#1883)

Author: Stubbjax

Generals/Code/GameEngine/Source/GameLogic/AI/AIStates.cpp

@@ -2596,7 +2596,17 @@ StateReturnType AIAttackApproachTargetState::updateInternal()
 	{
 		if( victim->testStatus( OBJECT_STATUS_STEALTHED ) && !victim->testStatus( OBJECT_STATUS_DETECTED ) )
 		{
-			return STATE_FAILURE;	// If obj is stealthed, can no longer approach.
+			// If obj is stealthed, can no longer approach.
+			// TheSuperHackers @bugfix Stubbjax 19/11/2025 Except when disarming stealthed mines.
+#if RETAIL_COMPATIBLE_CRC
+			return STATE_FAILURE;
+#else
+			const Bool isTargetingMine = weapon && weapon->getDamageType() == DAMAGE_DISARM &&
+				(victim->isKindOf(KINDOF_MINE));
+
+			if (!isTargetingMine)
+				return STATE_FAILURE;
+#endif
 		}
 		ai->setCurrentVictim(victim);
 		// Attacking an object.

GeneralsMD/Code/GameEngine/Source/GameLogic/AI/AIStates.cpp

@@ -2682,7 +2682,17 @@ StateReturnType AIAttackApproachTargetState::updateInternal()
 		}
 		if( victim->testStatus( OBJECT_STATUS_STEALTHED ) && !victim->testStatus( OBJECT_STATUS_DETECTED ) && !victim->testStatus( OBJECT_STATUS_DISGUISED ) )
 		{
-			return STATE_FAILURE;	// If obj is stealthed, can no longer approach.
+			// If obj is stealthed, can no longer approach.
+			// TheSuperHackers @bugfix Stubbjax 19/11/2025 Except when disarming stealthed mines or traps.
+#if RETAIL_COMPATIBLE_CRC
+			return STATE_FAILURE;
+#else
+			const Bool isTargetingMine = weapon && weapon->getDamageType() == DAMAGE_DISARM &&
+				(victim->isKindOf(KINDOF_MINE) || victim->isKindOf(KINDOF_BOOBY_TRAP) || victim->isKindOf(KINDOF_DEMOTRAP));
+
+			if (!isTargetingMine)
+				return STATE_FAILURE;
+#endif
 		}
 		ai->setCurrentVictim(victim);
 		// Attacking an object.