Skip to content

Commit c318307

Browse files
committed
refactor: Ensure the message sender is the local player
1 parent 0905c4d commit c318307

File tree

2 files changed

+10
-2
lines changed

2 files changed

+10
-2
lines changed

Generals/Code/GameEngine/Source/GameClient/MessageStream/CommandXlat.cpp

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3281,7 +3281,11 @@ GameMessageDisposition CommandTranslator::translateGameMessage(const GameMessage
32813281
case GameMessage::MSG_CREATE_TEAM8:
32823282
case GameMessage::MSG_CREATE_TEAM9:
32833283
{
3284-
ThePlayerList->getLocalPlayer()->processCreateTeamGameMessage(t - GameMessage::MSG_CREATE_TEAM0, msg);
3284+
Int playerIndex = msg->getPlayerIndex();
3285+
Player* player = ThePlayerList->getNthPlayer(playerIndex);
3286+
if (player->isLocalPlayer())
3287+
player->processCreateTeamGameMessage(t - GameMessage::MSG_CREATE_TEAM0, msg);
3288+
32853289
break;
32863290
}
32873291

GeneralsMD/Code/GameEngine/Source/GameClient/MessageStream/CommandXlat.cpp

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3622,7 +3622,11 @@ GameMessageDisposition CommandTranslator::translateGameMessage(const GameMessage
36223622
case GameMessage::MSG_CREATE_TEAM8:
36233623
case GameMessage::MSG_CREATE_TEAM9:
36243624
{
3625-
ThePlayerList->getLocalPlayer()->processCreateTeamGameMessage(t - GameMessage::MSG_CREATE_TEAM0, msg);
3625+
Int playerIndex = msg->getPlayerIndex();
3626+
Player* player = ThePlayerList->getNthPlayer(playerIndex);
3627+
if (player->isLocalPlayer())
3628+
player->processCreateTeamGameMessage(t - GameMessage::MSG_CREATE_TEAM0, msg);
3629+
36263630
break;
36273631
}
36283632

0 commit comments

Comments
 (0)