refactor: replace C-style casts with static_cast

bobtista · bobtista · commit c7d626b3e826 · 2025-10-13T15:27:00.000-04:00
diff --git a/GeneralsMD/Code/GameEngine/Source/GameNetwork/NetPacket.cpp b/GeneralsMD/Code/GameEngine/Source/GameNetwork/NetPacket.cpp
@@ -465,7 +465,7 @@ UnsignedInt NetPacket::GetPacketRouterAckCommandSize(NetCommandMsg *msg) {
 }
 
 UnsignedInt NetPacket::GetDisconnectChatCommandSize(NetCommandMsg *msg) {
-	NetDisconnectChatCommandMsg *cmdMsg = (NetDisconnectChatCommandMsg *)(msg);
+	NetDisconnectChatCommandMsg *cmdMsg = static_cast<NetDisconnectChatCommandMsg*>(msg);
 	UnsignedByte textmsglen = cmdMsg->getText().getLength();
 	return sizeof(NetPacketDisconnectChatCommandHeader) + (textmsglen * sizeof(UnsignedShort));
 }
@@ -475,7 +475,7 @@ UnsignedInt NetPacket::GetDisconnectVoteCommandSize(NetCommandMsg *msg) {
 }
 
 UnsignedInt NetPacket::GetChatCommandSize(NetCommandMsg *msg) {
-	NetChatCommandMsg *cmdMsg = (NetChatCommandMsg *)(msg);
+	NetChatCommandMsg *cmdMsg = static_cast<NetChatCommandMsg*>(msg);
 	UnsignedByte textmsglen = cmdMsg->getText().getLength();
 	return sizeof(NetPacketChatCommandHeader) + (textmsglen * sizeof(UnsignedShort)) + sizeof(Int);
 }

Original file line number	Diff line number	Diff line change
`@@ -465,7 +465,7 @@ UnsignedInt NetPacket::GetPacketRouterAckCommandSize(NetCommandMsg *msg) {`
`465`	`465`	`}`
`466`	`466`
`467`	`467`	`UnsignedInt NetPacket::GetDisconnectChatCommandSize(NetCommandMsg *msg) {`
`468`		`- NetDisconnectChatCommandMsg cmdMsg = (NetDisconnectChatCommandMsg )(msg);`
	`468`	`+ NetDisconnectChatCommandMsg cmdMsg = static_cast<NetDisconnectChatCommandMsg>(msg);`
`469`	`469`	`UnsignedByte textmsglen = cmdMsg->getText().getLength();`
`470`	`470`	`return sizeof(NetPacketDisconnectChatCommandHeader) + (textmsglen * sizeof(UnsignedShort));`
`471`	`471`	`}`
`@@ -475,7 +475,7 @@ UnsignedInt NetPacket::GetDisconnectVoteCommandSize(NetCommandMsg *msg) {`
`475`	`475`	`}`
`476`	`476`
`477`	`477`	`UnsignedInt NetPacket::GetChatCommandSize(NetCommandMsg *msg) {`
`478`		`- NetChatCommandMsg cmdMsg = (NetChatCommandMsg )(msg);`
	`478`	`+ NetChatCommandMsg cmdMsg = static_cast<NetChatCommandMsg>(msg);`
`479`	`479`	`UnsignedByte textmsglen = cmdMsg->getText().getLength();`
`480`	`480`	`return sizeof(NetPacketChatCommandHeader) + (textmsglen * sizeof(UnsignedShort)) + sizeof(Int);`
`481`	`481`	`}`