fix(debug): Print stack trace for unhandled win32 exceptions to debug log (#1424)

Author: slurmlord

Generals/Code/GameEngine/Source/Common/System/StackDump.cpp

@@ -466,7 +466,6 @@ void WriteStackLine(void*address, void (*callback)(const char*))
 			g_LastErrorDump.concat("\n");
 		}
 	callback(line);
-	callback("\n");
 }
 
 //*****************************************************************************

Generals/Code/GameEngine/Source/GameNetwork/GameSpy/Thread/BuddyThread.cpp

@@ -36,8 +36,6 @@
 #include "GameNetwork/GameSpy/PersistentStorageThread.h"
 #include "GameNetwork/GameSpy/ThreadUtils.h"
 
-#include "Common/StackDump.h"
-
 #include "mutex.h"
 #include "thread.h"
 
@@ -262,7 +260,6 @@ GPProfile GameSpyBuddyMessageQueue::getLocalProfileID( void )
 void BuddyThreadClass::Thread_Function()
 {
 	try {
-	_set_se_translator( DumpExceptionInfo ); // Hook that allows stack trace.
 	GPConnection gpCon;
 	GPConnection *con = &gpCon;
 	gpInitialize( con, 675, 0, GP_PARTNERID_GAMESPY );

Generals/Code/GameEngine/Source/GameNetwork/GameSpy/Thread/GameResultsThread.cpp

@@ -34,7 +34,6 @@
 #include "mutex.h"
 #include "thread.h"
 
-#include "Common/StackDump.h"
 #include "Common/SubsystemInterface.h"
 
 //-------------------------------------------------------------------------
@@ -228,7 +227,6 @@ static void WrapHTTP( const std::string& hostname, std::string& results )
 void GameResultsThreadClass::Thread_Function()
 {
 	try {
-	_set_se_translator( DumpExceptionInfo ); // Hook that allows stack trace.
 	GameResultsRequest req;
 
 	WSADATA wsaData;

Generals/Code/GameEngine/Source/GameNetwork/GameSpy/Thread/PeerThread.cpp

@@ -32,7 +32,6 @@
 #include "PreRTS.h"	// This must go first in EVERY cpp file int the GameEngine
 
 #include "Common/Registry.h"
-#include "Common/StackDump.h"
 #include "Common/UserPreferences.h"
 #include "Common/version.h"
 #include "GameNetwork/IPEnumeration.h"
@@ -1149,7 +1148,6 @@ static UnsignedInt localIP = 0;
 void PeerThreadClass::Thread_Function()
 {
 	try {
-	_set_se_translator( DumpExceptionInfo ); // Hook that allows stack trace.
 
 	PEER peer;
 

Generals/Code/GameEngine/Source/GameNetwork/GameSpy/Thread/PersistentStorageThread.cpp

@@ -38,7 +38,6 @@
 #include "mutex.h"
 #include "thread.h"
 
-#include "Common/StackDump.h"
 #include "Common/SubsystemInterface.h"
 
 
@@ -823,7 +822,6 @@ static void getPreorderCallback(int localid, int profileid, persisttype_t type,
 void PSThreadClass::Thread_Function()
 {
 	try {
-	_set_se_translator( DumpExceptionInfo ); // Hook that allows stack trace.
 	/*********
 	First step, set our game authentication info
 	We could do:

Generals/Code/GameEngine/Source/GameNetwork/GameSpy/Thread/PingThread.cpp

@@ -34,7 +34,6 @@
 #include "mutex.h"
 #include "thread.h"
 
-#include "Common/StackDump.h"
 #include "Common/SubsystemInterface.h"
 
 //-------------------------------------------------------------------------
@@ -248,7 +247,6 @@ AsciiString Pinger::getPingString( Int timeout )
 void PingThreadClass::Thread_Function()
 {
 	try {
-	_set_se_translator( DumpExceptionInfo ); // Hook that allows stack trace.
 	PingRequest req;
 
 	WSADATA wsaData;

Generals/Code/Main/WinMain.cpp

@@ -729,6 +729,15 @@ static Bool initializeAppWindows( HINSTANCE hInstance, Int nCmdShow, Bool runWin
 // Necessary to allow memory managers and such to have useful critical sections
 static CriticalSection critSec1, critSec2, critSec3, critSec4, critSec5;
 
+// UnHandledExceptionFilter ===================================================
+/** Handler for unhandled win32 exceptions. */
+//=============================================================================
+static LONG WINAPI UnHandledExceptionFilter( struct _EXCEPTION_POINTERS* e_info )
+{
+	DumpExceptionInfo( e_info->ExceptionRecord->ExceptionCode, e_info );
+	return EXCEPTION_EXECUTE_HANDLER;
+}
+
 // WinMain ====================================================================
 /** Application entry point */
 //=============================================================================
@@ -738,7 +747,7 @@ Int APIENTRY WinMain( HINSTANCE hInstance, HINSTANCE hPrevInstance,
 	Int exitcode = 1;
 	try {
 
-		_set_se_translator( DumpExceptionInfo ); // Hook that allows stack trace.
+		SetUnhandledExceptionFilter( UnHandledExceptionFilter );
 		//
 		// there is something about checkin in and out the .dsp and .dsw files
 		// that blows the working directory information away on each of the

Generals/Code/Tools/WorldBuilder/src/WorldBuilder.cpp

@@ -20,7 +20,6 @@
 //
 
 #include "StdAfx.h"
-#include <eh.h>
 #include "WorldBuilder.h"
 #include "euladialog.h"
 #include "MainFrm.h"
@@ -259,6 +258,14 @@ CWorldBuilderApp::~CWorldBuilderApp()
 	}
 }
 
+/////////////////////////////////////////////////////////////////////////////
+// Handler for unhandled win32 exceptions.
+
+static LONG WINAPI UnHandledExceptionFilter(struct _EXCEPTION_POINTERS* e_info)
+{
+	DumpExceptionInfo(e_info->ExceptionRecord->ExceptionCode, e_info);
+	return EXCEPTION_EXECUTE_HANDLER;
+}
 
 /////////////////////////////////////////////////////////////////////////////
 // CWorldBuilderApp initialization
@@ -272,7 +279,7 @@ BOOL CWorldBuilderApp::InitInstance()
 	}
 
 	// initialization
-  _set_se_translator( DumpExceptionInfo ); // Hook that allows stack trace.
+	SetUnhandledExceptionFilter(UnHandledExceptionFilter);
 
 	// initialize the memory manager early
 	initMemoryManager();

GeneralsMD/Code/GameEngine/Source/Common/System/StackDump.cpp

@@ -466,7 +466,6 @@ void WriteStackLine(void*address, void (*callback)(const char*))
 			g_LastErrorDump.concat("\n");
 		}
 	callback(line);
-	callback("\n");
 }
 
 

GeneralsMD/Code/GameEngine/Source/GameNetwork/GameSpy/Thread/BuddyThread.cpp

@@ -36,8 +36,6 @@
 #include "GameNetwork/GameSpy/PersistentStorageThread.h"
 #include "GameNetwork/GameSpy/ThreadUtils.h"
 
-#include "Common/StackDump.h"
-
 #include "mutex.h"
 #include "thread.h"
 
@@ -262,7 +260,6 @@ GPProfile GameSpyBuddyMessageQueue::getLocalProfileID( void )
 void BuddyThreadClass::Thread_Function()
 {
 	try {
-	_set_se_translator( DumpExceptionInfo ); // Hook that allows stack trace.
 	GPConnection gpCon;
 	GPConnection *con = &gpCon;
 	gpInitialize( con, 823, 0, GP_PARTNERID_GAMESPY );