Skip to content

Commit c8b2dce

Browse files
committed
bugfix: Use global volume modifiers when applying audio volume overrides
1 parent 23a2926 commit c8b2dce

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

Core/GameEngineDevice/Source/MilesAudioDevice/MilesAudioManager.cpp

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2109,7 +2109,7 @@ void MilesAudioManager::adjustVolumeOfPlayingAudio(AsciiString eventName, Real n
21092109
playing->m_audioEventRTS->setVolume(newVolume);
21102110
Real desiredVolume = playing->m_audioEventRTS->getVolume() * playing->m_audioEventRTS->getVolumeShift();
21112111
AIL_sample_volume_pan(playing->m_sample, NULL, &pan);
2112-
AIL_set_sample_volume_pan(playing->m_sample, desiredVolume, pan);
2112+
AIL_set_sample_volume_pan(playing->m_sample, m_soundVolume * desiredVolume, pan);
21132113
}
21142114
}
21152115

@@ -2119,7 +2119,7 @@ void MilesAudioManager::adjustVolumeOfPlayingAudio(AsciiString eventName, Real n
21192119
// Adjust it
21202120
playing->m_audioEventRTS->setVolume(newVolume);
21212121
Real desiredVolume = playing->m_audioEventRTS->getVolume() * playing->m_audioEventRTS->getVolumeShift();
2122-
AIL_set_3D_sample_volume(playing->m_3DSample, desiredVolume);
2122+
AIL_set_3D_sample_volume(playing->m_3DSample, m_sound3DVolume * desiredVolume);
21232123
}
21242124
}
21252125

@@ -2129,8 +2129,12 @@ void MilesAudioManager::adjustVolumeOfPlayingAudio(AsciiString eventName, Real n
21292129
// Adjust it
21302130
playing->m_audioEventRTS->setVolume(newVolume);
21312131
Real desiredVolume = playing->m_audioEventRTS->getVolume() * playing->m_audioEventRTS->getVolumeShift();
2132+
Real streamVolume = (playing->m_audioEventRTS->getAudioEventInfo()->m_soundType == AT_Music)
2133+
? m_musicVolume
2134+
: m_speechVolume;
2135+
21322136
AIL_stream_volume_pan(playing->m_stream, NULL, &pan);
2133-
AIL_set_stream_volume_pan(playing->m_stream, desiredVolume, pan);
2137+
AIL_set_stream_volume_pan(playing->m_stream, streamVolume * desiredVolume, pan);
21342138
}
21352139
}
21362140
}

0 commit comments

Comments
 (0)