Fix abstract class instantiation by creating missing command message classes

- Add NetLoadCompleteCommandMsg and NetTimeOutGameStartCommandMsg classes
- Update ConnectionManager.cpp to use specific classes instead of base NetCommandMsg
- Remove special case handling from NetPacket.cpp since all types now have classes
- Eliminate the switch statement entirely - now just calls virtual function

Author: bobtista

GeneralsMD/Code/GameEngine/Include/GameNetwork/NetCommandMsg.h

@@ -568,4 +568,31 @@ class NetFrameResendRequestCommandMsg : public NetCommandMsg
 protected:
 	UnsignedInt m_frameToResend;
 };
+
+//-----------------------------------------------------------------------------
+/**
+ * The NetLoadCompleteCommandMsg is a simple command message for load complete notifications
+ */
+class NetLoadCompleteCommandMsg : public NetCommandMsg
+{
+	MEMORY_POOL_GLUE_WITH_USERLOOKUP_CREATE(NetLoadCompleteCommandMsg, "NetLoadCompleteCommandMsg")
+public:
+	NetLoadCompleteCommandMsg();
+	
+	size_t getPackedByteCount() const;
+};
+
+//-----------------------------------------------------------------------------
+/**
+ * The NetTimeOutGameStartCommandMsg is a simple command message for timeout game start notifications
+ */
+class NetTimeOutGameStartCommandMsg : public NetCommandMsg
+{
+	MEMORY_POOL_GLUE_WITH_USERLOOKUP_CREATE(NetTimeOutGameStartCommandMsg, "NetTimeOutGameStartCommandMsg")
+public:
+	NetTimeOutGameStartCommandMsg();
+	
+	size_t getPackedByteCount() const;
+};
+
 #endif

GeneralsMD/Code/GameEngine/Source/GameNetwork/ConnectionManager.cpp

@@ -2222,12 +2222,11 @@ void ConnectionManager::updateLoadProgress( Int progress )
 
 void ConnectionManager::loadProgressComplete()
 {
-	NetCommandMsg *msg = newInstance(NetCommandMsg);
+	NetLoadCompleteCommandMsg *msg = newInstance(NetLoadCompleteCommandMsg);
 	msg->setPlayerID( m_localSlot );
 	if (DoesCommandRequireACommandID(msg->getNetCommandType()) == TRUE) {
 		msg->setID(GenerateNextCommandID());
 	}
-	msg->setNetCommandType(NETCOMMANDTYPE_LOADCOMPLETE);
 	processLoadComplete(msg);
 	sendLocalCommand(msg, 0xff ^ (1 << m_localSlot));
 
@@ -2236,9 +2235,8 @@ void ConnectionManager::loadProgressComplete()
 
 void ConnectionManager::sendTimeOutGameStart()
 {
-	NetCommandMsg *msg = newInstance(NetCommandMsg);
+	NetTimeOutGameStartCommandMsg *msg = newInstance(NetTimeOutGameStartCommandMsg);
 	msg->setPlayerID( m_localSlot );
-	msg->setNetCommandType(NETCOMMANDTYPE_TIMEOUTSTART);
 	if (DoesCommandRequireACommandID(msg->getNetCommandType()) == TRUE) {
 		msg->setID(GenerateNextCommandID());
 	}

GeneralsMD/Code/GameEngine/Source/GameNetwork/NetCommandMsg.cpp

@@ -1254,3 +1254,25 @@ size_t NetFrameResendRequestCommandMsg::getPackedByteCount() const {
 	return sizeof(NetPacketFrameResendRequestCommand);
 }
 
+//-------------------------
+// NetLoadCompleteCommandMsg
+//-------------------------
+NetLoadCompleteCommandMsg::NetLoadCompleteCommandMsg() : NetCommandMsg() {
+	m_commandType = NETCOMMANDTYPE_LOADCOMPLETE;
+}
+
+size_t NetLoadCompleteCommandMsg::getPackedByteCount() const {
+	return sizeof(NetPacketLoadCompleteMessage);
+}
+
+//-------------------------
+// NetTimeOutGameStartCommandMsg
+//-------------------------
+NetTimeOutGameStartCommandMsg::NetTimeOutGameStartCommandMsg() : NetCommandMsg() {
+	m_commandType = NETCOMMANDTYPE_TIMEOUTSTART;
+}
+
+size_t NetTimeOutGameStartCommandMsg::getPackedByteCount() const {
+	return sizeof(NetPacketTimeOutGameStartMessage);
+}
+

GeneralsMD/Code/GameEngine/Source/GameNetwork/NetPacket.cpp

@@ -278,18 +278,8 @@ UnsignedInt NetPacket::GetBufferSizeNeededForCommand(NetCommandMsg *msg) {
 	if (msg == NULL) {
 		return TRUE; // There was nothing to add, so it was successful.
 	}
-// Handle special cases that don't have corresponding command message classes
-	switch(msg->getNetCommandType())
-	{
-		case NETCOMMANDTYPE_LOADCOMPLETE:
-			return sizeof(NetPacketLoadCompleteMessage);
-		case NETCOMMANDTYPE_TIMEOUTSTART:
-			return sizeof(NetPacketTimeOutGameStartMessage);
-		default:
-			return msg->getPackedByteCount();
-	}
-
-	return 0;
+	// Use the virtual function for all command message types
+	return msg->getPackedByteCount();
 }