refactor: modernize NULL to nullptr across entire codebase

Author: bobtista

Core/GameEngine/Include/Common/AsciiString.h

@@ -353,7 +353,7 @@ class AsciiString
 		token was found. (note that this modifies 'this' as well, stripping
 		the token off!)
 	*/
-	Bool nextToken(AsciiString* token, const char* seps = NULL);
+	Bool nextToken(AsciiString* token, const char* seps = nullptr);
 
 	/**
 		return true iff the string is "NONE" (case-insensitive).
@@ -390,7 +390,7 @@ inline char* AsciiString::peek() const
 }
 
 // -----------------------------------------------------
-inline AsciiString::AsciiString() : m_data(0)
+inline AsciiString::AsciiString() : m_data(nullptr)
 {
 	validate();
 }
@@ -420,7 +420,7 @@ inline int AsciiString::getByteCount() const
 inline Bool AsciiString::isEmpty() const
 {
 	validate();
-	return m_data == NULL || peek()[0] == 0;
+	return m_data == nullptr || peek()[0] == 0;
 }
 
 // -----------------------------------------------------

Core/GameEngine/Include/Common/AudioEventInfo.h

@@ -123,8 +123,8 @@ struct AudioEventInfo : public MemoryPoolObject
 
   // DynamicAudioEventInfo interfacing functions
   virtual Bool isLevelSpecific() const { return false; } ///< If true, this sound is only defined on the current level and can be deleted when that level ends
-  virtual DynamicAudioEventInfo * getDynamicAudioEventInfo() { return NULL; }  ///< If this object is REALLY a DynamicAudioEventInfo, return a pointer to the derived class
-  virtual const DynamicAudioEventInfo * getDynamicAudioEventInfo() const { return NULL; } ///< If this object is REALLY a DynamicAudioEventInfo, return a pointer to the derived class
+  virtual DynamicAudioEventInfo * getDynamicAudioEventInfo() { return nullptr; }  ///< If this object is REALLY a DynamicAudioEventInfo, return a pointer to the derived class
+  virtual const DynamicAudioEventInfo * getDynamicAudioEventInfo() const { return nullptr; } ///< If this object is REALLY a DynamicAudioEventInfo, return a pointer to the derived class
 
   /// Is this a permenant sound? That is, if I start this sound up, will it ever end
   /// "on its own" or only if I explicitly kill it?

Core/GameEngine/Include/Common/GameAudio.h

@@ -395,7 +395,7 @@ class AudioManagerDummy : public AudioManager
 	virtual AsciiString getMusicTrackName() const { return ""; }
 	virtual void openDevice() {}
 	virtual void closeDevice() {}
-	virtual void* getDevice() { return NULL; }
+	virtual void* getDevice() { return nullptr; }
 	virtual void notifyOfAudioCompletion(UnsignedInt audioCompleted, UnsignedInt flags) {}
 	virtual UnsignedInt getProviderCount(void) const { return 0; };
 	virtual AsciiString getProviderName(UnsignedInt providerNum) const { return ""; }
@@ -416,7 +416,7 @@ class AudioManagerDummy : public AudioManager
 	virtual void removePlayingAudio(AsciiString eventName) {}
 	virtual void removeAllDisabledAudio() {}
 	virtual Bool has3DSensitiveStreamsPlaying(void) const { return false; }
-	virtual void* getHandleForBink(void) { return NULL; }
+	virtual void* getHandleForBink(void) { return nullptr; }
 	virtual void releaseHandleForBink(void) {}
 	virtual void friend_forcePlayAudioEventRTS(const AudioEventRTS* eventToPlay) {}
 	virtual void setPreferredProvider(AsciiString providerNdx) {}

Core/GameEngine/Include/Common/GameMemory.h

@@ -545,7 +545,7 @@ class MemoryPoolFactory
 	/// destroy the contents of all pools and dmas. (the pools and dma's are not destroyed, just reset)
 	void reset();
 
-	void memoryPoolUsageReport( const char* filename, FILE *appendToFileInstead = NULL );
+	void memoryPoolUsageReport( const char* filename, FILE *appendToFileInstead = nullptr );
 
 	#ifdef MEMORYPOOL_DEBUG
 
@@ -743,7 +743,7 @@ class MemoryPoolObject
 	virtual ~MemoryPoolObject() { }
 
 protected:
-	inline void *operator new(size_t s) { DEBUG_CRASH(("This should be impossible")); return 0; }
+	inline void *operator new(size_t s) { DEBUG_CRASH(("This should be impossible")); return nullptr; }
 	inline void operator delete(void *p) { DEBUG_CRASH(("This should be impossible")); }
 
 protected:
@@ -902,9 +902,9 @@ class MemoryPoolObjectHolder
 private:
 	MemoryPoolObject *m_mpo;
 public:
-	MemoryPoolObjectHolder(MemoryPoolObject *mpo = NULL) : m_mpo(mpo) { }
+	MemoryPoolObjectHolder(MemoryPoolObject *mpo = nullptr) : m_mpo(mpo) { }
 	void hold(MemoryPoolObject *mpo) { DEBUG_ASSERTCRASH(!m_mpo, ("already holding")); m_mpo = mpo; }
-	void release() { m_mpo = NULL; }
+	void release() { m_mpo = nullptr; }
 	~MemoryPoolObjectHolder() { deleteInstance(m_mpo); }
 };
 

Core/GameEngine/Include/Common/Radar.h

@@ -165,7 +165,7 @@ class Radar : public Snapshot,
 	virtual void update( void );														///< subsystem per frame update
 
 	// is the game window parameter the radar window
-	Bool isRadarWindow( GameWindow *window ) { return (m_radarWindow == window) && (m_radarWindow != NULL); }
+	Bool isRadarWindow( GameWindow *window ) { return (m_radarWindow == window) && (m_radarWindow != nullptr); }
 
 	Bool radarToWorld( const ICoord2D *radar, Coord3D *world );		///< radar point to world point on terrain
 	Bool radarToWorld2D( const ICoord2D *radar, Coord3D *world );		///< radar point to world point (x,y only!)

Core/GameEngine/Include/Common/UnicodeString.h

@@ -364,7 +364,7 @@ inline WideChar* UnicodeString::peek() const
 }
 
 // -----------------------------------------------------
-inline UnicodeString::UnicodeString() : m_data(0)
+inline UnicodeString::UnicodeString() : m_data(nullptr)
 {
 	validate();
 }
@@ -394,7 +394,7 @@ inline int UnicodeString::getByteCount() const
 inline Bool UnicodeString::isEmpty() const
 {
 	validate();
-	return m_data == NULL || peek()[0] == 0;
+	return m_data == nullptr || peek()[0] == 0;
 }
 
 // -----------------------------------------------------

Core/GameEngine/Include/Common/file.h

@@ -183,7 +183,7 @@ class File : public MemoryPoolObject
 																																				*  END: means seek the specified number of bytes back from the end of the file
 																																				*/
 		virtual Bool	flush() = 0;											///< flush data to disk
-		virtual void	nextLine(Char *buf = NULL, Int bufSize = 0) = 0;		///< reads until it reaches a new-line character
+		virtual void	nextLine(Char *buf = nullptr, Int bufSize = 0) = 0;		///< reads until it reaches a new-line character
 
 		virtual Bool	scanInt(Int &newInt) = 0;														///< read an integer from the current file position.
 		virtual Bool	scanReal(Real &newReal) = 0;												///< read a real number from the current file position.

Core/Libraries/Source/WWVegas/WWLib/always.h

@@ -158,7 +158,7 @@ class W3DMPO
 	static void* getClassMemoryPool()
 	{
 		assert(0);	// must replace this via W3DMPO_GLUE
-		return 0;
+		return nullptr;
 	}
 protected:
 	// we never call this; it is present to cause compile errors in descendent classes

Core/Libraries/Source/WWVegas/WWLib/cpudetect.cpp

@@ -942,7 +942,7 @@ void CPUDetectClass::Init_OS()
    OSVersionExtraInfo   = os.szCSDVersion;
 #else
 	typedef LONG(WINAPI * RtlGetVersionPtr)(PRTL_OSVERSIONINFOW);
-    HMODULE ntdll = LoadLibraryExA("ntdll", NULL, 0);
+    HMODULE ntdll = LoadLibraryExA("ntdll", nullptr, 0);
     if (ntdll != nullptr) {
         RtlGetVersionPtr RtlGetVersion = (RtlGetVersionPtr)::GetProcAddress(ntdll, "RtlGetVersion");
 

Core/Libraries/Source/WWVegas/WWLib/crc.cpp

@@ -90,7 +90,7 @@ void CRCEngine::operator() (char datum)
  *=============================================================================================*/
 long CRCEngine::operator() (void const * buffer, int length)
 {
-	if (buffer != NULL && length > 0)  {
+	if (buffer != nullptr && length > 0)  {
 		char const * dataptr = (char const *)buffer;
 		int bytes_left = length;