Slightly improve perf in operator[]

slurmlord · slurmlord · commit daa4805f8107 · 2025-11-22T14:37:51.000+01:00
diff --git a/Core/GameEngine/Include/Common/UnicodeString.h b/Core/GameEngine/Include/Common/UnicodeString.h
@@ -337,9 +337,9 @@ class UnicodeString
 
 	WideChar& operator[](Int index)
 	{
-		Int length = getLength();
-		DEBUG_ASSERTCRASH(index >= 0 && index < length, ("bad index in UnicodeString::operator[]"));
-		ensureUniqueBufferOfSize(length + 1, true, NULL, NULL);
+		DEBUG_ASSERTCRASH(m_data && m_data->m_numCharsAllocated > index && index >= 0, ("bad index in UnicodeString::operator[]"));
+
+		ensureUniqueBufferOfSize(m_data->m_numCharsAllocated, true, NULL, NULL);
 		return peek()[index];
 	}
 };

Original file line number	Diff line number	Diff line change
`@@ -337,9 +337,9 @@ class UnicodeString`
`337`	`337`
`338`	`338`	`WideChar& operator[](Int index)`
`339`	`339`	`{`
`340`		`- Int length = getLength();`
`341`		`- DEBUG_ASSERTCRASH(index >= 0 && index < length, ("bad index in UnicodeString::operator[]"));`
`342`		`- ensureUniqueBufferOfSize(length + 1, true, NULL, NULL);`
	`340`	`+ DEBUG_ASSERTCRASH(m_data && m_data->m_numCharsAllocated > index && index >= 0, ("bad index in UnicodeString::operator[]"));`
	`341`	`+`
	`342`	`+ ensureUniqueBufferOfSize(m_data->m_numCharsAllocated, true, NULL, NULL);`
`343`	`343`	`return peek()[index];`
`344`	`344`	`}`
`345`	`345`	`};`