refactor(perf): rename move_assign_from_pointer to move_or_swap and change parameter to reference

Author: bobtista

Dependencies/Utility/Utility/CppMacros.h

@@ -49,14 +49,14 @@
 #define nullptr 0
 #endif
 
-// TheSuperHackers @performance bobtista 25/11/2025 Helper to move-assign from pointer: uses std::move in C++11, swap in C++98
+// TheSuperHackers @performance bobtista 25/11/2025 Helper to move-assign from reference: uses std::move in C++11, swap in C++98
 template<typename T>
-inline void move_assign_from_pointer(T& dest, T* src)
+inline void move_or_swap(T& dest, T& src)
 {
 #if __cplusplus >= 201103L
-	dest = std::move(*src);
+	dest = std::move(src);
 #else
 	// Use swap to emulate move semantics for VC6 compatibility
-	dest.swap(*src);
+	dest.swap(src);
 #endif
 }

Generals/Code/GameEngine/Include/GameLogic/AI.h

@@ -539,15 +539,15 @@ class AICommandInterface
 	inline void aiFollowExitProductionPath( std::vector<Coord3D>* path, Object *ignoreObject, CommandSourceType cmdSource )
 	{
 		AICommandParms parms(AICMD_FOLLOW_EXITPRODUCTION_PATH, cmdSource);
-		move_assign_from_pointer(parms.m_coords, path);
+		move_or_swap(parms.m_coords, *path);
 		parms.m_obj = ignoreObject;
 		aiDoCommand(&parms);
 	}
 
 	inline void aiFollowPath( std::vector<Coord3D>* path, Object *ignoreObject, CommandSourceType cmdSource )
 	{
 		AICommandParms parms(AICMD_FOLLOW_PATH, cmdSource);
-		move_assign_from_pointer(parms.m_coords, path);
+		move_or_swap(parms.m_coords, *path);
 		parms.m_obj = ignoreObject;
 		aiDoCommand(&parms);
 	}

Generals/Code/GameEngine/Source/GameLogic/AI/AIStates.cpp

@@ -818,7 +818,7 @@ void AIStateMachine::loadPostProcess( void )
  */
 void AIStateMachine::setGoalPath( std::vector<Coord3D>* path )
 {
-	move_assign_from_pointer(m_goalPath, path);
+	move_or_swap(m_goalPath, *path);
 }
 
 #ifdef STATE_MACHINE_DEBUG

GeneralsMD/Code/GameEngine/Include/GameLogic/AI.h

@@ -553,15 +553,15 @@ class AICommandInterface
 	inline void aiFollowExitProductionPath( std::vector<Coord3D>* path, Object *ignoreObject, CommandSourceType cmdSource )
 	{
 		AICommandParms parms(AICMD_FOLLOW_EXITPRODUCTION_PATH, cmdSource);
-		move_assign_from_pointer(parms.m_coords, path);
+		move_or_swap(parms.m_coords, *path);
 		parms.m_obj = ignoreObject;
 		aiDoCommand(&parms);
 	}
 
 	inline void aiFollowPath( std::vector<Coord3D>* path, Object *ignoreObject, CommandSourceType cmdSource )
 	{
 		AICommandParms parms(AICMD_FOLLOW_PATH, cmdSource);
-		move_assign_from_pointer(parms.m_coords, path);
+		move_or_swap(parms.m_coords, *path);
 		parms.m_obj = ignoreObject;
 		aiDoCommand(&parms);
 	}

GeneralsMD/Code/GameEngine/Source/GameLogic/AI/AIStates.cpp

@@ -823,7 +823,7 @@ void AIStateMachine::loadPostProcess( void )
  */
 void AIStateMachine::setGoalPath( std::vector<Coord3D>* path )
 {
-	move_assign_from_pointer(m_goalPath, path);
+	move_or_swap(m_goalPath, *path);
 }
 
 #ifdef STATE_MACHINE_DEBUG