Skip to content

Commit fc9121f

Browse files
committed
docs: Add reminder for a future refactor
1 parent a520007 commit fc9121f

File tree

2 files changed

+4
-0
lines changed
  • GeneralsMD/Code/GameEngine/Source/GameLogic/Object
  • Generals/Code/GameEngine/Source/GameLogic/Object

2 files changed

+4
-0
lines changed

Generals/Code/GameEngine/Source/GameLogic/Object/Weapon.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -884,6 +884,8 @@ UnsignedInt WeaponTemplate::fireWeaponTemplate
884884

885885
Bool handled;
886886

887+
// TODO: Remove hardcoded KINDOF_MINE check and apply PlayFXWhenStealthed = Yes to the mine weapons instead.
888+
887889
if(!sourceObj->getDrawable()->isVisible() // if user watching cannot see us
888890
&& !sourceObj->isKindOf(KINDOF_MINE) // and not a mine (which always do the FX, even if hidden)...
889891
&& !isPlayFXWhenStealthed() // and not a weapon marked to playwhenstealthed

GeneralsMD/Code/GameEngine/Source/GameLogic/Object/Weapon.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -915,6 +915,8 @@ UnsignedInt WeaponTemplate::fireWeaponTemplate
915915

916916
Bool handled;
917917

918+
// TODO: Remove hardcoded KINDOF_MINE check and apply PlayFXWhenStealthed = Yes to the mine weapons instead.
919+
918920
if(!sourceObj->getDrawable()->isVisible() // if user watching cannot see us
919921
&& !sourceObj->isKindOf(KINDOF_MINE) // and not a mine (which always do the FX, even if hidden)...
920922
&& !isPlayFXWhenStealthed() // and not a weapon marked to playwhenstealthed

0 commit comments

Comments
 (0)