forked from electronicarts/CnC_Generals_Zero_Hour
-
Notifications
You must be signed in to change notification settings - Fork 145
Open
Labels
PerformanceIs a performance concernIs a performance concernStabilityConcerns stability of the runtimeConcerns stability of the runtime
Milestone
Description
Something is wrong with the following line. Perhaps this was meant to be strcpy. Buffer has same length as TGA2_SIGNATURE.
strlcpy(footer.Signature, TGA2_SIGNATURE, sizeof(footer.Signature));There are more copies that can use static_assert's instead.
strlcpy(Name,w3d_data.Name,sizeof(Name));strlcpy(header.Name,AnimName,sizeof(header.Name));
strlcpy(header.HierarchyName,HierarchyName,sizeof(header.HierarchyName));strlcpy(Name, aheader.HierarchyName, ARRAY_SIZE(Name));
strlcat(Name, ".", ARRAY_SIZE(Name));
strlcat(Name, aheader.Name, ARRAY_SIZE(Name));strlcpy(HierarchyName,aheader.HierarchyName,W3D_NAME_LEN);WWVegas code needs another review pass to use static_assert + strcpy instead of strlcpy where so possible.
Metadata
Metadata
Assignees
Labels
PerformanceIs a performance concernIs a performance concernStabilityConcerns stability of the runtimeConcerns stability of the runtime