Replicate relevant GenTool fixes and improvements

[xezon]

GenTool Reference:
https://www.gamereplays.org/cnczerohour/portals.php?show=index&name=gentool&tab=8563343

• Options menu lists resolutions of 4:3 only #72 ----- [GEN][ZH] Enable resolutions with aspect ratios different from 4:3 in Options Menu #460
• Game Control Bar cannot be toggled in Replay Mode #73 ----- [GEN][ZH] Enable Control Bar toggle for Replay playback and match observers #854
• Observer cannot use chat functionality #74 ----- [GEN][ZH] Enable Chat for Observers #864
• Game can crash when clicking on player icon in Replay Mode #75 ----- [GEN][ZH] Fix AIGroup memory management and game crash when a player is selected in Replay playback due heap-use-after-free in GameLogic::logicMessageDispatcher() #1004
• Game crashes when exiting Replay Mode while player places beacon #76 ----- [GEN][ZH] Fix crash when exiting Replay playback while a player places a beacon #971
• Camera height does not scale properly along with aspect ratio of game resolution #78 ----- [ZH] Adjust field of view based on aspect ratio #518
• Game crashes when moving units #82 ----- [GEN][ZH] Fix game crash in AIGroup::friend_moveFormationToPos() #988
• Game scroll speeds do not scale with viewport, aspect ratio and camera pitch #83 ----- bugfix(scrolling): Fix vertical scroll speed bugs #1492
• Units and Buildings can be grouped together by using the SHIFT key feature #101 ----- bugfix(selection): Prevent exploits from grouping structures and units #1347
• Team assignments are net synced but team selections are not which can be problematic #102
• Game does not capture cursor in windowed mode #104 ----- feat(mouse): Implement Cursor Capture functionality #1369
• Supply Dock is black/shadowed in Replay playback #439
• Fix scrolling bugs [GEN][ZH] Fix up the right mouse button scrolling to properly normalize its movement and correctly apply the Scroll Speed modifier #1244 [GEN][ZH] Double scroll amount for RMB, edge and keyboard scrolling #1288
• Fix Critical in-game crash ----- [GEN][ZH] Fix game crash in AIGroup::friend_moveFormationToPos() #988
• Fix Game window is not properly positioned ----- [GEN][ZH] Center Game App Window on startup and resolution change #541
• Fix Auto Camera Height in Replay (when player is selected)
• Add Replay Player Observer, Spectate (key S)
• Add Replay Pausing (key P) ----- [GEN][ZH] Implement feature to Pause and Step Frames in Replay playback #969
• Add Replay Frame Step (key O) ----- [GEN][ZH] Implement feature to Pause and Step Frames in Replay playback #969
• Add Replay Time Pause (keys J/K) (?)
• Add Replay Fast Forward Speed Adjustment
• Add JPG/PNG Screenshot with no stalls (key F11)
• Add FPS Limiter ----- tweak(fps): Decouple logic time step from render update #1451
• Add Clock (left) and Match Timer (right) ----- Add game time display #903 [GEN][ZH] Implement System Time and Game Time display #1170
• Add Latency counter (left), FPS counter (left), FPS Limit (left)
• Add Scroll Speed adjustment ----- [GEN][ZH] Fix and remove Scroll Speed limits #1262
• Add Camera Pitch adjustment (keys PgDown, PageUp, Pos1)
• Add Camera Height adjustment
• Add Screen Brightness adjustment (?)
• Add room option to reveal armies/spots/colors on match load
• Add C&C Online connection
• Add full viewport support for Control Bar Pro Addons (-forcefullviewport cmdl) ----- Implement full viewport for Control Bar Pro support #1284 feat(controlbar): Implement full viewport support for 'Control Bar Pro' Addons #1412
• Add player money/rank/XP display for match Observers

TODO

• Make this a milestone

[Mauller]

If we are looking to start adding some of these now, i can sort #73 and #104 pretty quickly.

I think #72 probably wants some more discussion around if we consider limiting what aspect ratios can be used.
I tried the PR that fixes this but set a max limit for 16:9 and that worked quite well.

[Mauller]

i tried looking into #75 but couldn't reproduce the crashing, could you upload the attached file again?

[Mauller]

EDIT: This code is for the communicator that shows player info, i mistook what it did but roossienb has a PR for enabling chat as an observer.

it looks like #74 may already have functionality within CommandBarObserver.cpp but it has been commented out.

//	if( controlID == buttonCommunicator && TheGameLogic->getGameMode() == GAME_INTERNET )
/*
{
	popupCommunicatorLayout = TheWindowManager->winCreateLayout( AsciiString( "Menus/PopupCommunicator.wnd" ) );
	popupCommunicatorLayout->runInit();
	popupCommunicatorLayout->hide( FALSE );
	popupCommunicatorLayout->bringForward();
}
*/

[Mauller]

It looks like they were going to make health bars scalable with zoom level, but didn't go much further.

But it's all contained in drawable Drawable::drawHealthBar. There are other things in there too for it.

[barefootlogician]

I already have full viewport enabled in a branch but its not compatible with the default command bar. There are various ways I could make it toggle-able

[barefootlogician]

A lot of these changes should be worked on after graphical frame rate is decoupled from logic frames

[Mauller]

I already have full viewport enabled in a branch but its not compatible with the default command bar. There are various ways I could make it toggle-able

we can prevent the command bar code from resizing the viewport and make the command bar scale properly with resolution while maintaining it's original proportions. This way it won't stretch horribly beyond 4:3 and we can add the ability to adjust the scale of it with resolution so it's not horribly stretched out of shape.

A lot of these changes should be worked on after graphical frame rate is decoupled from logic frames

That's going to be quite a significant change overall and likely further down the line if anything

[barefootlogician]

I already have full viewport enabled in a branch but its not compatible with the default command bar. There are various ways I could make it toggle-able

we can prevent the command bar code from resizing the viewport and make the command bar scale properly with resolution while maintaining it's original proportions. This way it won't stretch horribly beyond 4:3 and we can add the ability to adjust the scale of it with resolution so it's not horribly stretched out of shape.

A lot of these changes should be worked on after graphical frame rate is decoupled from logic frames

That's going to be quite a significant change overall and likely further down the line if anything

The issue isn't scaling or any of that. The default command bar makes the viewport about 70% it's original height and pushes it up, hence why we get the black bar if we use command bar pro without gentool. We can disable this and it will technically still work fine with the original command bar but then it makes seeing things at the bottom of the map impossible without rotating the camera or minimizing the command bar.

It being further down the line is fine but then these other changes will also have to be further down the line unless we want to reimplement them afterwards.

[Mauller]

The issue isn't scaling or any of that. The default command bar makes the viewport about 70% it's original height and pushes it up

I did say about preventing it resizing the viewport the command bar code is what causes the viewport to change size.

Better scaling at higher resolutions will mean it's not covering as much of the view etc. It doesn't need to take up 30% of the screen at higher resolutions like it currently does.

[barefootlogician]

The issue isn't scaling or any of that. The default command bar makes the viewport about 70% it's original height and pushes it up

I did say about preventing it resizing the viewport the command bar code is what causes the viewport to change size.

Better scaling at higher resolutions will mean it's not covering as much of the view etc. It doesn't need to take up 30% of the screen at higher resolutions like it currently does.

But then it would be too wide for the height. I don't think gentool changes the command bar height does it? That would be a different enhancement unrelated to this post