tweak(behavior): Improve synchronization of pairs of aircraft taking off #1298
+7
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Caball009
added
China
Caball009
changed the title
Caball009
force-pushed
the
fix_airfield_takeoff_frames
branch
from
6059dcd to
b43d336
Compare
|
This should show the issue: if (findWaiter())
{
UnsignedInt now = TheGameLogic->getFrame();
DEBUG_ASSERTCRASH(m_when == 0 || now < m_when, ("Aircraft is still waiting despite being scheduled to take off"));
return STATE_CONTINUE;
} |
Caball009
changed the title
|
Can you attach a video of the issue? |
cnc.gen.zero.hour.airfield.takeoff.synchronization.mp4Notice how the pairs of aircraft go out of sync for the two bottom left airfields. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The enhancement in this PR works better if the takeoff order is deterministic.
Sometimes when ordering 4 aircraft to take off, one of the aircraft takes off earlier than the other. This happens because aircraft will wait for the next aircraft in line to finish taxiing instead of taking off at the scheduled frame.
TODO