Skip to content

Conversation

@nicholaspcr
Copy link
Contributor

Summary

This updates the aws sdk method used in the blob package.
The reason begin that the s3blob.OpenBucket was deprecated in favor of s3blob.OpenBucketV2

Changes

  • Update AWS bucket access in blob package.

Testing

Steps

Using the CI to test this.

Results
Regressions

...

Notes for Reviewers

...

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Testing: The steps/process to test this feature are clearly explained including testing for regressions.
  • Infrastructure: If infrastructural changes (e.g., new RPC, configuration) are needed, a separate issue is created in the infrastructural repositories.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@nicholaspcr nicholaspcr self-assigned this Jul 29, 2025
@nicholaspcr nicholaspcr force-pushed the fix/blob-bucket-aws-dependency branch from 6777330 to 99f34fb Compare July 29, 2025 15:34
@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Jul 29, 2025
@nicholaspcr nicholaspcr force-pushed the fix/blob-bucket-aws-dependency branch from 237ecfb to 54f6a53 Compare July 29, 2025 15:55
@github-actions github-actions bot added the tooling Development tooling label Jul 29, 2025
@nicholaspcr nicholaspcr marked this pull request as ready for review July 29, 2025 16:05
@nicholaspcr nicholaspcr requested review from a team as code owners July 29, 2025 16:05
@nicholaspcr
Copy link
Contributor Author

I'm getting the following error:

  1. Application Webhook
    succeeds editing webhook:
    AssertionError: Timed out retrying after 10000ms: Unable to find a label with the text of: Webhook format

But I believe this isn't related to the changes of this PR, so I'm merging this as it affects every other open PR.
@ryaplots please validate if this is indeed a flake.

@nicholaspcr nicholaspcr merged commit c214542 into v3.35 Jul 29, 2025
28 of 40 checks passed
@nicholaspcr nicholaspcr deleted the fix/blob-bucket-aws-dependency branch July 29, 2025 16:50
@ryaplots
Copy link
Contributor

Does not seem to be:

{
  "code": 2,
  "message": "error:pkg/applicationserver/io/web:fetch (fetching failed)",
  "details": [
    {
      "@type": "type.googleapis.com/ttn.lorawan.v3.ErrorDetails",
      "namespace": "pkg/applicationserver/io/web",
      "name": "fetch",
      "message_format": "fetching failed",
      "correlation_id": "f6bb9a8e1cd44f9299ed4e7209d04e03",
      "cause": {
        "namespace": "pkg/fetch",
        "name": "fetch_file",
        "message_format": "fetch file `{filename}`",
        "attributes": {
          "filename": "attmaker.yml"
        },
        "correlation_id": "a103cecf9dde406090d58d94720660fe",
        "code": 2
      },
      "code": 2
    }
  ]
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file tooling Development tooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants