[Core/bandwidth] Use 32-bit zero idiom for shorter encoding#410
Closed
Integral-Tech wants to merge 1 commit intoTheTumultuousUnicornOfDarkness:masterfrom
Closed
[Core/bandwidth] Use 32-bit zero idiom for shorter encoding#410Integral-Tech wants to merge 1 commit intoTheTumultuousUnicornOfDarkness:masterfrom
Integral-Tech wants to merge 1 commit intoTheTumultuousUnicornOfDarkness:masterfrom
Conversation
Switch from `xor rax, rax` and `xor rcx, rcx` to `xor eax, eax` and `xor ecx, ecx`. The 32-bit instructions are one byte smaller while yielding the same semantics due to automatic zero-extension in 64-bit mode.
Owner
|
Sorry, I cannot accept this MR because I want to stay closer to the upstream project (modifying such files will make rebase harder). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch from
xor rax, raxandxor rcx, rcxtoxor eax, eaxandxor ecx, ecx. The 32-bit instructions are one byte smaller while yielding the same semantics due to automatic zero-extension in 64-bit mode.