Skip to content

Fix IMA ad container not resizing on orientation change (iOS) #4771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ibad9 wants to merge 4 commits into
base: support/6.x.x
Choose a base branch
from
+10 −1
Open

Fix IMA ad container not resizing on orientation change (iOS) #4771

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c88cef0
Fix IMA ad container not resizing on orientation change (iOS)
Nov 11, 2025
b8bcf68
refactor: lint
moskalakamil Nov 19, 2025
97b3d0a
chore: change comment text
moskalakamil Nov 19, 2025
e3c15f9
refactor: remove redundant frame initialization
moskalakamil Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions ios/Video/Features/RCTIMAAdsManager.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,15 @@
let adContainerView = UIView(frame: _video.bounds)
Copy link

Copilot AI Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Since translatesAutoresizingMaskIntoConstraints is set to false on line 39, the frame parameter passed to UIView(frame:) on line 34 is effectively ignored. Consider using UIView() instead for clarity, as the constraints will determine the view's size and position.

Suggested change
let adContainerView = UIView(frame: _video.bounds)
let adContainerView = UIView()

Copilot uses AI. Check for mistakes.
adContainerView.backgroundColor = .clear
_video.addSubview(adContainerView)

Check failure on line 37 in ios/Video/Features/RCTIMAAdsManager.swift

View workflow job for this annotation

GitHub Actions / Swift-Lint 

Trailing Whitespace Violation: Lines should not have trailing whitespace (trailing_whitespace)
// added layout resize according to subview of video
adContainerView.translatesAutoresizingMaskIntoConstraints = false
NSLayoutConstraint.activate([
adContainerView.topAnchor.constraint(equalTo: _video.topAnchor),
adContainerView.bottomAnchor.constraint(equalTo: _video.bottomAnchor),
adContainerView.leadingAnchor.constraint(equalTo: _video.leadingAnchor),
adContainerView.trailingAnchor.constraint(equalTo: _video.trailingAnchor)
])

// Create ad display container for ad rendering.
let adDisplayContainer = IMAAdDisplayContainer(adContainer: adContainerView, viewController: _video.reactViewController())
Expand Down
Loading