Skip to content

Conversation

@KrzysztofMoch
Copy link
Contributor

Summary

  • fixed notification and app name retrieval
  • fixed condition in useVideoPlayer setup callback

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes critical issues with notification and app name retrieval on Android, and corrects the conditional logic in the useVideoPlayer hook's setup callback. The version is bumped to 7.0.0-alpha.9.

Key Changes

  • Modified useVideoPlayer to check initializeOnCreation !== false instead of truthy check, and added early return when setup is undefined
  • Improved Android app name retrieval to properly handle label resources and non-localized labels
  • Added notification channel existence check to avoid recreating it unnecessarily

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.

File Description
packages/react-native-video/src/core/hooks/useVideoPlayer.ts Fixed conditional logic for initializeOnCreation check (now checks !== false instead of truthy) and added early return when setup is undefined
packages/react-native-video/android/src/main/java/com/twg/video/core/services/playback/VideoPlaybackService.kt Added launch intent caching, notification channel existence check before creation, and improved app name retrieval using labelRes
packages/react-native-video/android/src/main/java/com/twg/video/core/services/playback/CustomMediaNotificationProvider.kt Improved app name retrieval logic to check labelRes first before falling back to nonLocalizedLabel or loadLabel
bun.lock Version bumped from 7.0.0-alpha.8 to 7.0.0-alpha.9 for example and packages

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

Copilot AI commented Nov 23, 2025

@KrzysztofMoch I've opened a new pull request, #4782, to work on those changes. Once the pull request is ready, I'll request review from you.

Co-authored-by: KrzysztofMoch <83216158+KrzysztofMoch@users.noreply.github.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
@KrzysztofMoch KrzysztofMoch merged commit 99d3861 into v7 Nov 23, 2025
4 checks passed
@KrzysztofMoch KrzysztofMoch deleted the feat-v7/android-cache-service-data branch November 23, 2025 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

2 participants