Skip to content

Commit e97823a

Browse files
committed
Fix last style issues.
1 parent 99bb107 commit e97823a

File tree

3 files changed

+17
-16
lines changed

3 files changed

+17
-16
lines changed

src/gpuarray_buffer_cuda.c

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,6 @@ static int setup_done = 0;
129129
static int major = -1;
130130
static int minor = -1;
131131
static int setup_lib(void) {
132-
const char *ver;
133132
CUresult err;
134133
int res, tmp;
135134

@@ -152,12 +151,15 @@ static int setup_lib(void) {
152151
int versions[][2] = {{8, 0}, {7, 5}, {7, 0}};
153152
int versions_length = sizeof(versions) / sizeof(versions[0]);
154153
int i = 0;
154+
/* Skip versions that are higher or equal to the driver version */
155+
while (versions[i][0] > major ||
156+
(versions[i][0] == major && versions[i][1] >= minor)) i++;
155157
do {
156158
major = versions[i][0];
157159
minor = versions[i][1];
158160
res = load_libnvrtc(major, minor, global_err);
159-
++i;
160-
} while(res != GA_NO_ERROR && i < versions_length);
161+
i++;
162+
} while (res != GA_NO_ERROR && i < versions_length);
161163
}
162164
if (res != GA_NO_ERROR)
163165
return res;

src/loaders/libcublas.c

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -47,9 +47,9 @@ int load_libcublas(int major, int minor, error *e) {
4747
#ifdef DEBUG
4848
fprintf(stderr, "Loading cuBLAS %d.%d.\n", major, minor);
4949
#endif
50-
n = snprintf(libname, 64, "cublas64_%d%d.dll", major, minor);
51-
if (n < 0 || n >= 64)
52-
return error_set(e, GA_SYS_ERROR, "cublas library name too long.");
50+
n = snprintf(libname, sizeof(libname), "cublas64_%d%d.dll", major, minor);
51+
if (n < 0 || n >= sizeof(libname))
52+
return error_set(e, GA_SYS_ERROR, "snprintf");
5353
lib = ga_load_library(libname, e);
5454
}
5555
#else /* Unix */
@@ -60,9 +60,9 @@ int load_libcublas(int major, int minor, error *e) {
6060
#ifdef DEBUG
6161
fprintf(stderr, "Loading cuBLAS %d.%d.\n", major, minor);
6262
#endif
63-
n = snprintf(libname, 128, "/Developer/NVIDIA/CUDA-%d.%d/lib/libcublas.dylib", major, minor);
64-
if (n < 0 || n >= 128)
65-
return error_set(e, GA_SYS_ERROR, "cublas library path too long.");
63+
n = snprintf(libname, sizeof(libname), "/Developer/NVIDIA/CUDA-%d.%d/lib/libcublas.dylib", major, minor);
64+
if (n < 0 || n >= sizeof(libname))
65+
return error_set(e, GA_SYS_ERROR, "snprintf");
6666
lib = ga_load_library(libname, e);
6767
}
6868
#else

src/loaders/libnvrtc.c

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -33,24 +33,23 @@ int load_libnvrtc(int major, int minor, error *e) {
3333
#ifdef DEBUG
3434
fprintf(stderr, "Loading nvrtc %d.%d.\n", major, minor);
3535
#endif
36-
n = snprintf(libname, 64, "nvrtc64_%d%d.dll", major, minor);
37-
if (n < 0 || n >= 64)
38-
return error_set(e, GA_SYS_ERROR, "nvrtc library name too long.");
36+
n = snprintf(libname, sizeof(libname), "nvrtc64_%d%d.dll", major, minor);
37+
if (n < 0 || n >= sizeof(libname))
38+
return error_set(e, GA_SYS_ERROR, "snprintf");
3939

4040
lib = ga_load_library(libname, e);
4141
}
4242
#else /* Unix */
4343
#ifdef __APPLE__
4444
{
45-
/* Try the usual fullpath first */
4645
char libname[128];
4746
int n;
4847
#ifdef DEBUG
4948
fprintf(stderr, "Loading nvrtc %d.%d.\n", major, minor);
5049
#endif
51-
n = snprintf(libname, 128, "/Developer/NVIDIA/CUDA-%d.%d/lib/libnvrtc.dylib", major, minor);
52-
if (n < 0 || n >= 128)
53-
return error_set(e, GA_SYS_ERROR, "nvrtc library path too long.");
50+
n = snprintf(libname, sizeof(libname), "/Developer/NVIDIA/CUDA-%d.%d/lib/libnvrtc.dylib", major, minor);
51+
if (n < 0 || n >= sizeof(libname))
52+
return error_set(e, GA_SYS_ERROR, "snprintf");
5453
lib = ga_load_library(libname, e);
5554
}
5655
#else

0 commit comments

Comments
 (0)