Merged
Conversation
This type will provide more robust waking of a Ring::polling thread instead of the is_polling boolean we're currently using.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new type, PollingState, that replaces the old is polling boolean.
The old boolean was inherently racy because of the timing when the boolean was set, the waker checked the value and the actual polling began.
PollingState keep tracks of previous calls to wake and lets the polling thread know if it's been awoken before the call to poll. If this is the case we'll only poll with a zero timeout to ensure it's quick to return, but it will submit all submissions and process any already ready completions.