Skip to content

Commit 8757253

Browse files
authored
Merge branch 'main' into update_user_events_deps
2 parents d4ee4ac + 3d2bf3a commit 8757253

File tree

23 files changed

+138
-48
lines changed

23 files changed

+138
-48
lines changed

.github/workflows/boost_log.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ jobs:
3434
uses: actions/checkout@v3
3535
with:
3636
repository: "open-telemetry/opentelemetry-cpp"
37-
ref: "v1.15.0"
37+
ref: "v1.19.0"
3838
path: "opentelemetry-cpp"
3939
submodules: "recursive"
4040
- name: setup dependencies

.github/workflows/fluentd.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ jobs:
2929
uses: actions/checkout@v3
3030
with:
3131
repository: "open-telemetry/opentelemetry-cpp"
32-
ref: "v1.15.0"
32+
ref: "v1.19.0"
3333
path: "opentelemetry-cpp"
3434
submodules: "recursive"
3535
- name: setup dependencies

.github/workflows/fossa.yml

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
name: FOSSA scanning
2+
3+
on:
4+
push:
5+
branches:
6+
- main
7+
8+
permissions:
9+
contents: read
10+
11+
jobs:
12+
fossa:
13+
runs-on: ubuntu-latest
14+
steps:
15+
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
16+
17+
- uses: fossas/fossa-action@93a52ecf7c3ac7eb40f5de77fd69b1a19524de94 # v1.5.0
18+
with:
19+
api-key: ${{secrets.FOSSA_API_KEY}}
20+
team: OpenTelemetry

.github/workflows/glog.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ jobs:
3838
uses: actions/checkout@v3
3939
with:
4040
repository: "open-telemetry/opentelemetry-cpp"
41-
ref: "v1.15.0"
41+
ref: "v1.19.0"
4242
path: "opentelemetry-cpp"
4343
submodules: "recursive"
4444
- name: setup dependencies

.github/workflows/log4cxx.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ jobs:
3838
uses: actions/checkout@v3
3939
with:
4040
repository: "open-telemetry/opentelemetry-cpp"
41-
ref: "v1.15.0"
41+
ref: "v1.19.0"
4242
path: "opentelemetry-cpp"
4343
submodules: "recursive"
4444
- name: setup dependencies

.github/workflows/prometheus.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ jobs:
6565
uses: actions/checkout@v3
6666
with:
6767
repository: "open-telemetry/opentelemetry-cpp"
68-
ref: "v1.15.0"
68+
ref: "v1.19.0"
6969
path: "otel_cpp"
7070
submodules: "recursive"
7171
- name: run tests
@@ -103,7 +103,7 @@ jobs:
103103
uses: actions/checkout@v3
104104
with:
105105
repository: "open-telemetry/opentelemetry-cpp"
106-
ref: "v1.15.0"
106+
ref: "v1.19.0"
107107
path: "otel_cpp"
108108
submodules: "recursive"
109109
- name: setup

.github/workflows/spdlog.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ jobs:
3232
uses: actions/checkout@v3
3333
with:
3434
repository: "open-telemetry/opentelemetry-cpp"
35-
ref: "v1.15.0"
35+
ref: "v1.19.0"
3636
path: "opentelemetry-cpp"
3737
submodules: "recursive"
3838
- name: setup dependencies

CONTRIBUTING.md

Lines changed: 51 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,27 +1,28 @@
11
# Contributing to opentelemetry-cpp-contrib
22

3-
The OpenTelemetry C/C++ special interest group (SIG) meets regularly. See the
4-
OpenTelemetry [community](https://github.com/open-telemetry/community#cc-sdk)
5-
repo for information on this and other language SIGs.
3+
## Introduction
64

7-
See the [public meeting notes](https://docs.google.com/document/d/1i1E4-_y4uJ083lCutKGDhkpi3n4_e774SBLi9hPLocw/edit)
8-
for a summary description of past meetings. To request edit access, join the
9-
meeting or get in touch on [Gitter](https://gitter.im/open-telemetry/opentelemetry-cpp).
5+
Welcome to the opentelemetry-cpp-contrib repository! This project is an integral part of the broader OpenTelemetry ecosystem, providing additional instrumentation and tools to enhance C/C++ observability.
106

11-
## Development
7+
We greatly appreciate any contributions, no matter the size or scope. Please feel free to reach out to the OpenTelemetry C/C++ community on [slack](https://cloud-native.slack.com/archives/C01N3AT62SJ) with questions or for assistance.
128

13-
TBD
9+
## Prerequisites
1410

15-
### Build and Run Code Examples
11+
[C++14](https://github.com/open-telemetry/opentelemetry-cpp/?tab=readme-ov-file#supported-c-versions) or higher
1612

17-
TBD
13+
CMake 3.18 or higher
14+
15+
Git
1816

19-
## Pull Requests
17+
## Workflow
2018

21-
### How to Send Pull Requests
19+
-Use forked repo when contributing
2220

23-
Everyone is welcome to contribute code to `opentelemetry-cpp-contrib` via GitHub pull
24-
requests (PRs).
21+
-Follow the OpenTelemetry C++ SDK contributing guidelines
22+
23+
-Write clear, concise commit messages
24+
25+
## Local Run/Build
2526

2627
To create a new PR, fork the project in GitHub and clone the upstream repo:
2728

@@ -46,16 +47,49 @@ git push fork feature
4647

4748
Open a pull request against the main `opentelemetry-cpp-contrib` repo.
4849

49-
### How to Receive Comments
50+
### Build and Run Code Examples
51+
52+
TBD
53+
54+
## Testing
55+
56+
TBD
57+
58+
## Contributing Rules
59+
60+
Follow the OpenTelemetry [C++ SDK coding standards](https://github.com/open-telemetry/opentelemetry-cpp?tab=readme-ov-file#supported-c-versions)
61+
62+
Include tests for new features or bug fixes
63+
64+
65+
## How to Receive Comments
5066

5167
* If the PR is not ready for review, please put `[WIP]` in the title, tag it
5268
as `work-in-progress`, or mark it as [`draft`](https://github.blog/2019-02-14-introducing-draft-pull-requests/).
5369
* Make sure [CLA](https://identity.linuxfoundation.org/projects/cncf) is
5470
signed and CI is clear.
71+
72+
## How to Get PRs Merged
73+
74+
Address any reviewer
75+
76+
Ensure all tests pass
77+
78+
The maintainers will squash and merge your commit when approved
79+
80+
81+
82+
## Further Help
83+
84+
The OpenTelemetry C/C++ special interest group (SIG) meets regularly.
85+
86+
See the public meeting notes via the [README](https://github.com/open-telemetry/opentelemetry-cpp?tab=readme-ov-file#contributing) by following the link to the google doc.
87+
88+
Link to join SIG meets also available in the README
89+
90+
For more info and help, join the meeting or get in touch on the [CNCF Slack channel for opentelemetry-cpp](https://cloud-native.slack.com/archives/C01N3AT62SJ).
5591

56-
### How to Get PRs Merged
5792

58-
This section needs to be written.
5993

6094
## Useful Resources
6195

README.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
11
# OpenTelemetry C++ Contrib
22

3+
[![FOSSA License Status](https://app.fossa.com/api/projects/custom%2B162%2Fgithub.com%2Fopen-telemetry%2Fopentelemetry-cpp-contrib.svg?type=shield&issueType=license)](https://app.fossa.com/projects/custom%2B162%2Fgithub.com%2Fopen-telemetry%2Fopentelemetry-cpp-contrib?ref=badge_shield&issueType=license)
4+
[![FOSSA Security Status](https://app.fossa.com/api/projects/custom%2B162%2Fgithub.com%2Fopen-telemetry%2Fopentelemetry-cpp-contrib.svg?type=shield&issueType=security)](https://app.fossa.com/projects/custom%2B162%2Fgithub.com%2Fopen-telemetry%2Fopentelemetry-cpp-contrib?ref=badge_shield&issueType=security)
5+
36
This repository contains set of components extending functionality of the
47
OpenTelemetry SDK. Instrumentation libraries, exporters, and other components
58
can find their home here.

exporters/fluentd/CMakeLists.txt

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -133,16 +133,22 @@ if(OPENTELEMETRY_INSTALL)
133133
endif()
134134

135135
if(BUILD_TESTING)
136-
include(GoogleTest)
136+
if(MAIN_PROJECT)
137+
find_package(GTest CONFIG REQUIRED)
138+
else()
139+
if (NOT DEFINED GTEST_BOTH_LIBRARIES)
140+
message(STATUS_FATAL, "Test is not enable.")
141+
endif()
142+
endif()
143+
# include(GoogleTest)
137144
# build trace exporter tests
138145
add_executable(
139146
fluentd_recordable_trace_test test/trace/fluentd_recordable_test.cc
140147
test/trace/fluentd_baseline_test.cc)
141148

142149
target_link_libraries(
143150
fluentd_recordable_trace_test
144-
gtest
145-
gtest_main
151+
${GTEST_BOTH_LIBRARIES}
146152
${CMAKE_THREAD_LIBS_INIT}
147153
opentelemetry_common
148154
opentelemetry_trace
@@ -164,8 +170,7 @@ if(BUILD_TESTING)
164170

165171
target_link_libraries(
166172
fluentd_recordable_logs_test
167-
gtest
168-
gtest_main
173+
${GTEST_BOTH_LIBRARIES}
169174
${CMAKE_THREAD_LIBS_INIT}
170175
opentelemetry_common
171176
opentelemetry_logs

0 commit comments

Comments
 (0)