Skip to content

Add index for mysql and postgres #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sdil wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add index for mysql and postgres #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion pkg/sql/queue_schema_adapter_mysql.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,15 @@ func (s MySQLQueueSchema) SchemaInitializingQueries(params SchemaInitializingQue
);
`

return []Query{{Query: createMessagesTable}}, nil
createAckedIndex := `
CREATE INDEX ` + "`" + strings.Trim(s.MessagesTable(params.Topic), "`") + `_acked_offset_idx` + "`" + `
ON ` + s.MessagesTable(params.Topic) + ` (` + "`acked`" + `, ` + "`offset`" + `);
`

return []Query{
{Query: createMessagesTable},
{Query: createAckedIndex},
}, nil
}

func (s MySQLQueueSchema) InsertQuery(params InsertQueryParams) (Query, error) {
Expand Down
13 changes: 11 additions & 2 deletions pkg/sql/queue_schema_adapter_postgresql.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ type PostgreSQLQueueSchema struct {
}

func (s PostgreSQLQueueSchema) SchemaInitializingQueries(params SchemaInitializingQueriesParams) ([]Query, error) {
createMessagesTable := `
createMessagesTable := `
CREATE TABLE IF NOT EXISTS ` + s.MessagesTable(params.Topic) + ` (
"offset" SERIAL PRIMARY KEY,
"uuid" VARCHAR(36) NOT NULL,
Expand All @@ -51,7 +51,16 @@ func (s PostgreSQLQueueSchema) SchemaInitializingQueries(params SchemaInitializi
);
`

return []Query{{Query: createMessagesTable}}, nil
createAckedIndex := `
CREATE INDEX IF NOT EXISTS "` + strings.Trim(s.MessagesTable(params.Topic), `"`) + `_acked_idx"
ON ` + s.MessagesTable(params.Topic) + ` ("offset")
WHERE acked = false;
`

return []Query{
{Query: createMessagesTable},
{Query: createAckedIndex},
}, nil
}

func (s PostgreSQLQueueSchema) InsertQuery(params InsertQueryParams) (Query, error) {
Expand Down