Skip to content

docs: correct minor language issues #651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jjpinto wants to merge 1 commit into
base: master
Choose a base branch
from
Open

docs: correct minor language issues #651

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/content/development/pub-sub-implementing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ These scenarios check both basic usage and more uncommon use cases. Stress tests
Here are a few things you shouldn't forget about:

1. Logging (good messages and proper levels).
2. Replaceable and configurable messages marshaller.
2. Replaceable and configurable message marshaler.
3. `Close()` implementation for the publisher and subscriber that is:
- idempotent
- working correctly even when the publisher or the subscriber is blocked (for example, waiting for an Ack).
Expand All @@ -35,6 +35,6 @@ Here are a few things you shouldn't forget about:
7. Performance optimizations.
8. GoDocs, [Markdown docs]({{< ref "/pubsubs" >}}) and [Getting Started examples](/learn/getting-started).

We will also be thankful for submitting a [pull requests](https://github.com/ThreeDotsLabs/watermill/pulls) with the new Pub/Sub implementation.
We will also be thankful for submitting a [pull request](https://github.com/ThreeDotsLabs/watermill/pulls) with the new Pub/Sub implementation.

If anything is not clear, feel free to use any of our [support channels]({{< ref "/support" >}}) to reach us, we will be glad to help.