Fix HTTP response body leak and add retry backoff in run.go #665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sendCountRequest() never closed resp.Body, causing file descriptor and connection leaks under load. This eventually leads to "too many open files" and stalled requests. The retry loop also hammered the server with no delay on non-204 responses. A small backoff prevents excessive CPU and network usage. This makes the exactly-once example more reliable and prevents false failures. Fix ThreeDotsLabs#664
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sendCountRequest() never closed resp.Body, causing file descriptor and connection leaks under load. This eventually leads to "too many open files" and stalled requests.
The retry loop also hammered the server with no delay on non-204 responses. A small backoff prevents excessive CPU and network usage.
This makes the exactly-once example more reliable and prevents false failures.
Fix #664