#603 return 502 on HttpRequestException

Author: jlukawska

src/Ocelot/Errors/OcelotErrorCode.cs

@@ -39,6 +39,7 @@ public enum OcelotErrorCode
         CannotAddPlaceholderError = 34,
         CannotRemovePlaceholderError = 35,
         QuotaExceededError = 36,
-        RequestCanceled = 37,
+        RequestCanceled = 37,
+        ConnectionToDownstreamServiceError = 38,
     }
 }

src/Ocelot/Requester/ConnectionToDownstreamServiceError.cs

@@ -0,0 +1,13 @@
+using Ocelot.Errors;
+using System;
+
+namespace Ocelot.Requester
+{
+    class ConnectionToDownstreamServiceError : Error
+    {
+        public ConnectionToDownstreamServiceError(Exception exception)
+            : base($"Error connecting to downstream service, exception: {exception}", OcelotErrorCode.ConnectionToDownstreamServiceError)
+        {
+        }
+    }
+}

src/Ocelot/Requester/HttpExeptionToErrorMapper.cs

@@ -4,6 +4,8 @@ namespace Ocelot.Requester
     using Microsoft.Extensions.DependencyInjection;
     using System;
     using System.Collections.Generic;
+    using System.Net.Http;
+    using System.Net.Sockets;
 
     public class HttpExeptionToErrorMapper : IExceptionToErrorMapper
     {
@@ -28,6 +30,11 @@ public Error Map(Exception exception)
                 return new RequestCanceledError(exception.Message);
             }
 
+            if (type == typeof(HttpRequestException))
+            {
+                return new ConnectionToDownstreamServiceError(exception);
+            }
+
             return new UnableToCompleteRequestError(exception);
         }
     }

src/Ocelot/Responder/ErrorsToHttpStatusCodeMapper.cs

@@ -38,11 +38,16 @@ public int Map(List<Error> errors)
             if (errors.Any(e => e.Code == OcelotErrorCode.UnableToFindDownstreamRouteError))
             {
                 return 404;
+            }
+
+            if (errors.Any(e => e.Code == OcelotErrorCode.ConnectionToDownstreamServiceError))
+            {
+                return 502;
             }
 
             if (errors.Any(e => e.Code == OcelotErrorCode.UnableToCompleteRequestError))
             {
-                return 502;
+                return 500;
             }
 
             return 404;

test/Ocelot.AcceptanceTests/SslTests.cs

@@ -89,7 +89,7 @@ public void should_not_dangerous_accept_any_server_certificate_validator()
                 .And(x => _steps.GivenThereIsAConfiguration(configuration))
                 .And(x => _steps.GivenOcelotIsRunning())
                 .When(x => _steps.WhenIGetUrlOnTheApiGateway("/"))
-                .Then(x => _steps.ThenTheStatusCodeShouldBe(HttpStatusCode.BadGateway))
+                .Then(x => _steps.ThenTheStatusCodeShouldBe(HttpStatusCode.InternalServerError))
                 .BDDfy();
         }
 

test/Ocelot.UnitTests/Responder/ErrorsToHttpStatusCodeMapperTests.cs

@@ -47,6 +47,13 @@ public void should_return_service_unavailable(OcelotErrorCode errorCode)
 
         [Theory]
         [InlineData(OcelotErrorCode.UnableToCompleteRequestError)]
+        public void should_return_internal_server_error(OcelotErrorCode errorCode)
+        {
+            ShouldMapErrorToStatusCode(errorCode, HttpStatusCode.InternalServerError);
+        }
+
+        [Theory]
+        [InlineData(OcelotErrorCode.ConnectionToDownstreamServiceError)]
         public void should_return_bad_gateway_error(OcelotErrorCode errorCode)
         {
             ShouldMapErrorToStatusCode(errorCode, HttpStatusCode.BadGateway);
@@ -125,7 +132,7 @@ public void check_we_have_considered_all_errors_in_these_tests()
             // If this test fails then it's because the number of error codes has changed.
             // You should make the appropriate changes to the test cases here to ensure
             // they cover all the error codes, and then modify this assertion.
-            Enum.GetNames(typeof(OcelotErrorCode)).Length.ShouldBe(38, "Looks like the number of error codes has changed. Do you need to modify ErrorsToHttpStatusCodeMapper?");
+            Enum.GetNames(typeof(OcelotErrorCode)).Length.ShouldBe(39, "Looks like the number of error codes has changed. Do you need to modify ErrorsToHttpStatusCodeMapper?");
         }
 
         private void ShouldMapErrorToStatusCode(OcelotErrorCode errorCode, HttpStatusCode expectedHttpStatusCode)