Add support for other HTTP verbs for aggregation aka UpstreamHttpMethod enhancements
#1389
+212
−138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefancruz
added a commit
to stefancruz/Ocelot
that referenced
this pull request
Dec 23, 2022
Cherry picked from ThreeMammals#1389
Member
|
Hi Carl! Could you Sync fork please? So, your develop branch is outdated! |
raman-m
added
proposal
raman-m
requested changes
Jul 15, 2023
Member
raman-m
left a comment
raman-m
left a comment
There was a problem hiding this comment.
Everything is OK.
But we have to write a few acceptance tests which will cover added logic.
Could you write at least one acceptance test please?
raman-m
force-pushed
the
user/carl-aggregate-methods
branch
from
5b5bfb0 to
8596743
Compare
Member
|
The feature branch has been rebased onto ThreeMammals:develop! I see that develop branch in your fork is too old! |
raman-m
requested review from
RaynaldM,
abooraja,
anktsrkr,
binarymash,
geffzhang,
jps,
philproctor,
raman-m,
sharpn,
thiagoloureiro,
wast and
yangzhongke
RaynaldM
approved these changes
Aug 22, 2023
raman-m
force-pushed
the
user/carl-aggregate-methods
branch
from
8596743 to
d7dee73
Compare
raman-m
added
Aggregation
raman-m
force-pushed
the
develop
branch
5 times, most recently
from
c216cdf to
b458f0f
Compare
raman-m
force-pushed
the
develop
branch
22 times, most recently
from
908d84f to
0678e7a
Compare
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the FileAggregateRoute to allow other verbs.
It is for consumers not following traditional REST. Several APIs do not follow the REST guidelines and may use POST for getting data. In cases like these being able to specify a verb is helpful.