Skip to content

Comments

Service discovery adds Nacos#2268

Closed
MiaoShuYo wants to merge 2 commits intoThreeMammals:developfrom
MiaoShuYo:nacos_service_discovery
Closed

Service discovery adds Nacos#2268
MiaoShuYo wants to merge 2 commits intoThreeMammals:developfrom
MiaoShuYo:nacos_service_discovery

Conversation

@MiaoShuYo
Copy link

@MiaoShuYo MiaoShuYo commented Mar 18, 2025

@raman-m
Copy link
Member

raman-m commented Mar 18, 2025

Hi @MiaoShuYo,
Thank you for creating this pull request!

I have decided to manage separate repositories for each Ocelot extension package. Since your PR introduces a new service discovery type in Ocelot, I have created a repository specifically for this provider: Ocelot.Discovery.Nacos

Let's close this pull request and kindly go to the new repository to create a new pull request. Please don't push commits.
I have granted you Write permission for collaboration, and you should have received an invitation message in your email inbox. Let's continue development in the Ocelot.Discovery.Nacos repo.

Best regards,
Raman

@raman-m raman-m added proposal Proposal for a new functionality in Ocelot Service Discovery Ocelot feature: Service Discovery labels Mar 18, 2025
@raman-m
Copy link
Member

raman-m commented Mar 18, 2025

Miao, could we keep this PR open to update the documentation later? I can't move documentation development to the new repository because our docs build targets this repository. Therefore, the plan is as follows:

  • Complete package development in Ocelot.Discovery.Nacos repository
  • Set up CI/CD and release the package, publishing it to NuGet
  • Finally, update the documentation in this repository to enable other users to read and use the newly developed package

Does this sound acceptable?

@raman-m raman-m marked this pull request as draft March 18, 2025 10:48
@MiaoShuYo
Copy link
Author

After building play I will write Wendan.

@raman-m
Copy link
Member

raman-m commented Mar 19, 2025

After building play I will write Wendan.

Sorry?

@MiaoShuYo
Copy link
Author

After building play I will write Wendan.

Sorry?

Sorry for the confusion, but I would like to say that after submitting the code, I will add documentation on how to use it.

@raman-m raman-m force-pushed the develop branch 19 times, most recently from 908d84f to 0678e7a Compare April 19, 2025 15:13
@raman-m raman-m marked this pull request as ready for review May 27, 2025 17:06
@raman-m
Copy link
Member

raman-m commented May 27, 2025

Linked PR ThreeMammals/Ocelot.Discovery.Nacos#2 is already merged

@raman-m raman-m closed this May 27, 2025
@raman-m raman-m added the merged Issue has been merged to dev and is waiting for the next release label Jun 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged Issue has been merged to dev and is waiting for the next release proposal Proposal for a new functionality in Ocelot Service Discovery Ocelot feature: Service Discovery

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants